Fix finding of source files with dwarfdump program

* bdx/binary.py (_find_source_file_dwarfdump): Return the path even if
it doesn't exist.
* tests/fixture/Makefile (CFLAGS): Add an argument to have consistent
source in all binaries regardless of compiling machine.
*
tests/test_index.py (test_indexing_adds_source_field_with_dwarfdump):
Update accordingly.
* .github/workflows/ci.yml (Set up build system): Install dwarfdump.
* tests/fixture/subdir/bar.cpp.o:
* tests/fixture/subdir/foo.c.o:
* tests/fixture/toplev.c.o: Rebuild.

Author: mkcms

.github/workflows/ci.yml

@@ -71,6 +71,9 @@ jobs:
           # For generating compile_commands.json file for tests
           sudo apt-get install bear
 
+          # Tests require dwarfdump
+          sudo apt-get install dwarfdump
+
           # Install prerequisites for xapian-bindings.
           # https://github.com/sphinx-doc/sphinx/issues/6524
           pip install Sphinx

bdx/binary.py

@@ -265,9 +265,10 @@ def _find_source_file_dwarfdump(elf: ELFFile) -> Optional[Path]:
     dw_at_name, dw_at_comp_dir = match.groups()
 
     path = Path(dw_at_comp_dir) / Path(dw_at_name)
-    if path.exists():
+    try:
         return path.resolve()
-    return None
+    except OSError:
+        return path
 
 
 def _find_source_file(

tests/fixture/Makefile

@@ -1,3 +1,5 @@
+CFLAGS += "-fdebug-prefix-map=${PWD}=/src"
+
 FILES := \
 	 subdir/bar.cpp \
 	 subdir/foo.c \
@@ -11,12 +13,12 @@ OBJFILES := $(patsubst %,%.o,${FILES})
 %.cpp.o: %.cpp
 	${CXX} ${CFLAGS} -g -c -o $@ $^
 
-compile_commands.json: ${FILES}
-	bear -- ${MAKE} clean default
-
 default: ${OBJFILES}
 
 clean:
 	rm -f ${OBJFILES}
 
+compile_commands.json: ${FILES}
+	bear -- ${MAKE} clean default
+
 .PHONY: default clean

tests/fixture/subdir/bar.cpp.o

@@ -1,4 +1,5 @@
 import shutil
+from pathlib import Path
 from shutil import rmtree
 
 import pytest
@@ -198,12 +199,18 @@ def test_indexing_adds_source_field_with_dwarfdump(fixture_path, tmp_path):
         symbols = list(index.search("path:toplev.c.o"))
         assert symbols
         for symbol in symbols:
-            assert symbol.source == fixture_path / "toplev.c"
+            assert (
+                symbol.source
+                == Path("/src") / "tests" / "fixture" / "toplev.c"
+            )
 
         symbols = list(index.search("path:foo.c.o"))
         assert symbols
         for symbol in symbols:
-            assert symbol.source == fixture_path / "subdir" / "foo.c"
+            assert (
+                symbol.source
+                == Path("/src") / "tests" / "fixture" / "subdir" / "foo.c"
+            )
 
 
 def test_indexing_adds_source_field_with_compilation_database(