fix: solo crash (mutex deadlock) and Windows keyboard duplication

- Fixed solo channel crash on all platforms by moving ui_update_solo_state
  call outside the client_mutex lock scope in ui_remote.cpp
- Fixed Windows keyboard duplication by properly suppressing original WM_CHAR
  messages in the message hook (gui_win32.cpp)
- Updated docs, changelog, and memory bank for v0.133

Author: mkschulze

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to JamWide will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.133] - 2026-01-14
+
+### Fixed
+- **All Platforms**: Solo channel no longer crashes (mutex deadlock fix)
+- **Windows**: Fixed keyboard duplication in text fields (keys no longer repeat)
+
 ## [0.131] - 2026-01-13
 
 ### Added

README.md

@@ -7,7 +7,7 @@ A modern audio plugin client for [NINJAM](https://www.cockos.com/ninjam/) — th
 ![License](https://img.shields.io/badge/license-GPL--2.0-blue.svg)
 ![Platform](https://img.shields.io/badge/platform-macOS%20%7C%20Windows-lightgrey.svg)
 ![Formats](https://img.shields.io/badge/formats-CLAP%20%7C%20VST3%20%7C%20AU-blue.svg)
-![Version](https://img.shields.io/badge/version-v0.132-blue.svg)
+![Version](https://img.shields.io/badge/version-v0.133-blue.svg)
 ![Status](https://img.shields.io/badge/status-beta-yellow.svg)
 
 ## What is NINJAM?

memory-bank/activeContext.md

@@ -2,11 +2,11 @@
 
 ## Current Session Focus
 
-**Date:** 2026-01-13  
+**Date:** 2026-01-14  
 **Phase:** 6 - Beta Release  
-**Status:** ✅ v0.132 Released - Approaching 1.0
+**Status:** ✅ v0.133 Released - Approaching 1.0
 
-## Latest Build: r132
+## Latest Build: r133
 
 ### What's Working
 - ✅ Plugin loads in GarageBand, Logic Pro (AU), REAPER (CLAP/VST3) - macOS
@@ -29,14 +29,14 @@
 - ✅ Anonymous login support
 - ✅ Window size 800x1200 for AU (Logic/GarageBand compatibility)
 
-### Recent Changes (v0.119-v0.132)
+### Recent Changes (v0.119-v0.133)
 | Version | Change |
 |---------|--------|
+| v0.133 | Fix: Solo crash (mutex deadlock), Windows keyboard duplication |
 | v0.132 | macOS/REAPER: Keyboard hint, Chat focus retention, UI polish |
 | v0.120 | Pulled Windows bug fix, verified macOS build works |
 | v0.119 | Windows: Message hook prevents DAW accelerators during text input |
 | v0.117 | Windows: Dummy EDIT control + IME/focus forwarding + null guards |
-| v0.108 | UI: Transmit toggle now visible (layout fix) |
 
 ### Known Issues
 | Issue | Platform | Status |

memory-bank/progress.md

@@ -1,30 +1,30 @@
 # JamWide - Implementation Progress
 
 **Project Start:** January 2026  
-**Current Build:** r132 (v0.132)  
+**Current Build:** r133 (v0.133)  
 **Status:** ✅ Beta - Ready for user testing, approaching 1.0  
 **Target Platforms:** Windows 10+ (MSVC), macOS 10.15+ (Xcode/Clap)  
 **Plugin Formats:** CLAP, VST3, Audio Unit v2 (via clap-wrapper)  
 **UI Framework:** Dear ImGui (Metal on macOS, D3D11 on Windows)  
 **Language:** C++20 (std::variant/std::optional + designated initializers)  
 **CI/CD:** GitHub Actions (Windows + macOS builds on tag push)  
 **Windows Build:** Visual Studio 2022+ (MSVC 19.30+), MSBuild-based, PowerShell install script, ✅ Keyboard focus fixed  
-**macOS Build:** ✅ REAPER keyboard hint, ✅ Chat focus retention
+**macOS Build:** ✅ REAPER keyboard hint, ✅ Chat focus retention, ✅ Solo crash fixed
 
 ---
 
 ## Release History
 
 | Version | Date | Highlights |
 |---------|------|------------|
+| v0.133 | 2026-01-14 | Fix: Solo crash (mutex deadlock), Windows keyboard duplication |
 | v0.132 | 2026-01-13 | macOS/REAPER keyboard hint, chat focus retention, UI polish |
 | v0.119 | 2026-01-12 | Windows: Keyboard focus fix (message hook) |
 | v0.117 | 2026-01-12 | Windows: Dummy EDIT control + IME support |
 | v0.108 | 2026-01-12 | UI: Transmit toggle visible |
 | v0.107 | 2026-01-11 | Fix: License dialog single-click |
 | v0.106 | 2026-01-11 | Default 256 kbps audio quality |
 | v0.105 | 2026-01-11 | Server browser with usernames |
-| v0.104 | 2026-01-11 | AU window 800x1200, setFrameSize |
 
 ---
 

src/build_number.h

@@ -1,2 +1,2 @@
 #pragma once
-#define JAMWIDE_BUILD_NUMBER 132
+#define JAMWIDE_BUILD_NUMBER 133

src/platform/gui_win32.cpp

@@ -67,7 +67,8 @@ class GuiContextWin32 : public GuiContext {
 
         const bool is_key_msg =
             msg->message == WM_KEYDOWN || msg->message == WM_KEYUP ||
-            msg->message == WM_SYSKEYDOWN || msg->message == WM_SYSKEYUP ||
+            msg->message == WM_SYSKEYDOWN || msg->message == WM_SYSKEYUP;
+        const bool is_char_msg =
             msg->message == WM_CHAR || msg->message == WM_SYSCHAR;
 
         if (is_key_msg) {
@@ -79,6 +80,12 @@ class GuiContextWin32 : public GuiContext {
             msg->message = WM_NULL;
             msg->wParam = 0;
             msg->lParam = 0;
+        } else if (is_char_msg) {
+            // Suppress original WM_CHAR messages - our TranslateMessage already
+            // generates them from the redirected WM_KEYDOWN above
+            msg->message = WM_NULL;
+            msg->wParam = 0;
+            msg->lParam = 0;
         }
 
         return CallNextHookEx(nullptr, code, wParam, lParam);

src/ui/ui_remote.cpp

@@ -28,6 +28,9 @@ void ui_render_remote_channels(jamwide::JamWidePlugin* plugin) {
         return;
     }
 
+    bool solo_changed = false;
+
+    {
     std::unique_lock<std::mutex> client_lock(plugin->client_mutex);
     NJClient* client = plugin->client.get();
     if (!client) {
@@ -144,7 +147,7 @@ void ui_render_remote_channels(jamwide::JamWidePlugin* plugin) {
                     cmd.set_solo = true;
                     cmd.solo = solo;
                     plugin->cmd_queue.try_push(std::move(cmd));
-                    ui_update_solo_state(plugin);
+                    solo_changed = true;
                 }
 
                 ImGui::SameLine();
@@ -162,5 +165,11 @@ void ui_render_remote_channels(jamwide::JamWidePlugin* plugin) {
         ImGui::PopID();
     }
 
+    } // Release client_mutex before updating solo state
+
+    if (solo_changed) {
+        ui_update_solo_state(plugin);
+    }
+
     ImGui::Unindent();
 }