[CI] Switch from pyright to ty (#212)

Author: jaywonchung

pyproject.toml

@@ -48,7 +48,7 @@ bso-server = ["fastapi[standard]", "sqlalchemy", "pydantic<2", "python-dotenv"]
 migration = ["alembic", "sqlalchemy", "pydantic<2", "python-dotenv"]
 prometheus = ["prometheus-client"]
 apple = ["zeus-apple-silicon"]
-lint = ["ruff", "pyright!=1.1.395", "pandas-stubs", "transformers"]
+lint = ["ruff", "ty", "transformers"]
 test = ["fastapi[standard]", "sqlalchemy", "pydantic<2", "pytest==7.3.2", "pytest-mock==3.10.0", "pytest-xdist==3.3.1", "anyio==3.7.1", "aiosqlite==0.20.0", "numpy<2"]
 docs = ["mkdocs-material[imaging]==9.5.19", "mkdocstrings[python]==0.25.0", "mkdocs-gen-files==0.5.0", "mkdocs-literate-nav==0.6.1", "mkdocs-section-index==0.3.9", "mkdocs-redirects==1.2.1", "urllib3<2"]
 # greenlet is for supporting apple mac silicon for sqlalchemy(https://docs.sqlalchemy.org/en/20/faq/installation.html)

scripts/lint.sh

@@ -9,4 +9,4 @@ else
 fi
 
 ruff check zeus
-pyright zeus
+ty check zeus

uv.lock

@@ -63,7 +63,7 @@ class is deterministic given the random seed, because the internal RNG is
         # Generate relevant data.
         train_df = pd.read_csv(summary_train) if isinstance(summary_train, str) else summary_train
         power_df = pd.read_csv(summary_power) if isinstance(summary_power, str) else summary_power
-        df = train_df.merge(power_df, how="inner")  # type: ignore
+        df = train_df.merge(power_df, how="inner")
         df["TTA"] = df.target_epoch * df.time_per_epoch
         df["ETA"] = df.TTA * df.average_power
         # 'energy_per_epoch' is used to compare different power limits with the same batch size
@@ -703,10 +703,10 @@ def compute_energy_and_time(num_epochs: int, profile_power: bool) -> tuple[float
                 # Also there are all runs 1, 2, ... included, but power info is actually
                 # completely duplicated across different runs in the DataFrame.
                 # Thus, taking the mean across the entire power_df gets us what we want.
-                energy_first_epoch = power_df.energy_per_epoch.mean().item()  # type: ignore
+                energy_first_epoch = power_df.energy_per_epoch.mean().item()
                 energy_from_second_epoch = path.energy_per_epoch.item() * (num_epochs - 1)
                 energy_consumption = energy_first_epoch + energy_from_second_epoch
-                time_first_epoch = power_df.time_per_epoch.mean().item()  # type: ignore
+                time_first_epoch = power_df.time_per_epoch.mean().item()
                 time_from_second_epoch = path.time_per_epoch.item() * (num_epochs - 1)
                 time_consumption = time_first_epoch + time_from_second_epoch
             # Just run num_epochs with the given power limit. Simple.

zeus/_legacy/simulate.py

@@ -13,7 +13,7 @@
 try:
     # `amdsmi` prints to stdout on import when libamd_smi.so is not found.
     with contextlib.redirect_stdout(None):
-        import amdsmi  # type: ignore
+        import amdsmi
 # must catch all exceptions, since ImportError is not the only exception that can be raised (ex. OSError on version mismatch).
 # Specific exceptions are handled when import and initialization are retested in `amdsmi_is_available`
 except Exception:
@@ -29,7 +29,7 @@ def __getattr__(self, name):
             """
             raise RuntimeError(f"amdsmi is not available and amdsmi.{name} shouldn't have been called. This is a bug.")
 
-    amdsmi = MockAMDSMI()
+    amdsmi = MockAMDSMI()  # ty: ignore[invalid-assignment]
 
 import zeus.device.gpu.common as gpu_common
 
@@ -42,7 +42,7 @@ def amdsmi_is_available() -> bool:
     try:
         # `amdsmi` prints to stdout on import when libamd_smi.so is not found.
         with contextlib.redirect_stdout(None):
-            import amdsmi  # type: ignore
+            import amdsmi
     except ImportError:
         logger.info("amdsmi is not available.")
         return False