remove the bias in the ffn module (#68)

nathanrchn · web-flow · commit ff7610d522a5 · 2024-05-08T15:31:28.000-07:00
diff --git a/Libraries/LLM/OpenELM.swift b/Libraries/LLM/OpenELM.swift
@@ -106,8 +106,8 @@ private class FeedForwardNetwork: Module, UnaryLayer {
         let intermediateDim = Int(
             makeDivisible(Float(ffnMultiplier) * Float(dim), divisor: args.ffnDimDivisor))
 
-        self.proj_1 = Linear(dim, 2 * intermediateDim)
-        self.proj_2 = Linear(intermediateDim, dim)
+        self.proj_1 = Linear(dim, 2 * intermediateDim, bias: false)
+        self.proj_2 = Linear(intermediateDim, dim, bias: false)
     }
 
     public func callAsFunction(_ x: MLXArray) -> MLXArray {

Original file line number	Diff line number	Diff line change
`@@ -106,8 +106,8 @@ private class FeedForwardNetwork: Module, UnaryLayer {`
`106`	`106`	`let intermediateDim = Int(`
`107`	`107`	`makeDivisible(Float(ffnMultiplier) * Float(dim), divisor: args.ffnDimDivisor))`
`108`	`108`
`109`		`- self.proj_1 = Linear(dim, 2 * intermediateDim)`
`110`		`- self.proj_2 = Linear(intermediateDim, dim)`
	`109`	`+ self.proj_1 = Linear(dim, 2 * intermediateDim, bias: false)`
	`110`	`+ self.proj_2 = Linear(intermediateDim, dim, bias: false)`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`public func callAsFunction(_ x: MLXArray) -> MLXArray {`