Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure it's worth merging this. The standalone benchmark is much improved but it's a very modest gain even for a very small model.
Adds a split logsumexp dispatch for when we get a really long vector.
Pre: 234 ms
Post: 138 ms
Inference speed improved slightly for small Gemmas (which have a large vocab):
Pre: 333.652 tokens-per-sec
Post: 334.837 tokens-per-sec