Compile error on OCaml 5.4.0

[brianwk]

I am unable to add the server-reason-react dependency to my project using OCaml 5.4.0.

ontext: _private
(cd _build/default && /Users/briankaplan/.cache/dune/toolchains/ocaml-compiler.5.4.0-f7fa36f38f7d3c2fb8acb68b4a13da4d/target/bin/ocamlc.opt -w -40 -g -bin-annot -bin-annot-occurrences -I packages/Js/lib/.js.objs/byte -I /Users/briankaplan/.cache/dune/toolchains/ocaml-compiler.5.4.0-f7fa36f38f7d3c2fb8acb68b4a13da4d/target/lib/ocaml/str -I /Users/briankaplan/.cache/dune/toolchains/ocaml-compiler.5.4.0-f7fa36f38f7d3c2fb8acb68b4a13da4d/target/lib/ocaml/unix -I /Users/briankaplan/dev-current/executor-full-stack/_build/_private/default/.pkg/lwt/target/lib/lwt -I /Users/briankaplan/dev-current/executor-full-stack/_build/_private/default/.pkg/quickjs/target/lib/quickjs -I /Users/briankaplan/dev-current/executor-full-stack/_build/_private/default/.pkg/uucp/target/lib/uucp -I /Users/briankaplan/dev-current/executor-full-stack/_build/_private/default/.pkg/zarith/target/lib/zarith -cmi-file packages/Js/lib/.js.objs/byte/js__Js_re.cmi -no-alias-deps -open Js__ -o packages/Js/lib/.js.objs/byte/js__Js_re.cmo -c -impl packages/Js/lib/Js_re.pp.ml)
File "packages/Js/lib/Js_re.ml", line 37, characters 57-84:
37 | let setLastIndex : t -> int -> unit = fun regex index -> Quickjs.RegExp.setLastIndex regex index
                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Unbound value Quickjs.RegExp.setLastIndex
(cd _build/default && /Users/briankaplan/.cache/dune/toolchains/ocaml-compiler.5.4.0-f7fa36f38f7d3c2fb8acb68b4a13da4d/target/bin/ocamlc.opt -w -40 -w -9 -g -bin-annot -bin-annot-occurrences -I packages/browser-ppx/.browser_ppx.objs/byte -I /Users/briankaplan/dev-current/executor-full-stack/_build/_private/default/.pkg/ppxlib/target/lib/ppxlib -I /Users/briankaplan/dev-current/executor-full-stack/_build/_private/default/.pkg/ppxlib/target/lib/ppxlib/ast -I /Users/briankaplan/dev-current/executor-full-stack/_build/_private/default/.pkg/ppxlib/target/lib/ppxlib/astlib -no-alias-deps -open Browser_ppx -o packages/browser-ppx/.browser_ppx.objs/byte/browser_ppx__Ppx.cmo -c -impl packages/browser-ppx/ppx.pp.ml)
File "packages/browser-ppx/ppx.ml", line 56, characters 4-12:
56 |   | Pexp_fun (arg_label, _arg_expression, fun_pattern, expression) ->
         ^^^^^^^^
Error: This variant pattern is expected to have type Ppxlib.expression_desc
       There is no constructor Pexp_fun within type Ppxlib.expression_desc
Hint:             Did you mean Pexp_for?
(cd _build/default && /Users/briankaplan/.cache/dune/toolchains/ocaml-compiler.5.4.0-f7fa36f38f7d3c2fb8acb68b4a13da4d/target/bin/ocamlc.opt -w -40 -w -9 -g -bin-annot -bin-annot-occurrences -I packages/melange.ppx/.melange_native_ppx.objs/byte -I /Users/briankaplan/.cache/dune/toolchains/ocaml-compiler.5.4.0-f7fa36f38f7d3c2fb8acb68b4a13da4d/target/lib/ocaml/str -I /Users/briankaplan/dev-current/executor-full-stack/_build/_private/default/.pkg/ppxlib/target/lib/ppxlib -I /Users/briankaplan/dev-current/executor-full-stack/_build/_private/default/.pkg/ppxlib/target/lib/ppxlib/ast -I /Users/briankaplan/dev-current/executor-full-stack/_build/_private/default/.pkg/ppxlib/target/lib/ppxlib/astlib -I /Users/briankaplan/dev-current/executor-full-stack/_build/_private/default/.pkg/quickjs/target/lib/quickjs -I packages/melange.ppx/base32/lib/.base32.objs/byte -I packages/melange.ppx/xxhash/.xxhash.objs/byte -no-alias-deps -open Melange_native_ppx -o packages/melange.ppx/.melange_native_ppx.objs/byte/melange_native_ppx__Ppx.cmo -c -impl packages/melange.ppx/ppx.pp.ml)
File "packages/melange.ppx/ppx.ml", line 540, characters 6-14:
540 |     | Pexp_fun (_, _, _, expr) -> go expr.pexp_desc
            ^^^^^^^^
Error: This variant pattern is expected to have type Ppxlib.expression_desc
       There is no constructor Pexp_fun within type Ppxlib.expression_desc
Hint:             Did you mean Pexp_for?
(cd _build/default && /Users/briankaplan/.cache/dune/toolchains/ocaml-compiler.5.4.0-f7fa36f38f7d3c2fb8acb68b4a13da4d/target/bin/ocamlopt.opt -w -40 -g -I packages/Js/lib/.js.objs/byte -I packages/Js/lib/.js.objs/native -I /Users/briankaplan/.cache/dune/toolchains/ocaml-compiler.5.4.0-f7fa36f38f7d3c2fb8acb68b4a13da4d/target/lib/ocaml/str -I /Users/briankaplan/.cache/dune/toolchains/ocaml-compiler.5.4.0-f7fa36f38f7d3c2fb8acb68b4a13da4d/target/lib/ocaml/unix -I /Users/briankaplan/dev-current/executor-full-stack/_build/_private/default/.pkg/lwt/target/lib/lwt -I /Users/briankaplan/dev-current/executor-full-stack/_build/_private/default/.pkg/quickjs/target/lib/quickjs -I /Users/briankaplan/dev-current/executor-full-stack/_build/_private/default/.pkg/uucp/target/lib/uucp -I /Users/briankaplan/dev-current/executor-full-stack/_build/_private/default/.pkg/zarith/target/lib/zarith -cmi-file packages/Js/lib/.js.objs/byte/js__Js_re.cmi -no-alias-deps -open Js__ -o packages/Js/lib/.js.objs/native/js__Js_re.cmx -c -impl packages/Js/lib/Js_re.pp.ml)
File "packages/Js/lib/Js_re.ml", line 37, characters 57-84:
37 | let setLastIndex : t -> int -> unit = fun regex index -> Quickjs.RegExp.setLastIndex regex index
                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Unbound value Quickjs.RegExp.setLastIndex
-> required by _build/_private/default/.pkg/server-reason-react/target
-> required by library "executor.tilia" in _build/default/common/src/Tilia
-> required by library "executor.ui" in _build/default/ui/src
Had 1 error, waiting for filesystem changes...

I have the repository pinned in my dune file and that's how I'm installing it. This is my dune-project file: https://github.com/Software-Deployed/executor/blob/ocaml/dune-project -- I'm using OCaml 5.4.0 and Melange 6.0.1-54. I'm using 5.4.0 because it's the latest stable release of OCaml and I am under the impression it's necessary to run Melange 6.

Once I remove the server-reason-react dependency from Dune and I run dune pkg lock the dune build command succeeds.

I was thinking to try to list the subpackages from the repository individually instead of installing all of server-reason-react. Since this error is coming from the browser_ppx module.

I tried many different things to get it to work. I pinned using opam pin command. Also in my dune-project you will see reason-react 0.17.0 and reason-react-ppx 0.17.0. I pinned these using opam pin --with-version since I believe 0.17.0 isn't released on opam yet.

[davesnx]

I fixed the quickjs issue here: #333
and I'm waiting for ocaml/opam-repository#29132 to be merged so I can fix the melange 6 version as well.

[brianwk]

@davesnx I was using reason-react repository from Git since 0.17.0 isn't on opam yet. Or at least I thought I was...

For some reason I can't install quickjs 0.4.1.

❯ opam pin server-reason-react git+https://github.com/ml-in-barcelona/server-reason-react#main
[NOTE] Package server-reason-react is already pinned to
       git+https://github.com/ml-in-barcelona/server-reason-react#main
       (version 0.4.0).
[server-reason-react.0.4.0] synchronised (no changes)
server-reason-react is now pinned to git+https://github.com/ml-in-barcelona/server-reason-react#main (version 0.4.0)

[ERROR] Package conflict!
  * Missing dependency:
    - server-reason-react → quickjs >= 0.4.1
    no matching version

[NOTE] Pinning command successful, but your installed packages
       may be out of sync.

also I tried:

❯ opam pin add quickjs=0.4.1 --dev-repo
[NOTE] Package quickjs is currently pinned to
       git+https://github.com/ml-in-barcelona/quickjs.ml
       (version 0.4.1).
[quickjs.0.4.1] synchronised (git+https://github.com/ml-in-barcelona/quickjs.ml.git)
quickjs is now pinned to git+https://github.com/ml-in-barcelona/quickjs.ml.git (version 0.4.1)

The following actions will be performed:
=== recompile 1 package
  ↻ executor dev (pinned)   [uses quickjs]
=== install 1 package
  ∗ quickjs  0.4.1 (pinned)

Proceed with ↻ 1 recompilation and ∗ 1 installation? [Y/n] y

<><> Processing actions <><><><><><><><><><><><><><><><><><>  🐫
⬇ retrieved executor.dev  (no changes)
⬇ retrieved quickjs.0.4.1  (git+https://github.com/ml-in-barcelona/quickjs.ml.git)
[ERROR] The compilation of quickjs.0.4.1 failed at "dune build
        -p quickjs -j 11 @install".

#=== ERROR while compiling quickjs.0.4.1 ======================#
# context     2.5.0 | macos/arm64 | ocaml-base-compiler.5.4.0 | pinned(git+https://github.com/ml-in-barcelona/quickjs.ml.git#7619f200a393ea8af9977a248e2c7c90ee0c97b3)
# path        ~/dev-current/executor-full-stack/_opam/.opam-switch/build/quickjs.0.4.1
# command     ~/.opam/opam-init/hooks/sandbox.sh build dune build -p quickjs -j 11 @install
# exit-code   1
# env-file    ~/.opam/log/quickjs-82094-ba6ecc.env
# output-file ~/.opam/log/quickjs-82094-ba6ecc.out
### output ###
# [...]
# (cd _build/default && /Users/briankaplan/dev-current/executor-full-stack/_opam/bin/ocamlc.opt -w -40 -g -bin-annot -bin-annot-occurrences -I lib/.quickjs.objs/byte -I /Users/briankaplan/dev-current/executor-full-stack/_opam/lib/ctypes -I /Users/briankaplan/dev-current/executor-full-stack/_opam/lib/integers -I .bindings.objs/byte -I c/.quickjs_c.objs/byte -cmi-file lib/.quickjs.objs/byte/quick[...]
# File "lib/String.ml", line 642, characters 40-56:
# 642 |               RegExp.set_last_index re (RegExp.lastIndex re + 1)
#                                               ^^^^^^^^^^^^^^^^
# Error: Unbound value RegExp.lastIndex
# Hint:   Did you mean RegExp.last_index?
# (cd _build/default && /Users/briankaplan/dev-current/executor-full-stack/_opam/bin/ocamlopt.opt -w -40 -g -I lib/.quickjs.objs/byte -I lib/.quickjs.objs/native -I /Users/briankaplan/dev-current/executor-full-stack/_opam/lib/ctypes -I /Users/briankaplan/dev-current/executor-full-stack/_opam/lib/integers -I .bindings.objs/byte -I .bindings.objs/native -I c/.quickjs_c.objs/byte -I c/.quickjs_c.o[...]
# File "lib/String.ml", line 642, characters 40-56:
# 642 |               RegExp.set_last_index re (RegExp.lastIndex re + 1)
#                                               ^^^^^^^^^^^^^^^^
# Error: Unbound value RegExp.lastIndex
# Hint:   Did you mean RegExp.last_index?



<><> Error report <><><><><><><><><><><><><><><><><><><><><>  🐫
┌─ The following actions failed
│ λ build quickjs 0.4.1
└─
╶─ No changes have been performed
[NOTE] Pinning command successful, but your installed packages
       may be out of sync.

dune-project: https://github.com/Software-Deployed/executor/blob/ocaml/dune-project

[davesnx]

opam install quickjs.0.4.1 -y 
opam pin server-reason-react.dev ... 

Should work

[brianwk]

Excerpt:

# (cd _build/default && /Users/briankaplan/dev-current/executor-full-stack/_opam/bin/ocamlopt.opt -w -40 -g -I lib/.quickjs.objs/byte -I lib/.quickjs.objs/native -I /Users/briankaplan/dev-current/executor-full-stack/_opam/lib/ctypes -I /Users/briankaplan/dev-current/executor-full-stack/_opam/lib/integers -I .bindings.objs/byte -I .bindings.objs/native -I c/.quickjs_c.objs/byte -I c/.quickjs_c.o[...]
# File "lib/String.ml", line 642, characters 40-56:
# 642 |               RegExp.set_last_index re (RegExp.lastIndex re + 1)
#                                               ^^^^^^^^^^^^^^^^
# Error: Unbound value RegExp.lastIndex
# Hint:   Did you mean RegExp.last_index?

Full output:

❯ opam install quickjs.0.4.1 -y
opam pin server-reason-react.dev

<><> Synchronising pinned packages ><><><><><><><><><>  🐫
[quickjs.0.4.1] synchronised (git+https://github.com/ml-in-barcelona/quickjs.ml.git)

The following actions will be performed:
=== recompile 1 package
  ↻ executor dev (pinned)   [uses quickjs]
=== install 1 package
  ∗ quickjs  0.4.1 (pinned)

<><> Processing actions <><><><><><><><><><><><><><><>  🐫
⬇ retrieved executor.dev  (git+file:///Users/briankaplan/dev-current/executor-full-stack#ocaml)
⬇ retrieved quickjs.0.4.1  (git+https://github.com/ml-in-barcelona/quickjs.ml.git)
[ERROR] The compilation of quickjs.0.4.1 failed at "dune
        build -p quickjs -j 11 @install".

#=== ERROR while compiling quickjs.0.4.1 ================#
# context     2.5.0 | macos/arm64 | ocaml-base-compiler.5.4.0 | pinned(git+https://github.com/ml-in-barcelona/quickjs.ml.git#7619f200a393ea8af9977a248e2c7c90ee0c97b3)
# path        ~/dev-current/executor-full-stack/_opam/.opam-switch/build/quickjs.0.4.1
# command     ~/.opam/opam-init/hooks/sandbox.sh build dune build -p quickjs -j 11 @install
# exit-code   1
# env-file    ~/.opam/log/quickjs-52847-6d42ba.env
# output-file ~/.opam/log/quickjs-52847-6d42ba.out
### output ###
# [...]
# (cd _build/default && /Users/briankaplan/dev-current/executor-full-stack/_opam/bin/ocamlc.opt -w -40 -g -bin-annot -bin-annot-occurrences -I lib/.quickjs.objs/byte -I /Users/briankaplan/dev-current/executor-full-stack/_opam/lib/ctypes -I /Users/briankaplan/dev-current/executor-full-stack/_opam/lib/integers -I .bindings.objs/byte -I c/.quickjs_c.objs/byte -cmi-file lib/.quickjs.objs/byte/quick[...]
# File "lib/String.ml", line 642, characters 40-56:
# 642 |               RegExp.set_last_index re (RegExp.lastIndex re + 1)
#                                               ^^^^^^^^^^^^^^^^
# Error: Unbound value RegExp.lastIndex
# Hint:   Did you mean RegExp.last_index?
# (cd _build/default && /Users/briankaplan/dev-current/executor-full-stack/_opam/bin/ocamlopt.opt -w -40 -g -I lib/.quickjs.objs/byte -I lib/.quickjs.objs/native -I /Users/briankaplan/dev-current/executor-full-stack/_opam/lib/ctypes -I /Users/briankaplan/dev-current/executor-full-stack/_opam/lib/integers -I .bindings.objs/byte -I .bindings.objs/native -I c/.quickjs_c.objs/byte -I c/.quickjs_c.o[...]
# File "lib/String.ml", line 642, characters 40-56:
# 642 |               RegExp.set_last_index re (RegExp.lastIndex re + 1)
#                                               ^^^^^^^^^^^^^^^^
# Error: Unbound value RegExp.lastIndex
# Hint:   Did you mean RegExp.last_index?



<><> Error report <><><><><><><><><><><><><><><><><><>  🐫
┌─ The following actions failed
│ λ build quickjs 0.4.1
└─
╶─ No changes have been performed
[ERROR] Could not retrieve
        /Users/briankaplan/dev-current/executor-full-stack/server-reason-react.dev

❯ opam switch
#  switch
          compiler
          description
→  /Users/briankaplan/dev-current/executor-full-stack
          ocaml-base-compiler.5.4.0,ocaml-options-vanilla.1
          ocaml-base-compiler = 5.2.0
   /Users/briankaplan/dev-current/server-reason-react
          ocaml-base-compiler.5.2.0,ocaml-options-vanilla.1
          ocaml-base-compiler = 5.2.0
   /Users/briankaplan/dev/infra/quickfast
          ocaml-base-compiler.5.1.0,ocaml-options-vanilla.1
          ocaml-base-compiler = 5.1.0
   5.4.0
          ocaml-base-compiler.5.4.0,ocaml-options-vanilla.1
          ocaml-base-compiler = 5.4.0
   default
          ocaml-base-compiler.5.2.1,ocaml-options-vanilla.1
          ocaml >= 4.05.0

[NOTE] Current switch has been selected based on the
       current directory.
       The current global system switch is 5.4.0.

[brianwk]

This patch solve the quickjs issue:

diff --git a/lib/String.ml b/lib/String.ml
index a16c844..010f5bd 100644
--- a/lib/String.ml
+++ b/lib/String.ml
@@ -639,7 +639,7 @@ module Prototype = struct
           else begin
             matches := caps.(0) :: !matches;
             if caps.(0) = "" then
-              RegExp.set_last_index re (RegExp.lastIndex re + 1)
+              RegExp.set_last_index re (RegExp.last_index re + 1)
           end
         done;
         Array.of_list (List.rev !matches)
@@ -672,7 +672,7 @@ module Prototype = struct
               }
               :: !matches;
             if caps.(0) = "" then
-              RegExp.set_last_index re (RegExp.lastIndex re + 1)
+              RegExp.set_last_index re (RegExp.last_index re + 1)
           end
         done;
         List.rev !matches

However, after this there are several PPX errors that are a bit difficult for me to address due to my lack of experience. I took a stab at it, but quickly hit my knowledge ceiling. :)

❯ opam pin
executor.dev               (uninstalled)  git  git+file:///Users/briankaplan/dev-current/executor-full-stack#ocaml
          (at 9ae6956de189323b7691685f87db0b6e7e087de2)
opam-check-npm-deps.dev    (uninstalled)  git  git+https://github.com/ahrefs/opam-check-npm-deps.git#4.1.0
          (at ebecec84c6dddf91d7a40f67ca8bb280529330c3)
quickjs.0.4.1                             git  git+file:///Users/briankaplan/dev-current/quickjs.ml#main
          (at 850fb1e4783c492667b46b059f65547375400a92)
reason-react.0.16.0                       git  git+https://github.com/reasonml/reason-react
          (at 6c7bb86d9c86433048fa94d71d163e144250f1d8)
reason-react-ppx.0.16.0                   git  git+https://github.com/reasonml/reason-react
          (at 6c7bb86d9c86433048fa94d71d163e144250f1d8)
server-reason-react.0.4.0  (uninstalled)  git  git+file:///Users/briankaplan/dev-current/server-reason-react#main
          (at a7ddbd5a1fd8bdff9874bd68a8fd0a785855a4ad)

❯ opam pin server-reason-react ../server-reason-react
[NOTE] Package server-reason-react is already pinned to
       git+file:///Users/briankaplan/dev-current/server-reason-react#main (version 0.4.0).
[server-reason-react.0.4.0] synchronised (git+file:///Users/briankaplan/dev-current/server-reason-react#main)
server-reason-react is now pinned to git+file:///Users/briankaplan/dev-current/server-reason-react#main (version 0.4.0)

The following actions will be performed:
=== install 1 package
  ∗ server-reason-react 0.4.0 (pinned)

Proceed with ∗ 1 installation? [Y/n] y

<><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><>  🐫
⬇ retrieved server-reason-react.0.4.0  (no changes)
[ERROR] The compilation of server-reason-react.0.4.0 failed at "dune build -p server-reason-react -j 11 @install".

#=== ERROR while compiling server-reason-react.0.4.0 ==========================#
# context     2.5.0 | macos/arm64 | ocaml-base-compiler.5.4.0 | pinned(git+file:///Users/briankaplan/dev-current/server-reason-react#main#bc8177c4f234a9d4d57dfe03b71fe45a2b6a09dd)
# path        ~/dev-current/executor-full-stack/_opam/.opam-switch/build/server-reason-react.0.4.0
# command     ~/.opam/opam-init/hooks/sandbox.sh build dune build -p server-reason-react -j 11 @install
# exit-code   1
# env-file    ~/.opam/log/server-reason-react-90613-2b683b.env
# output-file ~/.opam/log/server-reason-react-90613-2b683b.out
### output ###
# [...]
# 56 |   | Pexp_fun (arg_label, _arg_expression, fun_pattern, expression) ->
#          ^^^^^^^^
# Error: This variant pattern is expected to have type Ppxlib.expression_desc
#        There is no constructor Pexp_fun within type Ppxlib.expression_desc
# Hint:             Did you mean Pexp_for?
# (cd _build/default && /Users/briankaplan/dev-current/executor-full-stack/_opam/bin/ocamlc.opt -w -40 -w -9 -g -bin-annot -bin-annot-occurrences -I packages/melange.ppx/.melange_native_ppx.objs/byte -I /Users/briankaplan/dev-current/executor-full-stack/_opam/lib/ocaml/str -I /Users/briankaplan/dev-current/executor-full-stack/_opam/lib/ppxlib -I /Users/briankaplan/dev-current/executor-full-stac[...]
# File "packages/melange.ppx/ppx.ml", line 540, characters 6-14:
# 540 |     | Pexp_fun (_, _, _, expr) -> go expr.pexp_desc
#             ^^^^^^^^
# Error: This variant pattern is expected to have type Ppxlib.expression_desc
#        There is no constructor Pexp_fun within type Ppxlib.expression_desc
# Hint:             Did you mean Pexp_for?



<><> Error report <><><><><><><><><><><><><><><><><><><><><><><><><><><><><>  🐫
┌─ The following actions failed
│ λ build server-reason-react 0.4.0
└─
╶─ No changes have been performed
[NOTE] Pinning command successful, but your installed packages may be out of sync.

[davesnx]

I fixed the build on quickjs https://github.com/ml-in-barcelona/quickjs.ml