Merge pull request #6 from nodes-ios/delegateTests

Added tests for the KeyboardHelper

Author: chriscombs

KeyboardHelper/Classes/KeyboardHelper.swift

@@ -53,12 +53,12 @@ public class KeyboardHelper {
         delegate = nil
     }
 
-    private func keyboardWillAppear(note: NSNotification) {
+    dynamic private func keyboardWillAppear(note: NSNotification) {
         let info = KeyboardAppearanceInfo(notification: note)
         self.delegate?.keyboardWillAppear(info)
     }
 
-    private func keyboardWillDisappear(note: NSNotification) {
+    dynamic private func keyboardWillDisappear(note: NSNotification) {
         let info = KeyboardAppearanceInfo(notification: note)
         self.delegate?.keyboardWillDisappear(info)
     }

KeyboardHelperTests/Tests/KeyboardAppearanceInfoTests.swift

@@ -12,6 +12,7 @@ import KeyboardHelper
 class KeyboardAppearanceInfoTests: XCTestCase {
 
     var apperanceInfo: KeyboardAppearanceInfo!
+    var defaultsAppearanceInfo : KeyboardAppearanceInfo!
 
     override func setUp() {
         super.setUp()
@@ -24,41 +25,55 @@ class KeyboardAppearanceInfoTests: XCTestCase {
             UIKeyboardAnimationCurveUserInfoKey: UIViewAnimationCurve.EaseOut.rawValue,
         ]
 
+        var defaultParsingUserInfo: [String: AnyObject] = [
+            UIKeyboardFrameBeginUserInfoKey: "bla",
+            UIKeyboardFrameEndUserInfoKey: "bla",
+            UIKeyboardAnimationDurationUserInfoKey: NSValue(CGRect: CGRect(x: 100, y: 100, width: 100, height: 100)),
+            UIKeyboardAnimationCurveUserInfoKey: "bla",
+        ]
+        
         if #available(iOS 9.0, *) {
             testUserInfo[UIKeyboardIsLocalUserInfoKey] = false
+            defaultParsingUserInfo[UIKeyboardIsLocalUserInfoKey] = "this shouldn't work"
         } else {
             print("UIKeyboardIsLocalUserInfoKey is not available before iOS9.")
         }
 
         // Fake the notification
         let note = NSNotification(name: UIKeyboardWillShowNotification, object: nil, userInfo: testUserInfo)
         apperanceInfo = KeyboardAppearanceInfo(notification: note)
+        defaultsAppearanceInfo = KeyboardAppearanceInfo(notification: NSNotification(name: UIKeyboardWillShowNotification, object: nil, userInfo: defaultParsingUserInfo))
     }
 
     func testBeginFrame() {
         XCTAssertEqual(apperanceInfo.beginFrame, CGRect(x: 100, y: 100, width: 100, height: 100),
             "Parsing beginFrame from keyboard appearance info failed.")
+        XCTAssertEqual(defaultsAppearanceInfo.beginFrame, CGRectZero)
     }
 
     func testEndFrame() {
         XCTAssertEqual(apperanceInfo.endFrame, CGRect(x: 200, y: 200, width: 200, height: 200),
             "Parsing endFrame from keyboard appearance info failed.")
+        XCTAssertEqual(defaultsAppearanceInfo.endFrame, CGRectZero)
     }
 
     @available(iOS 9.0, *)
     func testBelongsToCurrentApp() {
         XCTAssertEqual(apperanceInfo.belongsToCurrentApp, false,
             "Parsing belongsToCurrentApp from keyboard appearance info failed.")
+        XCTAssertEqual(defaultsAppearanceInfo.belongsToCurrentApp, true)
     }
 
     func testAnimationDuration() {
         XCTAssertEqual(apperanceInfo.animationDuration, Double(3),
             "Parsing animationDuration from keyboard appearance info failed.")
+        XCTAssertEqual(defaultsAppearanceInfo.animationDuration, 0.25)
     }
 
     func testAnimationCurve() {
         XCTAssertEqual(apperanceInfo.animationCurve, UIViewAnimationCurve(rawValue: 2),
             "Parsing animationCurve from keyboard appearance info failed.")
+        XCTAssertEqual(defaultsAppearanceInfo.animationCurve, UIViewAnimationCurve.EaseInOut)
     }
 
     func testAnimateAlong() {

KeyboardHelperTests/Tests/KeyboardHelperTests.swift

@@ -9,6 +9,118 @@
 import XCTest
 @testable import KeyboardHelper
 
+class ShowSpyDelegate : KeyboardNotificationDelegate {
+    var kai : KeyboardAppearanceInfo?
+    
+    var expectation : XCTestExpectation?
+    
+    func keyboardWillDisappear(info: KeyboardAppearanceInfo) {
+        
+    }
+    
+    func keyboardWillAppear(info: KeyboardAppearanceInfo) {
+        guard let expectation = expectation else {
+            XCTFail("ShowSpyDelegate was not setup correctly. Missing XCTExpectation reference")
+            return
+        }
+        
+        kai = info
+        expectation.fulfill()
+    }
+}
+
+class HideSpyDelegate : KeyboardNotificationDelegate {
+    var kai : KeyboardAppearanceInfo?
+    
+    var expectation : XCTestExpectation?
+    
+    func keyboardWillDisappear(info: KeyboardAppearanceInfo) {
+        guard let expectation = expectation else {
+            XCTFail("HideSpyDelegate was not setup correctly. Missing XCTExpectation reference")
+            return
+        }
+        
+        kai = info
+        expectation.fulfill()
+    }
+    
+    func keyboardWillAppear(info: KeyboardAppearanceInfo) {
+        
+    }
+}
+
 class KeyboardHelperTests: XCTestCase {
 
+    func testKeyboardShowDelegateMethodIsCalledAsync() {
+        let spyDelegate = ShowSpyDelegate()
+        let kh = KeyboardHelper(delegate: spyDelegate)
+        
+        let expectation = expectationWithDescription("KeyboardHelper calls the delegate as the result of receiving the show notification")
+        spyDelegate.expectation = expectation
+        
+//        NSNotificationCenter.defaultCenter().postNotificationName(UIKeyboardWillShowNotification, object: kh)
+        let notification : NSNotification
+        if #available(iOS 9.0, *) {
+            notification = NSNotification(name: UIKeyboardWillShowNotification, object: kh, userInfo:[
+                UIKeyboardAnimationCurveUserInfoKey : NSNumber(int: 7),
+                UIKeyboardAnimationDurationUserInfoKey : NSNumber(double: 0.25),
+                UIKeyboardFrameBeginUserInfoKey : NSValue(CGRect: CGRect(x: 0, y: 667, width: 375, height: 0)),
+                UIKeyboardFrameEndUserInfoKey : NSValue(CGRect: CGRect(x: 0, y: 409, width: 375, height: 258)),
+                UIKeyboardIsLocalUserInfoKey : NSNumber(bool: true)
+                ])
+        } else {
+            notification = NSNotification(name: UIKeyboardWillShowNotification, object: nil, userInfo:[
+                UIKeyboardAnimationCurveUserInfoKey : NSNumber(int: 7),
+                UIKeyboardAnimationDurationUserInfoKey : NSNumber(double: 0.25),
+                UIKeyboardFrameBeginUserInfoKey : NSValue(CGRect: CGRect(x: 0, y: 667, width: 375, height: 0)),
+                UIKeyboardFrameEndUserInfoKey : NSValue(CGRect: CGRect(x: 0, y: 409, width: 375, height: 258))
+                ])
+        }
+        
+        NSNotificationCenter.defaultCenter().postNotification(notification)
+        
+        
+        
+        waitForExpectationsWithTimeout(1) { error in
+            if let error = error {
+                XCTFail("waitForExpectationsWithTimeout errored: \(error)")
+            }
+            
+            guard let result = spyDelegate.kai else {
+                XCTFail("Expected delegate to be called")
+                return
+            }
+            XCTAssertNotNil(result)
+            XCTAssertEqual(result.animationCurve, UIViewAnimationCurve(rawValue: 7))
+            XCTAssertEqual(result.animationDuration, 0.25)
+            XCTAssertEqual(result.beginFrame, CGRect(x: 0, y: 667, width: 375, height: 0))
+            XCTAssertEqual(result.endFrame, CGRect(x: 0, y: 409, width: 375, height: 258))
+            XCTAssertEqual(result.belongsToCurrentApp, true)
+
+        }
+    }
+    
+    func testKeyboardHideDelegateMethodIsCalledAsync() {
+        let spyDelegate = HideSpyDelegate()
+        let kh = KeyboardHelper(delegate: spyDelegate)
+        
+        let expectation = expectationWithDescription("KeyboardHelper calls the delegate as the result of receiving the hide notification")
+        spyDelegate.expectation = expectation
+        
+        NSNotificationCenter.defaultCenter().postNotificationName(UIKeyboardWillHideNotification, object: kh)
+        
+        
+        waitForExpectationsWithTimeout(1) { error in
+            if let error = error {
+                XCTFail("waitForExpectationsWithTimeout errored: \(error)")
+            }
+            
+            guard let result = spyDelegate.kai else {
+                XCTFail("Expected delegate to be called")
+                return
+            }
+            
+            XCTAssertNotNil(result)
+        }
+    }
 }