Skip to content

Commit c6fad20

Browse files
authored
fix: Use monstarlab_lints : : (#133)
* fix: Use monstarlab_lints : : * fix: Configure lints dependency correctly * nit: FIx warnings
1 parent 615558a commit c6fad20

File tree

12 files changed

+24
-89
lines changed

12 files changed

+24
-89
lines changed

analysis_options.yaml

Lines changed: 2 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -5,78 +5,14 @@
55
# IDEs (https://dart.dev/tools#ides-and-editors). The analyzer can also be
66
# invoked from the command line by running `flutter analyze`.
77

8-
# The following line activates a set of recommended lints for Flutter apps,
9-
# packages, and plugins designed to encourage good coding practices.
10-
include: package:flutter_lints/flutter.yaml
11-
12-
linter:
13-
rules:
14-
# https://github.com/dart-lang/linter/blob/master/example/all.yaml
15-
- always_declare_return_types
16-
- always_require_non_null_named_parameters
17-
- annotate_overrides
18-
- avoid_init_to_null
19-
- avoid_null_checks_in_equality_operators
20-
- avoid_print
21-
- avoid_relative_lib_imports
22-
- avoid_return_types_on_setters
23-
- avoid_shadowing_type_parameters
24-
- avoid_single_cascade_in_expression_statements
25-
- avoid_types_as_parameter_names
26-
- avoid_unnecessary_containers
27-
- avoid_unused_constructor_parameters
28-
- avoid_void_async
29-
- await_only_futures
30-
- camel_case_extensions
31-
- curly_braces_in_flow_control_structures
32-
- empty_catches
33-
- empty_constructor_bodies
34-
- library_names
35-
- library_prefixes
36-
- no_duplicate_case_values
37-
- null_closures
38-
- omit_local_variable_types
39-
- prefer_adjacent_string_concatenation
40-
- prefer_collection_literals
41-
- prefer_conditional_assignment
42-
- prefer_contains
43-
- prefer_final_fields
44-
- prefer_for_elements_to_map_fromIterable
45-
- prefer_generic_function_type_aliases
46-
- prefer_if_null_operators
47-
- prefer_inlined_adds
48-
- prefer_is_empty
49-
- prefer_is_not_empty
50-
- prefer_iterable_whereType
51-
- prefer_single_quotes
52-
- prefer_spread_collections
53-
- recursive_getters
54-
- slash_for_doc_comments
55-
- sort_child_properties_last
56-
- type_init_formals
57-
- unawaited_futures
58-
- unnecessary_brace_in_string_interps
59-
- unnecessary_const
60-
- unnecessary_getters_setters
61-
- unnecessary_new
62-
- unnecessary_null_in_if_null_operators
63-
- unnecessary_this
64-
- unrelated_type_equality_checks
65-
- unsafe_html
66-
- use_colored_box
67-
- use_decorated_box
68-
- use_full_hex_values_for_flutter_colors
69-
- use_function_type_syntax_for_parameters
70-
- use_rethrow_when_possible
71-
- valid_regexps
8+
include: package:monstarlab_lints/analysis_options.yaml
729

7310
# Additional information about this file can be found at
7411
# https://dart.dev/guides/language/analysis-options
7512

76-
7713
analyzer:
7814
errors:
79-
# Ignore invalid annotations since freezed annotation and json serializable required it
15+
# Ignore invalid annotations since freezed annotation and json serializable required it
8016
invalid_annotation_target: ignore
8117
exclude:
8218
# ignore DI

lib/data/interceptor/auth_interceptor.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ class AuthInterceptor extends InterceptorsWrapper {
116116
headers: {
117117
'Authorization': 'Bearer ${authPreferences.refreshToken}',
118118
MetaInterceptor.nMetaHeaderKey:
119-
requestOptions.headers[MetaInterceptor.nMetaHeaderKey]
119+
requestOptions.headers[MetaInterceptor.nMetaHeaderKey],
120120
},
121121
);
122122

lib/data/services/response_objects/tokens_response.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class TokensResponse with _$TokensResponse {
2222
'accessToken': 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJwY2MiO',
2323
'refreshToken': 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJwY2Mi',
2424
'tokenType': 'Bearer',
25-
'expiresIn': 2592000
25+
'expiresIn': 2592000,
2626
});
2727
}
2828

lib/injection/dependencies.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1+
import 'package:flutter_template/injection/injector.dart';
12
import 'package:flutter_template/presentation/app_flavor.dart';
23
import 'package:flutter_template/presentation/routes/router.dart';
34

4-
import 'injector.dart';
5-
65
class DependencyManager {
76
static Future<void> inject(AppFlavor flavor) async {
87
injector.registerLazySingleton<AppFlavor>(() => flavor);

lib/main_common.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import 'package:flutter/material.dart';
22
import 'package:flutter_template/injection/dependencies.dart';
33
import 'package:flutter_template/presentation/app.dart';
4-
5-
import 'presentation/app_flavor.dart';
4+
import 'package:flutter_template/presentation/app_flavor.dart';
65

76
// ignore: avoid_void_async
87
void mainCommon(AppFlavor flavor) async {

lib/main_development.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import 'presentation/app_flavor.dart';
2-
import 'main_common.dart';
1+
import 'package:flutter_template/main_common.dart';
2+
import 'package:flutter_template/presentation/app_flavor.dart';
33

44
void main() async {
55
const config = AppFlavor.development;

lib/main_production.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import 'presentation/app_flavor.dart';
2-
import 'main_common.dart';
1+
import 'package:flutter_template/main_common.dart';
2+
import 'package:flutter_template/presentation/app_flavor.dart';
33

44
void main() async {
55
const config = AppFlavor.production;

lib/main_staging.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import 'presentation/app_flavor.dart';
2-
import 'main_common.dart';
1+
import 'package:flutter_template/main_common.dart';
2+
import 'package:flutter_template/presentation/app_flavor.dart';
33

44
void main() async {
55
const config = AppFlavor.staging;

lib/presentation/app.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import 'package:auto_route/auto_route.dart';
22
import 'package:flutter/material.dart';
33
import 'package:flutter_template/injection/injector.dart';
4+
import 'package:flutter_template/nstack/nstack.dart';
45
import 'package:flutter_template/presentation/resources/resources.dart';
56
import 'package:flutter_template/presentation/routes/router.dart';
6-
import '../../nstack/nstack.dart';
77

88
class App extends StatelessWidget {
99
const App({Key? key}) : super(key: key);

lib/presentation/feature/profile/profile_page.dart

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,15 @@ class _ProfilePageState extends State<ProfilePage> {
4141
child: Column(
4242
children: [
4343
BlocBuilder<ProfileCubit, ProfileState>(
44-
bloc: _profilePresenter,
45-
builder: (context, state) {
46-
if (state.isLoading) {
47-
return const CircularProgressIndicator();
48-
} else {
49-
return Text('Hi ${state.name}!');
50-
}
51-
})
44+
bloc: _profilePresenter,
45+
builder: (context, state) {
46+
if (state.isLoading) {
47+
return const CircularProgressIndicator();
48+
} else {
49+
return Text('Hi ${state.name}!');
50+
}
51+
},
52+
),
5253
],
5354
),
5455
),

0 commit comments

Comments
 (0)