Update universal-build

JanKalkan · JanKalkan · commit 4c20713b4f80 · 2020-12-14T11:42:38.000+01:00
diff --git a/.github/CODE_OF_CONDUCT.md b/.github/CODE_OF_CONDUCT.md
@@ -14,22 +14,22 @@ appearance, race, religion, or sexual identity and orientation.
 Examples of behavior that contributes to creating a positive environment
 include:
 
-- Using welcoming and inclusive language
-- Being respectful of differing viewpoints and experiences
-- Gracefully accepting constructive criticism
-- Focusing on what is best for the community
-- Showing empathy towards other community members
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
 
 Examples of unacceptable behavior by participants include:
 
-- The use of sexualized language or imagery and unwelcome sexual attention or
-  advances
-- Trolling, insulting/derogatory comments, and personal or political attacks
-- Public or private harassment
-- Publishing others' private information, such as a physical or electronic
-  address, without explicit permission
-- Other conduct which could reasonably be considered inappropriate in a
-  professional setting
+* The use of sexualized language or imagery and unwelcome sexual attention or
+ advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic
+ address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+ professional setting
 
 ## Our Responsibilities
 
@@ -73,4 +73,4 @@ available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.ht
 [homepage]: https://www.contributor-covenant.org
 
 For answers to common questions about this code of conduct, see
-https://www.contributor-covenant.org/faq
+https://www.contributor-covenant.org/faq
diff --git a/.github/ISSUE_TEMPLATE/01_bug-report.md b/.github/ISSUE_TEMPLATE/01_bug-report.md
@@ -32,9 +32,8 @@ Before opening a new issue, please make sure that we do not have any duplicates
 
 **Technical details:**
 
-- Library version <!-- run `import lazycluster; print(lazycluster.__version__)` -->: 
-- Python version<!-- run `import sys; print(sys.version)` on your machine -->:  
-- SSH version <!-- run `ssh -V` on your machine -->: 
+- Host Machine OS (Windows/Linux/Mac):
+- Browser (Chrome/Firefox/Safari):
 
 **Possible Fix:**
 
diff --git a/.github/ISSUE_TEMPLATE/03_documentation.md b/.github/ISSUE_TEMPLATE/03_documentation.md
@@ -1,5 +1,5 @@
 ---
-name: "\U0001F4DA Documentation"
+name: "\U0001F4DD Documentation"
 about: Is there a mistake in the docs, is anything unclear or do you have a suggestion?
 title: ''
 labels: documentation
@@ -13,4 +13,4 @@ assignees: ''
 
 **Which page or section is this issue related to?**
 
-<!-- Please include the URL. -->
+<!-- Please include the URL. -->
diff --git a/.github/ISSUE_TEMPLATE/04_deployment-problem.md b/.github/ISSUE_TEMPLATE/04_deployment-problem.md
@@ -0,0 +1,23 @@
+---
+name: "\U0001F433 Deployment Problem"
+about: Do you have problems with deployment, and none of the suggestions in the docs helped?
+title: ''
+labels: 'support'
+assignees: ''
+
+---
+
+<!--
+Thanks for reporting an issue with deployment 🙌 ❤️
+
+Before opening a new issue, please make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead. Also, be sure to check our documentation first.
+-->
+
+**Describe the issue:**
+
+<!-- Describe your issue, but please be descriptive! Include screenshots, logs, code or other info to help explain your problem -->
+
+**Technical details:**
+
+- Host Machine OS (Windows/Linux/Mac):
+- Browser (Chrome/Firefox/Safari):
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -10,11 +10,9 @@
 - [ ] Other, please describe:
 
 **Description:**
-
 <!--- Use this section to describe your changes.  Why is this change required? What problem does it solve? If your test fixes a specific issue, don't forget to reference the issue number. If your PR is still a work in progress, that's totally fine – just include [WIP] within the title. -->
 
 **Checklist:**
-
 <!--- Before you submit the PR, go over this checklist and make sure you can tick off all the boxes. [] -> [x] -->
 
 - [ ] I have read the [CONTRIBUTING](../CONTRIBUTING.md) document.
diff --git a/.github/actions/build-environment/Dockerfile b/.github/actions/build-environment/Dockerfile
@@ -1,4 +1,4 @@
-FROM mltooling/build-environment:0.4.3
+FROM mltooling/build-environment:0.6.6
 # Install basics
 # hadolint ignore=DL3005
 RUN apt-get update \
diff --git a/.github/linters/.flake8 b/.github/linters/.flake8
diff --git a/.github/linters/.markdown-lint.yml b/.github/linters/.markdown-lint.yml
diff --git a/.github/release-drafter.yml b/.github/release-drafter.yml
@@ -38,7 +38,10 @@ replacers:
   - search: '/(?:and)?(,)?(\s)*@github-actions(?:\[bot\])?,?/g'
     replace: ""
 template: |
-  [![PyPi Release](https://img.shields.io/pypi/v/lazycluster/$RESOLVED_VERSION?color=blue)](https://pypi.org/project/universal-build/$RESOLVED_VERSION)
+  [![PyPi Release](https://img.shields.io/pypi/v/universal-build/$RESOLVED_VERSION?color=blue)](https://pypi.org/project/universal-build/$RESOLVED_VERSION) [![DockerHub Release](https://img.shields.io/docker/v/mltooling/build-environment/$RESOLVED_VERSION?label=docker%20version&color=blue)](https://hub.docker.com/repository/docker/mltooling/build-environment) [![DockerHub Image Size](https://img.shields.io/docker/image-size/mltooling/build-environment/$RESOLVED_VERSION?label=docker%20image%20size&color=blue)](https://hub.docker.com/repository/docker/mltooling/build-environment)
+
   $CHANGES
+
   ## 👥 Contributors
+
   Thanks to $CONTRIBUTORS for the contributions.
diff --git a/.github/workflows/build-pipeline.yml b/.github/workflows/build-pipeline.yml
@@ -28,6 +28,9 @@ jobs:
         if: ${{ github.event.inputs != null  &&  github.event.inputs.working_directory != null}}
         run: echo "::set-env name=WORKING_DIRECTORY::${{ github.event.inputs.working_directory }}"
         # new syntax: run: echo "WORKING_DIRECTORY=${{ github.event.inputs.working_directory }}" >> "$GITHUB_ENV"
+      # Set host ip to env variable to be uside within container actions
+      - name: set-host-ip
+        run: echo "::set-env name=_HOST_IP::$(hostname -I | cut -d ' ' -f 1)"
       - uses: actions/checkout@v2
       - name: run-build-scripts
         uses: ./.github/actions/build-environment
diff --git a/.github/workflows/check-commit-messages.yml b/.github/workflows/check-commit-messages.yml
diff --git a/.github/workflows/release-pipeline.yml b/.github/workflows/release-pipeline.yml
@@ -4,7 +4,7 @@ on:
   workflow_dispatch:
     inputs:
       version:
-        description: "Version of this release."
+        description: "Version of this release"
         required: true
   milestone:
     types: [closed]
@@ -13,47 +13,69 @@ env:
   VERSION: ${{ secrets.VERSION }}
   BRANCH_PREFIX: "release/v"
   ACTIONS_ALLOW_UNSECURE_COMMANDS: true # TODO: only needed until act supports the new way
+  DEFAULT_BRANCH: main
 
 jobs:
   release:
     runs-on: ubuntu-latest
     steps:
       - if: ${{ github.event.milestone != null  &&  github.event.milestone.title != null }}
         name: set-milestone-version
-        run: echo "::set-env name=VERSION::$(sed "s/^v//" <<< "${{ github.event.milestone.title }}")"
+        run: |
+          echo "::set-env name=VERSION::$(sed "s/^v//" <<< "${{ github.event.milestone.title }}")"
+          echo "::set-env name=PR_MILESTONE_LINK::-M ${{ github.event.milestone.title }}"
       - if: ${{ github.event.inputs != null  &&  github.event.inputs.version != null }}
         name: set-input-version
         run: echo "::set-env name=VERSION::${{ github.event.inputs.version }}"
       - name: check-version
         run: 'if [[ ! "${{ env.VERSION }}" =~ ^([0-9]+\.[0-9]+\.[0-9]+.*)$ ]]; then echo "The version is not valid: ${{ env.VERSION }}"; exit 1; fi'
       - name: set-github-token
         run: echo "::set-env name=GITHUB_TOKEN::${{ secrets.GITHUB_TOKEN }}"
-      - if: ${{ env.GITHUB_TOKEN  &&  env.VERSION }}
+      # Set host ip to env variable to be uside within container actions
+      - name: set-host-ip
+        run: echo "::set-env name=_HOST_IP::$(hostname -I | cut -d ' ' -f 1)"
+      # Fix git version for act if github token is provided
+      - if: ${{ env.GITHUB_ACTOR == 'nektos/act' && env.GITHUB_TOKEN != null && env.GITHUB_TOKEN != '' }}
+        name: install-latest-git
+        run: |
+          # Required for local checkout
+          apt-get update
+          apt-get install -y git
+      - if: ${{ env.GITHUB_TOKEN != null && env.GITHUB_TOKEN != '' }}
         name: create-release-branch
         uses: peterjgrainger/action-create-branch@v2.0.1
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           branch: "${{ env.BRANCH_PREFIX }}${{ env.VERSION }}"
-      - if: ${{ ! env.GITHUB_TOKEN  }}
+      - if: ${{ ! (env.GITHUB_TOKEN != null && env.GITHUB_TOKEN != '')  }}
         uses: actions/checkout@v2
-      - if: ${{ env.GITHUB_TOKEN }}
+      - if: ${{ env.GITHUB_TOKEN != null && env.GITHUB_TOKEN != '' }}
         uses: actions/checkout@v2
         with:
           fetch-depth: 0
           ref: ${{ env.BRANCH_PREFIX }}${{ env.VERSION }}
+          token: ${{ env.GITHUB_TOKEN }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: run-component-builds
         uses: ./.github/actions/build-environment
         with:
           build_args: --make --force --version=${{ env.VERSION  }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: run-linting-and-style-checks
         uses: ./.github/actions/build-environment
         with:
           build_args: --check --force --version=${{ env.VERSION  }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: run-component-tests
         uses: ./.github/actions/build-environment
         with:
           build_args: --test --force --test-marker=slow --version=${{ env.VERSION  }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: release-components
         uses: ./.github/actions/build-environment
         env:
@@ -65,41 +87,46 @@ jobs:
           container_registry_url: ${{ secrets.CONTAINER_REGISTRY_URL }}
           container_registry_username: ${{ secrets.CONTAINER_REGISTRY_USERNAME }}
           container_registry_password: ${{ secrets.CONTAINER_REGISTRY_PASSWORD }}
-      - if: ${{ env.GITHUB_TOKEN }}
-        name: update-repository
+      - if: ${{ env.GITHUB_TOKEN != null && env.GITHUB_TOKEN != '' }}
+        name: push-changes
         uses: stefanzweifel/git-auto-commit-action@v4
         with:
           branch: ${{ env.BRANCH_PREFIX }}${{ env.VERSION  }}
           commit_user_name: Release Bot
           commit_user_email: actions@github.com
           commit_message: Apply automatic release changes for v${{ env.VERSION  }}
           tagging_message: v${{ env.VERSION  }}
-      - if: ${{ env.GITHUB_TOKEN }}
-        name: pull-request
-        uses: repo-sync/pull-request@v2
-        with:
-          source_branch: ${{ env.BRANCH_PREFIX }}${{ env.VERSION  }}
-          destination_branch: "main"
-          pr_title: Finalize release for version ${{ env.VERSION  }}
-          pr_body: "Automated pull request for release version ${{ env.VERSION  }}"
-          pr_draft: false
-          pr_allow_empty: true
-          pr_label: "skip changelog"
-          # only works if it exist: pr_milestone: v${{ env.VERSION  }}
-          github_token: ${{ secrets.GITHUB_TOKEN }}
+          skip_dirty_check: true
+          commit_options: "--allow-empty"
+      - if: ${{ env.GITHUB_TOKEN != null && env.GITHUB_TOKEN != '' }}
+        name: create-pull-request
+        shell: bash
+        run: |
+          # Stops script execution if a command has an error
+          set -e
+          curl -fsSL https://github.com/github/hub/raw/master/script/get | bash -s 2.14.2
+          # TODO: Milestone link currently does not work with closed milestones: ${{ env.PR_MILESTONE_LINK  }} (problem with hub cli)
+          bin/hub pull-request -b ${{ env.DEFAULT_BRANCH }} -h ${{ env.BRANCH_PREFIX }}${{ env.VERSION  }} --no-edit -m "Finalize release for version ${{ env.VERSION  }}" -m "Automated pull request for release version ${{ env.VERSION  }}" -l "skip changelog" || true
+          rm bin/hub
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       # Fix of release drafter to allow different events to trigger the release
-      - if: ${{ env.GITHUB_TOKEN }}
+      # TODO: currently does not work with act
+      - if: ${{ env.GITHUB_ACTOR == 'nektos/act' && env.GITHUB_TOKEN != null && env.GITHUB_TOKEN != '' }}
+        name: no-relese-drafter-support
+        run: echo "The release drafter currently does not work with act, please create the release from the Github UI."
+      - if: ${{ env.GITHUB_ACTOR != 'nektos/act' && env.GITHUB_TOKEN != null && env.GITHUB_TOKEN != '' }}
         name: checkout-fixed-release-drafter
         uses: actions/checkout@v2
         with:
           repository: ml-tooling/release-drafter
-          path: ./.github/actions/release-drafter
-      - if: ${{ env.GITHUB_TOKEN }}
+          path: ./.git/cloned-actions/release-drafter
+      - if: ${{ env.GITHUB_ACTOR != 'nektos/act' && env.GITHUB_TOKEN != null && env.GITHUB_TOKEN != '' }}
         name: create-release-draft
-        uses: ./.github/actions/release-drafter
+        uses: ./.git/cloned-actions/release-drafter
         with:
           version: ${{ env.VERSION }}
           tag: v${{ env.VERSION  }}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      # Optional: upload release assets via actions/upload-release-asset@v1
+      # Optional: upload release assets via actions/upload-release-asset@v1 and via upload_url from release drafter
diff --git a/.github/workflows/reuse-compliance-check.yml b/.github/workflows/reuse-compliance-check.yml

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-FROM mltooling/build-environment:0.4.3`
	`1`	`+FROM mltooling/build-environment:0.6.6`
`2`	`2`	`# Install basics`
`3`	`3`	`# hadolint ignore=DL3005`
`4`	`4`	`RUN apt-get update \`