Fix codacy issues

Author: lukasmasuch

.github/actions/build-environment/Dockerfile

@@ -53,7 +53,7 @@ RUN apt-get update --fix-missing \
     && rm -rf /var/lib/apt/lists/*
 
 # Add tini
-RUN wget --quiet https://github.com/krallin/tini/releases/download/v0.19.0/tini -O /tini && \
+RUN curl -fsSL https://github.com/krallin/tini/releases/download/v0.19.0/tini -o /tini && \
     chmod +x /tini
 
 # Install Docker in Container
@@ -103,7 +103,7 @@ ENV PATH=$RESOURCES_PATH/.pyenv/shims:$RESOURCES_PATH/.pyenv/bin:$PATH \
 
 # Install web development tools
 RUN apt-get update \
-    && curl -sL https://deb.nodesource.com/setup_12.x | bash - \
+    && curl -sL https://deb.nodesource.com/setup_14.x | bash - \
     && apt-get install -y --no-install-recommends nodejs \
     && npm install -g yarn@1 \
     # Clean up
@@ -123,10 +123,11 @@ RUN mkdir -p /github/home/.ssh/ \
 
 # Settings and configurations
 ENV \
-    # Flush log message immediately to stdout
-    PYTHONUNBUFFERED=true \
     # Use local folder as pipenv virtualenv
-    PIPENV_VENV_IN_PROJECT=true
+    PIPENV_VENV_IN_PROJECT=true \
+    # Flush log message immediately to stdout
+    PYTHONUNBUFFERED=true
+
 
 # Install Universal-Build
 # hadolint ignore=DL3013

.github/actions/build-environment/entrypoint.sh

@@ -19,17 +19,17 @@ if [ -n "$GITHUB_TOKEN" ]; then
 fi
 
 if [ -n "$INPUT_CONTAINER_REGISTRY_USERNAME" ] && [ -n "$INPUT_CONTAINER_REGISTRY_PASSWORD" ]; then
-    docker login $INPUT_CONTAINER_REGISTRY_URL -u "$INPUT_CONTAINER_REGISTRY_USERNAME" -p "$INPUT_CONTAINER_REGISTRY_PASSWORD"
+    docker login "$INPUT_CONTAINER_REGISTRY_URL" -u "$INPUT_CONTAINER_REGISTRY_USERNAME" -p "$INPUT_CONTAINER_REGISTRY_PASSWORD"
     BUILD_ARGS="$BUILD_ARGS --container-registry-url=$INPUT_CONTAINER_REGISTRY_URL"
     BUILD_ARGS="$BUILD_ARGS --container-registry-username=$INPUT_CONTAINER_REGISTRY_USERNAME"
     BUILD_ARGS="$BUILD_ARGS --container-registry-password=$INPUT_CONTAINER_REGISTRY_PASSWORD"
 fi
 
 # Navigate to working directory, if provided
 if [ -n "$INPUT_WORKING_DIRECTORY" ]; then
-    cd $INPUT_WORKING_DIRECTORY
+    cd "$INPUT_WORKING_DIRECTORY"
 else
-    cd $GITHUB_WORKSPACE
+    cd "$GITHUB_WORKSPACE"
 fi
 
 if [ -n "$INPUT_PYPI_TOKEN" ]; then
@@ -55,4 +55,4 @@ fi
 set -x
 
 # Execute build script
-python -u build.py $BUILD_ARGS
+python -u build.py "$BUILD_ARGS"

build.py

@@ -57,7 +57,6 @@ def _check(args: Dict[str, Union[bool, str]]):
 
 def _make(args: Dict[str, Union[bool, str]]):
     """Build the library."""
-
     try:
         # Ensure there are no old builds
         rmtree(os.path.join(HERE, "dist"))

src/lazydocs/generation.py

@@ -966,5 +966,6 @@ def generate_docs(
 
         # Write mkdocs pages file
         print("Writing mkdocs .pages file.")
+        # TODO: generate navigation items to fix problem with naming
         with open(os.path.join(output_path, ".pages"), "w") as f:
             f.write(_MKDOCS_PAGES_TEMPLATE.format(overview_file=overview_file))