feat(auction_escrow): allow auction lot reclaim after cleanup time

Author: errfrom

src/HydraAuctionOnchain/Types/AuctionTerms.hs

@@ -4,7 +4,6 @@ module HydraAuctionOnchain.Types.AuctionTerms
   ( PAuctionTerms (PAuctionTerms)
   , pbiddingPeriod
   , pcleanupPeriod
-  , ppenaltyPeriod
   , ppostBiddingPeriod
   , ppostPurchasePeriod
   , ppurchasePeriod
@@ -152,14 +151,6 @@ ppurchasePeriod = phoistAcyclic $
       # auctionTermsFields.biddingEnd
       # auctionTermsFields.purchaseDeadline
 
-ppenaltyPeriod :: Term s (PAuctionTerms :--> PPOSIXTimeRange)
-ppenaltyPeriod = phoistAcyclic $
-  plam $ \auctionTerms -> P.do
-    auctionTermsFields <- pletFields @["purchaseDeadline", "cleanup"] auctionTerms
-    pintervalFiniteClosedOpen
-      # auctionTermsFields.purchaseDeadline
-      # auctionTermsFields.cleanup
-
 pcleanupPeriod :: Term s (PAuctionTerms :--> PPOSIXTimeRange)
 pcleanupPeriod = phoistAcyclic $
   plam $ \auctionTerms ->

src/HydraAuctionOnchain/Validators/AuctionEscrow.hs

@@ -33,7 +33,7 @@ import HydraAuctionOnchain.Types.AuctionTerms
   ( PAuctionTerms
   , pbiddingPeriod
   , pcleanupPeriod
-  , ppenaltyPeriod
+  , ppostPurchasePeriod
   , ppurchasePeriod
   , ptotalAuctionFees
   )
@@ -416,10 +416,9 @@ pcheckSellerReclaims = phoistAcyclic $
     passert $(errCode AuctionEscrow'SellerReclaims'Error'UnexpectedTokensMintedBurned) $
       pfromData txInfoFields.mint #== mempty
 
-    -- This redeemer can only be used during
-    -- the penalty period.
+    -- This redeemer can only be used after the purchase deadline.
     passert $(errCode AuctionEscrow'SellerReclaims'Error'IncorrectValidityInterval) $
-      pcontains # (ppenaltyPeriod # auctionTerms) # txInfoFields.validRange
+      pcontains # (ppostPurchasePeriod # auctionTerms) # txInfoFields.validRange
 
     ------------------------------------------------------------------
     -- Check auction escrow state transition