Skip to content

Commit e601409

Browse files
authored
[Android] Remove var capture in TVM_SOURCE_DIR (#2538)
This PR fixes the TVM_SOURCE_DIR parsing issue on Windows.
1 parent b5b40ee commit e601409

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

android/mlc4j/prepare_libs.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
import argparse
44
import os
5-
import sys
65
import subprocess
6+
import sys
77
from pathlib import Path
88

99
from mlc_llm.support import logging
@@ -22,7 +22,7 @@ def run_cmake(mlc4j_path: Path):
2222
logger.info("Running cmake")
2323
# use pathlib so it is cross platform
2424
android_ndk_path = (
25-
Path(os.environ['ANDROID_NDK']) / "build"/ "cmake"/ "android.toolchain.cmake"
25+
Path(os.environ["ANDROID_NDK"]) / "build" / "cmake" / "android.toolchain.cmake"
2626
)
2727
cmd = [
2828
"cmake",
@@ -60,7 +60,7 @@ def run_cmake_build():
6060
"tvm4j_runtime_packed",
6161
"--config",
6262
"release",
63-
f"-j{os.cpu_count()}"
63+
f"-j{os.cpu_count()}",
6464
]
6565
subprocess.run(cmd, check=True, env=os.environ)
6666

@@ -93,7 +93,7 @@ def main(mlc_llm_source_dir: Path):
9393
if "TVM_SOURCE_DIR" in os.environ:
9494
logger.info('Set TVM_SOURCE_DIR to "%s"', os.environ["TVM_SOURCE_DIR"])
9595
with open("config.cmake", "w", encoding="utf-8") as file:
96-
print("set(TVM_SOURCE_DIR ${%s})" % os.environ["TVM_SOURCE_DIR"], file=file)
96+
print("set(TVM_SOURCE_DIR %s)" % os.environ["TVM_SOURCE_DIR"], file=file)
9797

9898
# - Run cmake, build and install
9999
run_cmake(mlc_llm_source_dir / "android" / "mlc4j")

0 commit comments

Comments
 (0)