Skip to content

Commit 0ad7788

Browse files
committed
fix in workload target condition check
1 parent 210d671 commit 0ad7788

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

algoperf/workloads/lm/workload.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def target_metric_name(self) -> str:
3838
return 'ppl'
3939

4040
def has_reached_validation_target(self, eval_result: float) -> bool:
41-
return eval_result['validation/ppl'] > self.validation_target_value
41+
return eval_result['validation/ppl'] < self.validation_target_value
4242

4343
@property
4444
def validation_target_value(self) -> float:
@@ -178,9 +178,7 @@ def _eval_model_on_split(
178178
eval_metrics[metric_name] += metric_value
179179

180180
eval_results = self._normalize_eval_metrics(num_examples, eval_metrics)
181-
eval_results['ppl'] = np.exp(eval_results['loss'])
182-
print(eval_results)
183-
181+
eval_results['ppl'] = np.exp(eval_results['loss'])
184182
return eval_results
185183

186184
@abc.abstractmethod

0 commit comments

Comments
 (0)