Fix Bug: do not skip measurements checks

Author: pgmpablo157321

tools/submission/submission_checker/checks/base.py

@@ -23,10 +23,16 @@ def run_checks(self):
         valid = True
         errors = []
         for check in self.checks:
-            v = self.execute(check)
-            valid &= v
-            if not valid:
-                return False
+            try:
+                v = self.execute(check)
+                valid &= v
+            except BaseException:
+                valid &= False
+                self.log.error(
+                    "Execution occurred in running check %s. Running %s in %s",
+                    self.path,
+                    check.__name__,
+                    self.__class__.__name__)
         return valid
 
     def execute(self, check):

tools/submission/submission_checker/checks/performance_check.py

@@ -232,9 +232,8 @@ def network_check(self):
             is_valid = expected_state_by_division[self.division] is is_network_system
         if not is_valid:
             self.log.error(
-                f"{
-                    self.path} incorrect network mode(={is_network_system}) for division '{
-                    self.division}'"
+                f"{self.path} incorrect network mode(={is_network_system}) "
+                f"for division {self.division}"
             )
             return False
 
@@ -298,7 +297,7 @@ def inferred_check(self):
                 ("singlestream", "offline")
             ]
             if (self.scenario.lower(), self.scenario_fixed.lower()
-                    ) not in list_inferred:
+                ) not in list_inferred:
                 self.log.error(
                     "Result for scenario %s can not be inferred from %s for: %s",
                     self.scenario_fixed,
@@ -362,12 +361,12 @@ def get_inferred_result(self, res):
             res = qps_wo_loadgen_overhead
 
         if (self.scenario_fixed in ["Offline"]
-                ) and self.scenario in ["MultiStream"]:
+            ) and self.scenario in ["MultiStream"]:
             inferred = True
             res = samples_per_query * S_TO_MS / (latency_mean / MS_TO_NS)
 
         if (self.scenario_fixed in ["MultiStream"]
-                ) and self.scenario in ["SingleStream"]:
+            ) and self.scenario in ["SingleStream"]:
             inferred = True
             # samples_per_query does not match with the one reported in the logs
             # when inferring MultiStream from SingleStream
@@ -384,6 +383,6 @@ def get_inferred_result(self, res):
             else:
                 res = (latency_99_percentile * samples_per_query) / MS_TO_NS
         if (self.scenario_fixed in ["Interactive"]
-                ) and self.scenario not in ["Server"]:
+            ) and self.scenario not in ["Server"]:
             is_valid = False
         return res, is_valid

tools/submission/submission_checker/checks/power/power_checker.py

@@ -651,10 +651,9 @@ def find_error_or_warning(reg_exp: str, line: str, error: bool) -> None:
             if error:
                 if problem_line.group(0).strip() in COMMON_ERROR_TESTING:
                     raise CheckerWarning(
-                        f"{
-                            line.strip().replace(
-                                'ERROR',
-                                'Warning')!r} in ptd_log.txt during testing stage but it is accepted. Treated as WARNING"
+                        f"{line.strip().replace('ERROR','Warning')!r} in"
+                        f"ptd_log.txt during testing stage but it is accepted."
+                        "Treated as WARNING"
                     )
                 assert (
                     start_ranging_time < log_time < stop_ranging_time

tools/submission/submission_checker/checks/system_check.py

@@ -71,9 +71,8 @@ def network_check(self):
         if self.division in expected_state_by_division:
             if expected_state_by_division[self.division] != is_network:
                 self.log.error(
-                    f"{
-                        self.path} incorrect network mode(={is_network}) for division '{
-                        self.division}'"
+                    f"{self.path} incorrect network mode(={is_network})"
+                    f"for division '{self.division}'"
                 )
                 return False
         return True

tools/submission/submission_checker/main.py

@@ -155,8 +155,6 @@ def main():
             log, logs.loader_data["system_path"], config, logs)
         measurements_checks = MeasurementsCheck(
             log, logs.loader_data["measurements_path"], config, logs)
-        measurements_checks = ComplianceCheck(
-            log, logs.loader_data["compliance_path"], config, logs)
         power_checks = PowerCheck(
             log, logs.loader_data["power_dir_path"], config, logs)
         # Run checks