Skip to content

Commit 9bfb828

Browse files
hasan7nhasan7n
authored
Support bare docker (#642)
* draft: docker-only support * finalize containers * add semver requirement * remove cookiecutter deps * bugfix * better inspect * misc - create folders/files before mounting - remove manual shell quoting - some bugfixes * bugfix in get resources * fix predictions arg name in inference * finalize singularity support * finalize tests, fix bugs * add ports * edit container dev run command * remove outdated file * fix publish_on typo * fix bug * fix mounts * update docs, misc bug fixes * update requirements * update test hashes, update compatibilitu testing code * update data prep container config * update seed.py for tests * fix compatibility tests * remove 'mlcube' from user screen * update auth tests * remove dirty code * update docs * remove outdated script * mark a test script as outdated * update unittests
1 parent 66e5bd1 commit 9bfb828

File tree

197 files changed

+2220
-3293
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

197 files changed

+2220
-3293
lines changed

‎cli/auth_tests.sh‎

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
################### Start Testing ########################
66
##########################################################
77

8-
98
##########################################################
109
echo "=========================================="
1110
echo "Creating test profiles for each user"
@@ -82,24 +81,24 @@ echo "\n"
8281

8382
##########################################################
8483
echo "====================================="
85-
echo "Submit cubes"
84+
echo "Submit containers"
8685
echo "====================================="
8786

88-
medperf mlcube submit --name prep -m $PREP_MLCUBE -p $PREP_PARAMS --operational
87+
medperf container submit --name prep -m $PREP_MLCUBE -p $PREP_PARAMS --operational
8988
checkFailed "Prep submission failed"
90-
PREP_UID=$(medperf mlcube ls | tail -n 1 | tr -s ' ' | cut -d ' ' -f 2)
89+
PREP_UID=$(medperf container ls | tail -n 1 | tr -s ' ' | cut -d ' ' -f 2)
9190

92-
medperf mlcube submit --name model1 -m $MODEL_MLCUBE -p $MODEL1_PARAMS -a $MODEL_ADD --operational
91+
medperf container submit --name model1 -m $MODEL_MLCUBE -p $MODEL1_PARAMS -a $MODEL_ADD --operational
9392
checkFailed "Model1 submission failed"
94-
MODEL1_UID=$(medperf mlcube ls | tail -n 1 | tr -s ' ' | cut -d ' ' -f 2)
93+
MODEL1_UID=$(medperf container ls | tail -n 1 | tr -s ' ' | cut -d ' ' -f 2)
9594

9695
# wait 30s to make sure the token will be refreshed under the hood
9796
# (so that this functionality is tested). The chosen place of this is arbitrary
9897
sleep 30
9998

100-
medperf mlcube submit --name metrics -m $METRIC_MLCUBE -p $METRIC_PARAMS --operational
99+
medperf container submit --name metrics -m $METRIC_MLCUBE -p $METRIC_PARAMS --operational
101100
checkFailed "Metrics submission failed"
102-
METRICS_UID=$(medperf mlcube ls | tail -n 1 | tr -s ' ' | cut -d ' ' -f 2)
101+
METRICS_UID=$(medperf container ls | tail -n 1 | tr -s ' ' | cut -d ' ' -f 2)
103102
##########################################################
104103

105104
echo "\n"
@@ -118,7 +117,7 @@ echo "\n"
118117
echo "====================================="
119118
echo "Submit benchmark"
120119
echo "====================================="
121-
medperf benchmark submit --name bmk --description bmk --demo-url $DEMO_URL --data-preparation-mlcube $PREP_UID --reference-model-mlcube $MODEL1_UID --evaluator-mlcube $METRICS_UID --operational
120+
medperf benchmark submit --name bmk --description bmk --demo-url $DEMO_URL --data-preparation-container $PREP_UID --reference-model-container $MODEL1_UID --evaluator-container $METRICS_UID --operational
122121
checkFailed "Benchmark submission failed"
123122
BMK_UID=$(medperf benchmark ls | tail -n 1 | tr -s ' ' | cut -d ' ' -f 2)
124123

‎cli/cli_chestxray_tutorial_test.sh‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@ print_eval medperf profile create -n testbenchmark
2525
checkFailed "testbenchmark profile creation failed"
2626
print_eval medperf profile create -n testdata
2727
checkFailed "testdata profile creation failed"
28+
print_eval medperf profile create -n noserver
29+
checkFailed "noserver profile creation failed"
30+
print_eval medperf profile set --server https://example.com
31+
checkFailed "setting mock server failed"
2832

2933
echo "=========================================="
3034
echo "Login each user"
@@ -103,12 +107,17 @@ checkFailed "Benchmark execution step failed"
103107
# Test offline compatibility test
104108
print_eval wget -P $MODEL_LOCAL/workspace/additional_files "https://storage.googleapis.com/medperf-storage/chestxray_tutorial/cnn_weights.tar.gz"
105109
print_eval tar -xzvf $MODEL_LOCAL/workspace/additional_files/cnn_weights.tar.gz -C $MODEL_LOCAL/workspace/additional_files
110+
111+
## Change the server and logout just to make sure this command will work without connecting to a server
112+
print_eval medperf profile activate noserver
113+
checkFailed "noserver profile activation failed"
114+
106115
print_eval medperf test run --offline --no-cache \
107116
--demo_dataset_url https://storage.googleapis.com/medperf-storage/chestxray_tutorial/demo_data.tar.gz \
108117
--demo_dataset_hash "71faabd59139bee698010a0ae3a69e16d97bc4f2dde799d9e187b94ff9157c00" \
109-
-p $PREP_LOCAL \
110-
-m $MODEL_LOCAL \
111-
-e $METRIC_LOCAL
118+
-p $PREP_LOCAL/container_config.yaml \
119+
-m $MODEL_LOCAL/container_config.yaml \
120+
-e $METRIC_LOCAL/container_config.yaml
112121

113122
checkFailed "offline compatibility test execution step failed"
114123
print_eval rm $MODEL_LOCAL/workspace/additional_files/cnn_weights.tar.gz
@@ -141,6 +150,9 @@ checkFailed "Profile deletion failed"
141150
print_eval medperf profile delete testdata
142151
checkFailed "Profile deletion failed"
143152

153+
print_eval medperf profile delete noserver
154+
checkFailed "Profile deletion failed"
155+
144156
if ${CLEANUP}; then
145157
clean
146158
fi

‎cli/cli_test_manual_prep.sh‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
################### Start Testing ########################
66
##########################################################
77

8-
98
##########################################################
109
echo "=========================================="
1110
echo "Printing MedPerf version"
@@ -84,14 +83,14 @@ echo "\n"
8483

8584
##########################################################
8685
echo "====================================="
87-
echo "Submit cubes"
86+
echo "Submit containers"
8887
echo "====================================="
8988

9089
PREP_MLCUBE="https://raw.githubusercontent.com/aristizabal95/medperf-2/4aea7de62fd71b377fd3a0b58352d104fd8f9c08/examples/DataPrepManualSteps/data_prep/mlcube/mlcube.yaml"
9190
PREP_PARAMS="https://raw.githubusercontent.com/aristizabal95/medperf-2/4aea7de62fd71b377fd3a0b58352d104fd8f9c08/examples/DataPrepManualSteps/data_prep/mlcube/workspace/parameters.yaml"
92-
print_eval medperf mlcube submit --name manprep -m $PREP_MLCUBE -p $PREP_PARAMS
91+
print_eval medperf container submit --name manprep -m $PREP_MLCUBE -p $PREP_PARAMS
9392
checkFailed "Prep submission failed"
94-
PREP_UID=$(medperf mlcube ls | tail -n 1 | tr -s ' ' | cut -d ' ' -f 2)
93+
PREP_UID=$(medperf container ls | tail -n 1 | tr -s ' ' | cut -d ' ' -f 2)
9594
echo "PREP_UID=$PREP_UID"
9695

9796
##########################################################

‎cli/cli_tests.sh‎

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -91,57 +91,57 @@ echo "\n"
9191

9292
##########################################################
9393
echo "====================================="
94-
echo "Existing cubes":
94+
echo "Existing containers":
9595
echo "====================================="
96-
print_eval medperf mlcube ls
96+
print_eval medperf container ls
9797
##########################################################
9898

9999
echo "\n"
100100

101101
##########################################################
102102
echo "====================================="
103-
echo "Submit cubes"
103+
echo "Submit containers"
104104
echo "====================================="
105105

106-
print_eval medperf mlcube submit --name mock-prep -m $PREP_MLCUBE -p $PREP_PARAMS --operational
106+
print_eval medperf container submit --name mock-prep -m $PREP_MLCUBE -p $PREP_PARAMS --operational
107107
checkFailed "Prep submission failed"
108-
PREP_UID=$(medperf mlcube ls | grep mock-prep | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
108+
PREP_UID=$(medperf container ls | grep mock-prep | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
109109
echo "PREP_UID=$PREP_UID"
110110

111-
print_eval medperf mlcube submit --name model1 -m $MODEL_MLCUBE -p $MODEL1_PARAMS -a $MODEL_ADD --operational
111+
print_eval medperf container submit --name model1 -m $MODEL_MLCUBE -p $MODEL1_PARAMS -a $MODEL_ADD --operational
112112
checkFailed "Model1 submission failed"
113-
MODEL1_UID=$(medperf mlcube ls | grep model1 | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
113+
MODEL1_UID=$(medperf container ls | grep model1 | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
114114
echo "MODEL1_UID=$MODEL1_UID"
115115

116-
print_eval medperf mlcube submit --name model2 -m $MODEL_MLCUBE -p $MODEL2_PARAMS -a $MODEL_ADD --operational
116+
print_eval medperf container submit --name model2 -m $MODEL_MLCUBE -p $MODEL2_PARAMS -a $MODEL_ADD --operational
117117
checkFailed "Model2 submission failed"
118-
MODEL2_UID=$(medperf mlcube ls | grep model2 | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
118+
MODEL2_UID=$(medperf container ls | grep model2 | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
119119
echo "MODEL2_UID=$MODEL2_UID"
120120

121-
# MLCube with singularity section
122-
print_eval medperf mlcube submit --name model3 -m $MODEL_WITH_SINGULARITY -p $MODEL3_PARAMS -a $MODEL_ADD -i $MODEL_SING_IMAGE --operational
121+
# Container with singularity section
122+
print_eval medperf --platform singularity container submit --name model3 -m $MODEL_WITH_SINGULARITY -p $MODEL3_PARAMS -a $MODEL_ADD --operational
123123
checkFailed "Model3 submission failed"
124-
MODEL3_UID=$(medperf mlcube ls | grep model3 | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
124+
MODEL3_UID=$(medperf container ls | grep model3 | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
125125
echo "MODEL3_UID=$MODEL3_UID"
126126

127-
print_eval medperf mlcube submit --name model-fail -m $FAILING_MODEL_MLCUBE -p $MODEL4_PARAMS -a $MODEL_ADD --operational
127+
print_eval medperf container submit --name model-fail -m $FAILING_MODEL_MLCUBE -p $MODEL4_PARAMS -a $MODEL_ADD --operational
128128
checkFailed "failing model submission failed"
129-
FAILING_MODEL_UID=$(medperf mlcube ls | grep model-fail | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
129+
FAILING_MODEL_UID=$(medperf container ls | grep model-fail | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
130130
echo "FAILING_MODEL_UID=$FAILING_MODEL_UID"
131131

132-
print_eval medperf mlcube submit --name model-log-none -m $MODEL_LOG_MLCUBE -p $MODEL_LOG_NONE_PARAMS --operational
132+
print_eval medperf container submit --name model-log-none -m $MODEL_LOG_MLCUBE -p $MODEL_LOG_NONE_PARAMS --operational
133133
checkFailed "Model with logging None submission failed"
134-
MODEL_LOG_NONE_UID=$(medperf mlcube ls | grep model-log-none | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
134+
MODEL_LOG_NONE_UID=$(medperf container ls | grep model-log-none | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
135135
echo "MODEL_LOG_NONE_UID=$MODEL_LOG_NONE_UID"
136136

137-
print_eval medperf mlcube submit --name model-log-debug -m $MODEL_LOG_MLCUBE -p $MODEL_LOG_DEBUG_PARAMS --operational
137+
print_eval medperf container submit --name model-log-debug -m $MODEL_LOG_MLCUBE -p $MODEL_LOG_DEBUG_PARAMS --operational
138138
checkFailed "Model with logging debug submission failed"
139-
MODEL_LOG_DEBUG_UID=$(medperf mlcube ls | grep model-log-debug | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
139+
MODEL_LOG_DEBUG_UID=$(medperf container ls | grep model-log-debug | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
140140
echo "MODEL_LOG_DEBUG_UID=$MODEL_LOG_DEBUG_UID"
141141

142-
print_eval medperf mlcube submit --name mock-metrics -m $METRIC_MLCUBE -p $METRIC_PARAMS --operational
142+
print_eval medperf container submit --name mock-metrics -m $METRIC_MLCUBE -p $METRIC_PARAMS --operational
143143
checkFailed "Metrics submission failed"
144-
METRICS_UID=$(medperf mlcube ls | grep mock-metrics | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
144+
METRICS_UID=$(medperf container ls | grep mock-metrics | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
145145
echo "METRICS_UID=$METRICS_UID"
146146
##########################################################
147147

@@ -161,7 +161,7 @@ echo "\n"
161161
echo "====================================="
162162
echo "Submit benchmark"
163163
echo "====================================="
164-
print_eval medperf benchmark submit --name bmk --description bmk --demo-url $DEMO_URL --data-preparation-mlcube $PREP_UID --reference-model-mlcube $MODEL1_UID --evaluator-mlcube $METRICS_UID --operational
164+
print_eval medperf benchmark submit --name bmk --description bmk --demo-url $DEMO_URL --data-preparation-container $PREP_UID --reference-model-container $MODEL1_UID --evaluator-container $METRICS_UID --operational
165165
checkFailed "Benchmark submission failed"
166166
BMK_UID=$(medperf benchmark ls | grep bmk | tail -n 1 | tr -s ' ' | cut -d ' ' -f 2)
167167
echo "BMK_UID=$BMK_UID"
@@ -299,7 +299,7 @@ echo "\n"
299299
echo "====================================="
300300
echo "Running model2 association"
301301
echo "====================================="
302-
print_eval medperf mlcube associate -m $MODEL2_UID -b $BMK_UID -y
302+
print_eval medperf container associate -m $MODEL2_UID -b $BMK_UID -y
303303
checkFailed "Model2 association failed"
304304
##########################################################
305305

@@ -309,10 +309,10 @@ echo "\n"
309309
echo "====================================="
310310
echo "Running model3 association (with singularity)"
311311
echo "====================================="
312-
# this will run two types of singularity mlcubes:
312+
# this will run two types of singularity containers:
313313
# 1) an already built singularity image (model 3)
314314
# 2) a docker image to be converted (metrics)
315-
print_eval medperf --platform singularity mlcube associate -m $MODEL3_UID -b $BMK_UID -y
315+
print_eval medperf --platform singularity container associate -m $MODEL3_UID -b $BMK_UID -y
316316
checkFailed "Model3 association failed"
317317
##########################################################
318318

@@ -322,7 +322,7 @@ echo "\n"
322322
echo "======================================================"
323323
echo "Running failing model association (This will NOT fail)"
324324
echo "======================================================"
325-
print_eval medperf mlcube associate -m $FAILING_MODEL_UID -b $BMK_UID -y
325+
print_eval medperf container associate -m $FAILING_MODEL_UID -b $BMK_UID -y
326326
checkFailed "Failing model association failed"
327327
##########################################################
328328

@@ -332,7 +332,7 @@ echo "\n"
332332
echo "======================================================"
333333
echo "Running logging-model-without-env association"
334334
echo "======================================================"
335-
print_eval medperf mlcube associate -m $MODEL_LOG_NONE_UID -b $BMK_UID -y
335+
print_eval medperf container associate -m $MODEL_LOG_NONE_UID -b $BMK_UID -y
336336
checkFailed "Logging-model-without-env association association failed"
337337
##########################################################
338338

@@ -342,7 +342,7 @@ echo "\n"
342342
echo "======================================================"
343343
echo "Running logging-model-with-debug association"
344344
echo "======================================================"
345-
print_eval medperf --container-loglevel debug mlcube associate -m $MODEL_LOG_DEBUG_UID -b $BMK_UID -y
345+
print_eval medperf --container-loglevel debug container associate -m $MODEL_LOG_DEBUG_UID -b $BMK_UID -y
346346
checkFailed "Logging-model-with-debug association failed"
347347
##########################################################
348348

@@ -440,21 +440,21 @@ echo "\n"
440440

441441
##########################################################
442442
echo "======================================================================================"
443-
echo "Run failing cube with ignore errors (This SHOULD fail since predictions folder exists)"
443+
echo "Run failing container with ignore errors (This SHOULD fail since predictions folder exists)"
444444
echo "======================================================================================"
445445
print_eval medperf run -b $BMK_UID -d $DSET_A_UID -m $FAILING_MODEL_UID -y --ignore-model-errors
446-
checkSucceeded "MLCube ran successfuly but should fail since predictions folder exists"
446+
checkSucceeded "Container ran successfuly but should fail since predictions folder exists"
447447
##########################################################
448448

449449
echo "\n"
450450

451451
##########################################################
452452
echo "====================================================================="
453-
echo "Run failing cube with ignore errors after deleting predictions folder"
453+
echo "Run failing container with ignore errors after deleting predictions folder"
454454
echo "====================================================================="
455455
print_eval rm -rf $MEDPERF_STORAGE/predictions/$SERVER_STORAGE_ID/model-fail/$DSET_A_GENUID
456456
print_eval medperf run -b $BMK_UID -d $DSET_A_UID -m $FAILING_MODEL_UID -y --ignore-model-errors
457-
checkFailed "Failing mlcube run with ignore errors failed"
457+
checkFailed "Failing container run with ignore errors failed"
458458
##########################################################
459459

460460
echo "\n"

‎cli/cli_tests_multisource.sh‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# IMPORTANT: This script is outdated
12
# import setup
23
. "$(dirname $(realpath "$0"))/tests_setup.sh"
34

‎cli/cli_tests_training.sh‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -96,20 +96,20 @@ echo "\n"
9696

9797
##########################################################
9898
echo "====================================="
99-
echo "Submit cubes"
99+
echo "Submit containers"
100100
echo "====================================="
101101

102-
print_eval medperf mlcube submit --name trainprep -m $PREP_TRAINING_MLCUBE --operational
102+
print_eval medperf container submit --name trainprep -m $PREP_TRAINING_MLCUBE --operational
103103
checkFailed "Train prep submission failed"
104-
PREP_UID=$(medperf mlcube ls | grep trainprep | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
104+
PREP_UID=$(medperf container ls | grep trainprep | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
105105

106-
print_eval medperf mlcube submit --name traincube -m $TRAIN_MLCUBE -a $TRAIN_WEIGHTS --operational
107-
checkFailed "traincube submission failed"
108-
TRAINCUBE_UID=$(medperf mlcube ls | grep traincube | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
106+
print_eval medperf container submit --name traincube -m $TRAIN_MLCUBE -a $TRAIN_WEIGHTS --operational
107+
checkFailed "fl container submission failed"
108+
TRAINCUBE_UID=$(medperf container ls | grep traincube | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
109109

110-
print_eval medperf mlcube submit --name fladmincube -m $FLADMIN_MLCUBE --operational
111-
checkFailed "fladmincube submission failed"
112-
FLADMINCUBE_UID=$(medperf mlcube ls | grep fladmincube | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
110+
print_eval medperf container submit --name fladmincube -m $FLADMIN_MLCUBE --operational
111+
checkFailed "fladmin container submission failed"
112+
FLADMINCUBE_UID=$(medperf container ls | grep fladmincube | head -n 1 | tr -s ' ' | cut -d ' ' -f 2)
113113

114114
##########################################################
115115

@@ -248,7 +248,7 @@ echo "====================================="
248248
print_eval medperf aggregator start -t $TRAINING_UID -p $HOSTNAME_ </dev/null >agg.log 2>&1 &
249249
AGG_PID=$!
250250

251-
# sleep so that the mlcube is run before we change profiles
251+
# sleep so that the container is run before we change profiles
252252
sleep 7
253253

254254
# Check if the command is still running.
@@ -327,7 +327,7 @@ echo "====================================="
327327
print_eval medperf dataset train -d $DSET_1_UID -t $TRAINING_UID -y </dev/null >col1.log 2>&1 &
328328
COL1_PID=$!
329329

330-
# sleep so that the mlcube is run before we change profiles
330+
# sleep so that the container is run before we change profiles
331331
sleep 7
332332

333333
# Check if the command is still running.
@@ -406,7 +406,7 @@ echo "====================================="
406406
print_eval medperf dataset train -d $DSET_2_UID -t $TRAINING_UID -y </dev/null >col2.log 2>&1 &
407407
COL2_PID=$!
408408

409-
# sleep so that the mlcube is run before we change profiles
409+
# sleep so that the container is run before we change profiles
410410
sleep 7
411411

412412
# Check if the command is still running.

‎cli/medperf/certificates.py‎

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,32 +6,36 @@ def get_client_cert(ca: CA, email: str, output_path: str):
66
"""Responsible for getting a user cert"""
77
common_name = email
88
ca.prepare_config()
9-
params = {
9+
mounts = {
1010
"ca_config": ca.config_path,
1111
"pki_assets": output_path,
1212
}
1313
env = {"MEDPERF_INPUT_CN": common_name}
1414

1515
mlcube = Cube.get(ca.client_mlcube)
1616
mlcube.download_run_files()
17-
mlube_task = "get_client_cert"
18-
mlcube.run(task=mlube_task, env_dict=env, **params)
17+
mlcube.run(task="get_client_cert", mounts=mounts, env=env, disable_network=False)
1918

2019

2120
def get_server_cert(ca: CA, address: str, output_path: str):
2221
"""Responsible for getting a server cert"""
2322
common_name = address
2423
ca.prepare_config()
25-
params = {
24+
mounts = {
2625
"ca_config": ca.config_path,
2726
"pki_assets": output_path,
2827
}
2928
env = {"MEDPERF_INPUT_CN": common_name}
3029

3130
mlcube = Cube.get(ca.server_mlcube)
3231
mlcube.download_run_files()
33-
mlube_task = "get_server_cert"
34-
mlcube.run(task=mlube_task, env_dict=env, port=80, **params)
32+
mlcube.run(
33+
task="get_server_cert",
34+
mounts=mounts,
35+
env=env,
36+
ports=["0.0.0.0:80:80"],
37+
disable_network=False,
38+
)
3539

3640

3741
def trust(ca: CA):
@@ -40,11 +44,10 @@ def trust(ca: CA):
4044
by the aggregator
4145
"""
4246
ca.prepare_config()
43-
params = {
47+
mounts = {
4448
"ca_config": ca.config_path,
4549
"pki_assets": ca.pki_assets,
4650
}
4751
mlcube = Cube.get(ca.ca_mlcube)
4852
mlcube.download_run_files()
49-
mlube_task = "trust"
50-
mlcube.run(task=mlube_task, **params)
53+
mlcube.run(task="trust", mounts=mounts, disable_network=False)

0 commit comments

Comments
 (0)