Skip to content

Commit dc0ccc4

Browse files
committed
Clean up modelbench-private references.
1 parent 456712b commit dc0ccc4

File tree

5 files changed

+1
-24
lines changed

5 files changed

+1
-24
lines changed

.env

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
# if you want to use modelbench from modelbench-private, uncomment below line
2-
# NOTE: this will not work if you do not have access to that repo
3-
# USE_PRIVATE_MODELBENCH=true
4-
51
# postgres env for local mlflow tracking server
62
# you don't need to set these if mlflow is already running somewhere else
73
# (in that case, you don't need postgres at all)

.env.jupyteronly

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
# if you want to use modelbench from modelbench-private, uncomment below line
2-
# NOTE: this will not work if you do not have access to that repo
3-
USE_PRIVATE_MODELBENCH=true
4-
51
# THIS MUST BE SET
62
MLFLOW_TRACKING_URI=https://modelplane.mlflow.dev.modelmodel.org
73

.env.nojupyter

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
# if you want to use modelbench from modelbench-private, uncomment below line
2-
# NOTE: this will not work if you do not have access to that repo
3-
# USE_PRIVATE_MODELBENCH=true
4-
51
# postgres env for local mlflow tracking server
62
# you don't need to set these if mlflow is already running somewhere else
73
# (in that case, you don't need postgres at all)

Dockerfile.jupyter

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
FROM python:3.12-slim
22

3-
ARG USE_PRIVATE_MODELBENCH
4-
53
ENV PATH="/root/.local/bin:$PATH"
6-
ENV USE_PRIVATE_MODELBENCH=${USE_PRIVATE_MODELBENCH}
74
# Used for the notebook server
85
WORKDIR /app
96

@@ -18,12 +15,7 @@ RUN mkdir -p /root/.ssh && chmod 700 /root/.ssh
1815
RUN git config --global core.sshCommand "ssh -o UserKnownHostsFile=/root/.ssh/known_hosts -o ForwardAgent=yes"
1916
RUN ssh-keyscan github.com > /root/.ssh/known_hosts
2017

21-
# conditionally forward ssh key to install private dependencies
22-
RUN --mount=type=ssh if [ "$USE_PRIVATE_MODELBENCH" = "true" ]; then \
23-
poetry install --no-interaction --no-ansi --no-root --extras modelbench-private; \
24-
else \
25-
poetry install --no-interaction --no-ansi --no-root; \
26-
fi
18+
RUN poetry install --no-interaction --no-ansi --no-root
2719

2820
COPY src/ ./src/
2921
RUN echo $(poetry env info --path)

docker-compose.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,10 @@ services:
6060
build:
6161
context: .
6262
dockerfile: Dockerfile.jupyter
63-
args:
64-
USE_PRIVATE_MODELBENCH: ${USE_PRIVATE_MODELBENCH}
6563
environment:
6664
MLFLOW_TRACKING_URI: ${MLFLOW_TRACKING_URI}
6765
MLFLOW_TRACKING_USERNAME: ${MLFLOW_TRACKING_USERNAME}
6866
MLFLOW_TRACKING_PASSWORD: ${MLFLOW_TRACKING_PASSWORD}
69-
USE_PRIVATE_MODELBENCH: ${USE_PRIVATE_MODELBENCH}
7067
JUPYTER_TOKEN: ${JUPYTER_TOKEN}
7168
GIT_PYTHON_REFRESH: ${GIT_PYTHON_REFRESH}
7269
VLLM_API_KEY: ${VLLM_API_KEY}

0 commit comments

Comments
 (0)