:global no longer valid_ir_argument; rm is_defined_nothrow_global

JuliaLang/julia#56746.  Also call :slot and :static_parameter valid (for now)

Author: mlechu

src/linear_ir.jl

@@ -3,24 +3,15 @@
 
 function is_valid_ir_argument(ctx, ex)
     k = kind(ex)
-    if is_simple_atom(ctx, ex) || k == K"inert" || k == K"top" || k == K"core"
+    if is_simple_atom(ctx, ex) || k in KSet"inert top core quote"
         true
     elseif k == K"BindingId"
         binfo = lookup_binding(ctx, ex)
         bk = binfo.kind
         # TODO: Can we allow bk == :local || bk == :argument || bk == :static_parameter ???
         # Why does flisp seem to allow (slot) and (static_parameter), but these
         # aren't yet converted to by existing lowering??
-        if bk == :global
-            # Globals are nothrow when they are defined - we assume a previously
-            # defined global can never be set to undefined. (TODO: This could be
-            # broken when precompiling a module `B` in the presence of a badly
-            # behaved module `A`, which inconsistently defines globals during
-            # `A.__init__()`??)
-            is_defined_nothrow_global(binfo.mod, Symbol(binfo.name))
-        else
-            false
-        end
+        (bk == :slot || bk == :static_parameter)
     else
         false
     end

src/runtime.jl

@@ -375,16 +375,6 @@ function is_defined_and_owned_global(mod, name)
     !isnothing(b) && isdefined(b, :owner) && b.owner === b
 end
 
-# Return true if `name` is defined in `mod`, the sense that accessing it is nothrow.
-# Has no side effects, unlike isdefined()
-#
-# (This should do what fl_nothrow_julia_global does for flisp lowering)
-function is_defined_nothrow_global(mod, name)
-    b = _get_module_binding(mod, name)
-    !isnothing(b) && isdefined(b, :owner) || return false
-    isdefined(b.owner, :value)
-end
-
 # "Reserve" a binding: create the binding if it doesn't exist but do not assign
 # to it.
 function reserve_module_binding(mod, name)