used first instead of find; match was inverted

Author: niquerio

lib/patron/employee.rb

@@ -87,8 +87,8 @@ def hr_data
     end
 
     def campus_code_from_inst_role
-      umichinstrole = @data["umichinstroles"].first { |x| inst_role_base.match?(x) }
-      Patron.inst_role_map.first { |x| x["key"] == umichinstrole }["campus"]
+      umichinstrole = @data["umichinstroles"].find { |x| x.match?(inst_role_base) }
+      Patron.inst_role_map.find { |x| x["key"] == umichinstrole }["campus"]
     end
   end
 end

spec/patron/faculty_spec.rb

@@ -19,9 +19,9 @@
       expect(subject.campus_code).to eq("UMFL")
     end
     it "comes from first faculty matched inst role when not hr data" do
-      @patron["umichinstroles"].push("FacultyAA")
+      @patron["umichinstroles"][1] = "FacultyDBRN"
       @patron["umichhr"] = []
-      expect(subject.campus_code).to eq("UMAA")
+      expect(subject.campus_code).to eq("UMDB")
     end
   end
   context "#includable?" do