handles emeritus faculty without umichhr data

Author: niquerio

lib/patron.rb

@@ -15,6 +15,10 @@
 class Patron
   INST_ROLE_MAP = YAML.load_file("./config/umich_inst_roles_map.yaml")
 
+  def self.inst_role_map
+    INST_ROLE_MAP
+  end
+
   def self.inst_roles_for(data)
     INST_ROLE_MAP.select do |inst_role|
       data["umichinstroles"].include?(inst_role["key"])

lib/patron/employee.rb

@@ -14,6 +14,10 @@ def hr_criteria(hr_item)
       raise NotImplementedError
     end
 
+    def inst_role_base
+      raise NotImplementedError
+    end
+
     [
       "statistic_category",
       "user_group",
@@ -26,7 +30,7 @@ def hr_criteria(hr_item)
     end
 
     def campus_code
-      HR_CAMPUS_MAP[hr_data.campus.downcase]
+      HR_CAMPUS_MAP.dig(hr_data&.campus&.downcase) || campus_code_from_inst_role
     end
 
     def email_type
@@ -46,7 +50,7 @@ def umich_address_type
     end
 
     def job_description
-      "#{hr_data.deptDescription} (#{hr_data.deptId})"
+      "#{hr_data.deptDescription} (#{hr_data.deptId})" if hr_data
     end
 
     def hr_attribute
@@ -81,5 +85,10 @@ def hr_data
         result
       end
     end
+
+    def campus_code_from_inst_role
+      umichinstrole = @data["umichinstroles"].first { |x| inst_role_base.match?(x) }
+      Patron.inst_role_map.first { |x| x["key"] == umichinstrole }["campus"]
+    end
   end
 end

lib/patron/faculty.rb

@@ -26,6 +26,15 @@ class Faculty < Patron::Employee
       "201110" => "EM", # ASSOC PROF EMERITUS/A
       "201120" => "EM" # ASST PROF EMERITUS/A
     }
+
+    def includable?
+      !!emeritus_umich_title || super
+    end
+
+    def inst_role_base
+      "Faculty"
+    end
+
     def role
       "faculty"
     end
@@ -35,7 +44,7 @@ def user_group
     end
 
     def statistic_category
-      JOBCODE_TO_STATISTIC_CATEGORY[hr_data.jobcode] || "FA"
+      emeritus_umich_title || JOBCODE_TO_STATISTIC_CATEGORY[hr_data.jobcode] || "FA"
     end
 
     def hr_criteria(hr_item)
@@ -45,5 +54,9 @@ def hr_criteria(hr_item)
     def exclude_reason
       "no_faculty_job_category" unless includable?
     end
+
+    def emeritus_umich_title
+      "EM" if ["emeritus", "emerita"].any? { |em| /em/i.match?(@data["umichtitle"]&.first) }
+    end
   end
 end

lib/patron/sponsored_affiliate.rb

@@ -14,6 +14,10 @@ class SponsoredAffiliate < Patron::Employee
       # "Subscribers",
       "Temporary Staff"
     ]
+    def inst_role_base
+      "SponsoredAffiliate"
+    end
+
     def user_group
       "01"
     end

lib/patron/staff_person.rb

@@ -6,6 +6,10 @@ class StaffPerson < Patron::Employee
       "205800" # GRAD STU STAFF ASST
     ]
 
+    def inst_role_base
+      "RegularStaff"
+    end
+
     def role
       "staff"
     end

lib/patron/temporary_staff_person.rb

@@ -1,5 +1,9 @@
 class Patron
   class TemporaryStaffPerson < Patron::Employee
+    def inst_role_base
+      "TemporaryStaff"
+    end
+
     def user_group
       "14"
     end

spec/patron/faculty_spec.rb

@@ -18,11 +18,23 @@
       @patron["umichhr"][0].sub!("UM_ANN-ARBOR", "UM_FLINT")
       expect(subject.campus_code).to eq("UMFL")
     end
+    it "comes from first faculty matched inst role when not hr data" do
+      @patron["umichinstroles"].push("FacultyAA")
+      @patron["umichhr"] = []
+      expect(subject.campus_code).to eq("UMAA")
+    end
   end
   context "#includable?" do
     it "is true when it has a Faculty job category" do
       expect(subject.includable?).to eq(true)
     end
+    it "is true when emeritus in job title, even without job category" do
+      @patron["umichhr"] = []
+      @patron["umichtitle"] = [
+        "PROFESSOR EMERITUS OF ENGLISH, COLLEGE OF ARTS AND SCIENCES, THE UNIVERSITY OF MICHIGAN-FLINT"
+      ]
+      expect(subject.includable?).to eq(true)
+    end
     it "is false when there is no appropriate job category" do
       @patron["umichhr"][0].sub!("jobCategory=Faculty", "jobCategory=Staff")
       expect(subject.includable?).to eq(false)
@@ -42,6 +54,10 @@
     it "returns a job_description from HR data" do
       expect(subject.job_description).to eq("Library Info Tech - AIM (470430)")
     end
+    it "returns an empty string when there's no hr data" do
+      @patron["umichhr"] = []
+      expect(subject.job_description).to be_nil
+    end
   end
   context "#hr_data" do
     it "returns appropriate object for staff" do
@@ -52,11 +68,32 @@
     it "returns FA" do
       expect(subject.statistic_category).to eq("FA")
     end
-    it "handles an emeritus" do
+    it "handles an emeritus in jobcode" do
       # Professor Emeritus
       @patron["umichhr"][0].sub!("jobcode=101904", "jobcode=201070")
       expect(subject.statistic_category).to eq("EM")
     end
+    context "#emeritus in job title" do
+      it "handles Emeritus in job title" do
+        @patron["umichtitle"] = [
+          "Ruth Dow Doan Professor of Biologic Nanotechnology, Professor Emeritus of Internal Medicine, Director, MI Nanotechnology Institute, Medical School and Professor Emeritus of Biomedical Engineering, College of Engineering"
+
+        ]
+        expect(subject.statistic_category).to eq("EM")
+      end
+      it "handles Emerita" do
+        @patron["umichtitle"] = [
+          "Professor Emerita of Psychology and Professor Emerita of Asian Languages and Cultures, College of Literature, Science, and the Arts"
+        ]
+        expect(subject.statistic_category).to eq("EM")
+      end
+      it "handles all caps" do
+        @patron["umichtitle"] = [
+          "PROFESSOR EMERITUS OF ENGLISH, COLLEGE OF ARTS AND SCIENCES, THE UNIVERSITY OF MICHIGAN-FLINT"
+        ]
+        expect(subject.statistic_category).to eq("EM")
+      end
+    end
     it "handles an adjunct faculty" do
       # Adjunct Faculty
       @patron["umichhr"][0].sub!("jobcode=101904", "jobcode=201030")