Fix : NOW WORKING for the example

Author: Goneiross

src/positiveLinearCombination.js

@@ -1,18 +1,19 @@
 import { Matrix, WrapperMatrix2D, NNMF } from './index';
 
-function linearCombination(X, epsilon) {
+function linearCombination(X) {
   if (X.rows > 1) {
     X = X.transpose();
   }
   let solutions = Matrix.zeros(1, X.columns);
   let notTheEnd = true;
   let vecVal = X.get(0, X.columns - 1);
   let tmp = 0;
-  while (vecVal > epsilon && notTheEnd) {
+  while ((vecVal > 0) && notTheEnd) {
     notTheEnd = false;
-    for (let i = 0; i < X.columns; i++) {
+    for (let i = 0; i < X.columns - 1; i++) {
       tmp = vecVal - X.get(0, i);
-      if (tmp > epsilon) {
+      if (tmp >= 0 && X.get(0, i) > 0) {
+        console.table(solutions);
         solutions.set(0, i, solutions.get(0, i) + 1);
         vecVal = tmp;
         notTheEnd = true;
@@ -73,7 +74,19 @@ export function positiveLinearCombination(base, vector, options = {}) {
 
     console.table(nA.X);
 
-    solutions = linearCombination(nA.X, nA.X.min() - Number.EPSILON);
+    solutions = linearCombination(nA.X, nA.X.min() + Number.EPSILON);
     return (solutions);
   }
 }
+let base = new Matrix([
+  [0, 20, 100, 20, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0],
+  [0, 0, 0, 0, 0, 30, 100, 30, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0],
+  [0, 0, 0, 0, 0, 0, 0, 0, 0, 5, 100, 5, 0, 0, 0, 0, 0, 0],
+  [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 15, 100, 15, 0, 0, 0],
+  [0, 0, 0, 0, 0, 0, 0, 10, 100, 10, 0, 0, 0, 0, 0, 0, 0, 0],
+  [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 10, 100, 10],
+]);
+let vector = new Matrix([[0, 20, 100, 20, 0, 0, 0, 0, 0, 5, 100, 5, 0, 0, 0, 20, 200, 20]]);
+let solutions = Matrix.zeros(1, base.columns);
+
+solutions = positiveLinearCombination(base, vector);