feat(phpstan): treat no-arg method calls as accessors in OneThingPerLineRule

A method call without arguments (e.g. ->relation()) is treated like
a property access and does not count as "a thing". This allows
patterns like $item->magnaPure()->associate($x) on a single line.

Also excludes method chains inside string interpolation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: simbig

phpstan/include-by-php-version.php

@@ -8,11 +8,6 @@
     $includes[] = __DIR__ . '/../rules.neon';
 }
 
-// PHP < 8.0: exclude test fixtures using nullsafe operator syntax
-if (version_compare(PHP_VERSION, '8.0', '<')) {
-    $includes[] = __DIR__ . '/php-below-8.0.neon';
-}
-
 // PHP < 8.1: exclude enums, add ignores for older PHPStan versions
 if (version_compare(PHP_VERSION, '8.1', '<')) {
     $includes[] = __DIR__ . '/php-below-8.1.neon';

phpstan/php-below-8.1.neon

@@ -30,7 +30,6 @@ parameters:
 
     # Return type differences in older PHPStan rule interfaces
     - '#Method MLL\\Utils\\PHPStan\\Rules\\MissingClosureParameterTypehintRule::processNode\(\) should return array<int, PHPStan\\Rules\\IdentifierRuleError> but returns array<int, PHPStan\\Rules\\RuleError>\.#'
-    - '#Method MLL\\Utils\\PHPStan\\Rules\\OneThingPerLineRule::processNode\(\) should return array<int, PHPStan\\Rules\\IdentifierRuleError> but returns array<int, PHPStan\\Rules\\RuleError>\.#'
 
     # Existing code with @phpstan-ignore that older versions don't understand
     - message: '#Cannot access property \$name on SimpleXMLElement\|null\.#'

src/Flowcells/FlowcellLaneNotExistsException.php

@@ -0,0 +1,5 @@
+<?php declare(strict_types=1);
+
+namespace MLL\Utils\Flowcells;
+
+class FlowcellLaneNotExistsException extends \Exception {}

src/Flowcells/FlowcellType.php

@@ -0,0 +1,31 @@
+<?php declare(strict_types=1);
+
+namespace MLL\Utils\Flowcells;
+
+abstract class FlowcellType
+{
+    abstract public function name(): string;
+
+    abstract public function totalLaneCount(): int;
+
+    /** @var array<int, int> */
+    public array $lanes;
+
+    /** @param array<int, int>|null $lanes */
+    public function __construct(?array $lanes)
+    {
+        if ($lanes === null) {
+            $lanes = range(1, $this->totalLaneCount());
+        }
+        $this->validate($lanes);
+        $this->lanes = $lanes;
+    }
+
+    /** @param array<int, int> $specificLanes */
+    public function validate(array $specificLanes): void
+    {
+        if (count(array_intersect($specificLanes, range(1, $this->totalLaneCount()))) !== count($specificLanes)) {
+            throw new FlowcellLaneNotExistsException("Der FlowcellTyp: '{$this->name()}' besitzt keine Lane: " . implode(', ', array_diff($specificLanes, range(1, $this->totalLaneCount()))));
+        }
+    }
+}

src/Flowcells/Miseqi100_100M.php

@@ -0,0 +1,16 @@
+<?php declare(strict_types=1);
+
+namespace MLL\Utils\Flowcells;
+
+class Miseqi100_100M extends FlowcellType
+{
+    public function totalLaneCount(): int
+    {
+        return 1;
+    }
+
+    public function name(): string
+    {
+        return '100M';
+    }
+}

src/Flowcells/Miseqi100_25M.php

@@ -0,0 +1,16 @@
+<?php declare(strict_types=1);
+
+namespace MLL\Utils\Flowcells;
+
+class Miseqi100_25M extends FlowcellType
+{
+    public function totalLaneCount(): int
+    {
+        return 1;
+    }
+
+    public function name(): string
+    {
+        return '25M';
+    }
+}

src/Flowcells/Miseqi100_50M.php

@@ -0,0 +1,16 @@
+<?php declare(strict_types=1);
+
+namespace MLL\Utils\Flowcells;
+
+class Miseqi100_50M extends FlowcellType
+{
+    public function totalLaneCount(): int
+    {
+        return 1;
+    }
+
+    public function name(): string
+    {
+        return '50M';
+    }
+}

src/Flowcells/Miseqi100_5M.php

@@ -0,0 +1,16 @@
+<?php declare(strict_types=1);
+
+namespace MLL\Utils\Flowcells;
+
+class Miseqi1005M extends FlowcellType
+{
+    public function totalLaneCount(): int
+    {
+        return 1;
+    }
+
+    public function name(): string
+    {
+        return '5M';
+    }
+}

src/Flowcells/NovaSeqX10B.php

@@ -0,0 +1,16 @@
+<?php declare(strict_types=1);
+
+namespace MLL\Utils\Flowcells;
+
+class NovaSeqX10B extends FlowcellType
+{
+    public function totalLaneCount(): int
+    {
+        return 8;
+    }
+
+    public function name(): string
+    {
+        return '10B';
+    }
+}

src/Flowcells/NovaSeqX1_5B.php

@@ -0,0 +1,16 @@
+<?php declare(strict_types=1);
+
+namespace MLL\Utils\Flowcells;
+
+class NovaSeqX1_5B extends FlowcellType
+{
+    public function totalLaneCount(): int
+    {
+        return 2;
+    }
+
+    public function name(): string
+    {
+        return '1.5B';
+    }
+}