add option to quit gulp task even when using automatic webdriver snippet

[gruppjo]

The documentation reads:

The second option is to let the gulp task handle it with the built-in webdriver snippet. If you decide to start it that way, the task will keep running indefinitely.

It would be really handy to be able to quit the gulp task in any case, especially when trying to run gulp-protractor in CI environments.
What do you think?

There's another plugin out there that supports this as well: https://github.com/rochejul/gulp-angular-protractor

[mattfritz]

That seems like a useful feature... It is already supported in this plugin by pointing the seleniumServerJar config to the JAR that gets downloaded into node_modules.

Docs:

The first one is to let Protractor handle it automatically, including stopping it once your tests are done. 
To do that, simply point to the selenium jar in the protractor config file (you will need to update 
the version number accordingly) instead of the address:

  // The file path to the selenium server jar ()
  seleniumServerJar: './node_modules/protractor/selenium/selenium-server-standalone-2.45.0.jar',

Is it worth just making a config option and killing the child process? It may be valuable since version numbers change over time. Let me know what you think.

[gruppjo]

Is it worth just making a config option and killing the child process? It may be valuable since version numbers change over time. Let me know what you think.

That's what I think would be the simplest way from a user perspective. Somewhat like this:

gulp.src(["./src/tests/*.js"])
    .pipe(protractor({
        autoStop: true,
        configFile: "test/protractor.config.js",
        args: ['--baseUrl', 'http://127.0.0.1:8000']
    }))
    .on('error', function(e) { throw e })

However it's important that the process exits according to the test results. When they pass the process should finish without errors, but when there are errors, the process should throw an error.

[gruppjo]

Is there anything I can do to get this upstream faster? I really would like to use this.

[gruppjo]

Really interested in getting this to work. Please let me know what I can do to help get this functionality upstream.

[gruppjo]

Hi, this is still a major hold-back in automating our test integration. Can anybody give me anything? As I mentioned: I'm happy to contribute to make this work!

[mattfritz]

@gruppjo Please review this PR #111 to make sure I captured what you were looking for. I could use help testing, especially if you have a Windows machine to work with. Let me know if it works and I'll merge and release as soon as I can.