fix: handle list-valued options in PROPERTY_MAPPING matching (#228)

Convert list values to tuples in _process_found_property_value() before
wrapping in frozenset, preventing TypeError on unhashable list types
while preserving element order.

Closes #228

Author: TKaltofen

mloda/core/abstract_plugins/components/feature_chainer/feature_chain_parser.py

@@ -198,6 +198,8 @@ def _extract_property_values(cls, property_value: Any) -> Any:
     def _process_found_property_value(
         cls, found_property_value: Any, property_value: Any, property_name: str, original_property_config: Any
     ) -> Set[str]:
+        if isinstance(found_property_value, list):
+            found_property_value = tuple(found_property_value)
         if not isinstance(found_property_value, frozenset):
             found_property_value = frozenset([found_property_value])
 

tests/test_core/test_abstract_plugins/test_components/feature_chainer/test_feature_chain_parser_mixin.py

@@ -345,6 +345,62 @@ def test_input_features_preserves_feature_order(self) -> None:
         assert feature_names == {"first", "second", "third"}
 
 
+class TestFeatureChainParserMixinListValuedOptions:
+    """Tests for list-valued options in PROPERTY_MAPPING (issue #228)."""
+
+    def test_match_feature_group_criteria_list_valued_option(self) -> None:
+        """Test that match_feature_group_criteria works with list-valued options."""
+
+        class ListValuedFeatureGroup(FeatureChainParserMixin):
+            PROPERTY_MAPPING = {
+                "partition_by": {
+                    "explanation": "List of columns to partition by",
+                    DefaultOptionKeys.context: True,
+                    DefaultOptionKeys.strict_validation: False,
+                },
+            }
+
+        options = Options(context={"partition_by": ["region", "category"]})
+        result = ListValuedFeatureGroup.match_feature_group_criteria("my_feature", options)
+        assert result is True
+
+    def test_match_feature_group_criteria_tuple_valued_option(self) -> None:
+        """Test that match_feature_group_criteria works with tuple-valued options."""
+
+        class TupleValuedFeatureGroup(FeatureChainParserMixin):
+            PROPERTY_MAPPING = {
+                "partition_by": {
+                    "explanation": "Columns to partition by",
+                    DefaultOptionKeys.context: True,
+                    DefaultOptionKeys.strict_validation: False,
+                },
+            }
+
+        options = Options(context={"partition_by": ("region", "category")})
+        result = TupleValuedFeatureGroup.match_feature_group_criteria("my_feature", options)
+        assert result is True
+
+    def test_list_valued_option_preserves_order(self) -> None:
+        """Test that list-valued options preserve element order through tuple conversion."""
+        from mloda.core.abstract_plugins.components.feature_chainer.feature_chain_parser import FeatureChainParser
+
+        property_mapping = {
+            "partition_by": {
+                DefaultOptionKeys.context: True,
+                DefaultOptionKeys.strict_validation: False,
+            },
+        }
+        options = Options(context={"partition_by": ["col1", "col2", "col3"]})
+        result = FeatureChainParser._validate_options_against_property_mapping(options, property_mapping)
+        assert result is True
+
+    def test_scalar_option_still_works(self) -> None:
+        """Test that scalar (non-list) options still work after the fix."""
+        options = Options(context={"operation": "op1"})
+        result = MockFeatureGroup.match_feature_group_criteria("my_feature", options)
+        assert result is True
+
+
 class TestFeatureChainParserMixinExtractSourceFeatures:
     """Tests for _extract_source_features() classmethod."""