Skip to content

Commit 4b7ef5c

Browse files
committed
don't call classiFunc:: within makeParamSet() -> triggers rev dep failures
1 parent cc80af0 commit 4b7ef5c

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

R/RLearner_classif_classiFunc.kernel.R

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,14 @@ makeRLearner.classif.classiFunc.kernel = function() {
77
makeNumericLearnerParam(id = "h",
88
lower = 0, upper = Inf,
99
default = 1),
10-
# Using metricChoices since there are so many options and this
10+
# Using metricChoices since there are so many options and this
1111
# keeps stuff flexible.
12+
# metric.choices: defined in helpers_fda.R
1213
makeDiscreteLearnerParam(id = "metric", default = "Euclidean",
13-
values = classiFunc::metricChoices()),
14+
values = metric.choices),
15+
# kernel.choices: defined in helpers_fda.R
1416
makeDiscreteLearnerParam(id = "ker", default = "Ker.norm",
15-
values = classiFunc::kerChoices()),
17+
values = kernel.choices),
1618
makeIntegerLearnerParam(id = "nderiv", default = 0L, lower = 0L),
1719
makeLogicalLearnerParam(id = "derived", default = FALSE, tunable = FALSE),
1820
makeDiscreteLearnerParam(id = "deriv.method", default = "base.diff",

R/RLearner_classif_classiFunc.knn.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ makeRLearner.classif.classiFunc.knn = function() {
55
package = "classiFunc",
66
par.set = makeParamSet(
77
makeIntegerLearnerParam(id = "knn", lower = 1L, default = 1L),
8-
# Using metricChoices since there are so many options and this
8+
# Using metricChoices since there are so many options and this
99
# keeps stuff flexible.
1010
makeDiscreteLearnerParam(id = "metric", default = "Euclidean",
11-
values = classiFunc::metricChoices()),
11+
values = metric.choices),
1212
makeIntegerLearnerParam(id = "q?", default = 0L, lower = 0L),
1313
makeIntegerLearnerParam(id = "nderiv", default = 0L, lower = 0L),
1414
makeLogicalLearnerParam(id = "derived", default = FALSE, tunable = FALSE),

R/helpers_fda.R

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,3 +43,6 @@ checkFDCols = function(data, col) {
4343
assertNumeric(data)
4444
return(data)
4545
}
46+
47+
metric.choices = classiFunc::metricChoices()
48+
kernel.choices = classiFunc::kerChoices()

0 commit comments

Comments
 (0)