perf: use attr() instead of attributes() for extracting single attribute (#1409)

m-muecke · web-flow · commit 28de4c7a0877 · 2025-11-20T18:19:19.000+01:00
diff --git a/R/as_task_classif.R b/R/as_task_classif.R
@@ -92,7 +92,7 @@ as_task_classif.formula = function(x, data, id = deparse1(substitute(data)), pos
   assert_data_frame(data)
   assert_subset(all.vars(x), c(names(data), "."), .var.name = "formula")
 
-  if (!attributes(terms(x, data = data))$response) {
+  if (!attr(terms(x, data = data), "response")) {
     stopf("Formula %s is missing a response", format(x))
   }
   tab = model.frame(x, data, na.action = "na.pass")
diff --git a/R/as_task_regr.R b/R/as_task_regr.R
@@ -85,7 +85,7 @@ as_task_regr.formula = function(x, data, id = deparse1(substitute(data)), label
   assert_data_frame(data)
   assert_subset(all.vars(x), c(names(data), "."), .var.name = "formula")
 
-  if (!attributes(terms(x, data = data))$response) {
+  if (!attr(terms(x, data = data), "response")) {
     stopf("Formula %s is missing a response", format(x))
   }
   tab = model.frame(x, data, na.action = "na.pass")

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ as_task_classif.formula = function(x, data, id = deparse1(substitute(data)), pos`
`92`	`92`	`assert_data_frame(data)`
`93`	`93`	`assert_subset(all.vars(x), c(names(data), "."), .var.name = "formula")`
`94`	`94`
`95`		`- if (!attributes(terms(x, data = data))$response) {`
	`95`	`+ if (!attr(terms(x, data = data), "response")) {`
`96`	`96`	`stopf("Formula %s is missing a response", format(x))`
`97`	`97`	`}`
`98`	`98`	`tab = model.frame(x, data, na.action = "na.pass")`
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ as_task_regr.formula = function(x, data, id = deparse1(substitute(data)), label`
`85`	`85`	`assert_data_frame(data)`
`86`	`86`	`assert_subset(all.vars(x), c(names(data), "."), .var.name = "formula")`
`87`	`87`
`88`		`- if (!attributes(terms(x, data = data))$response) {`
	`88`	`+ if (!attr(terms(x, data = data), "response")) {`
`89`	`89`	`stopf("Formula %s is missing a response", format(x))`
`90`	`90`	`}`
`91`	`91`	`tab = model.frame(x, data, na.action = "na.pass")`