Skip to content

Commit b6c3a53

Browse files
authored
remove warnings in preprocessing chapter (#893)
1 parent 4150565 commit b6c3a53

File tree

1 file changed

+0
-17
lines changed

1 file changed

+0
-17
lines changed

book/chapters/chapter9/preprocessing.qmd

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -236,17 +236,9 @@ invisible(dev.off())
236236
magick::image_trim(fig)
237237
```
238238

239-
::: {.callout-warning}
240-
241-
Currently, there is a bug in the mlr3pipelines package that causes the following code chunk to fail.
242-
See https://github.com/mlr-org/mlr3pipelines/issues/894 for more details.
243-
244-
:::
245-
246239
Using this pipeline we can now run experiments with `lrn("regr.ranger")`, which cannot handle missing data; we also compare a simpler pipeline that only uses OOR imputation to demonstrate performance differences resulting from different strategies.
247240

248241
```{r preprocessing-015}
249-
#| eval: false
250242
glrn_rf_impute_hist = as_learner(impute_hist %>>% lrn("regr.ranger"))
251243
glrn_rf_impute_hist$id = "RF_imp_Hist"
252244
@@ -450,19 +442,10 @@ tsk_ames_ext$data(1,
450442
c("energy_means", "energy_mins", "energy_maxs", "energy_vars"))
451443
```
452444

453-
::: {.callout-warning}
454-
455-
This code chunk does not work due to the bug in the `mlr3pipelines` package.
456-
See the warning message above for more details.
457-
458-
:::
459-
460-
461445
These outputs look sensible compared to @fig-energy so we can now run our final benchmark experiment using feature extraction.
462446
We do not need to add the `PipeOp` to each learner as we can apply it once (as above) before any model training by applying it to all available data.
463447

464448
```{r preprocessing-026, warning=FALSE, R.options = list(datatable.print.nrows = 13, datatable.print.class = FALSE, datatable.print.keys = FALSE, datatable.print.trunc.cols = TRUE)}
465-
#| eval: false
466449
learners = list(lrn_baseline, lrn("regr.rpart"), glrn_xgb_impact,
467450
glrn_rf_impute_oor, glrn_lm_robust, glrn_log_lm_robust)
468451

0 commit comments

Comments
 (0)