Skip to content

Commit c3d1927

Browse files
committed
chore: update dev-cmd-check.yml
test: fix for mlr3pipelines 0.9 chore: update NEWS.md
1 parent ebea192 commit c3d1927

File tree

4 files changed

+22
-15
lines changed

4 files changed

+22
-15
lines changed

.github/workflows/dev-cmd-check.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ jobs:
3636
- {os: ubuntu-latest, r: 'release', dev-package: 'mlr-org/mlr3misc'}
3737
- {os: ubuntu-latest, r: 'release', dev-package: 'mlr-org/mlr3tuning'}
3838
- {os: ubuntu-latest, r: 'release', dev-package: 'mlr-org/paradox'}
39+
- {os: ubuntu-latest, r: 'release', dev-package: 'mlr-org/mlr3pipelines'}
3940

4041
steps:
4142
- uses: actions/checkout@v3

DESCRIPTION

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ Package: mlr3mbo
33
Title: Flexible Bayesian Optimization
44
Version: 0.3.0.9000
55
Authors@R: c(
6-
person("Lennart", "Schneider", , "[email protected]", role = c("cre", "aut"),
6+
person("Marc", "Becker", , "[email protected]", role = c("cre", "aut"),
7+
comment = c(ORCID = "0000-0002-8115-0400")),
8+
person("Lennart", "Schneider", , "[email protected]", role = "aut",
79
comment = c(ORCID = "0000-0003-4152-5308")),
810
person("Jakob", "Richter", , "[email protected]", role = "aut",
911
comment = c(ORCID = "0000-0003-4481-5554")),
10-
person("Marc", "Becker", , "[email protected]", role = "aut",
11-
comment = c(ORCID = "0000-0002-8115-0400")),
1212
person("Michel", "Lang", , "[email protected]", role = "aut",
1313
comment = c(ORCID = "0000-0001-9754-0393")),
1414
person("Bernd", "Bischl", , "[email protected]", role = "aut",

NEWS.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# mlr3mbo (development version)
22

3+
* chore: maintainer change.
4+
* chore: work with new mlr3pipelines version 0.9.0 (fix for tests only).
5+
* test: `expect_rush_reset` changes related to rush developments.
6+
* fix: allow `InputTrafoUnitcube` to work in mixed spaces.
7+
38
# mlr3mbo 0.3.0
49

510
* fix: logger changes related to bbotk.

tests/testthat/test_mbo_defaults.R

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -85,18 +85,19 @@ test_that("default_surrogate", {
8585
expect_r6(surrogate, "SurrogateLearner")
8686
expect_r6(surrogate$learner, "GraphLearner")
8787
expect_equal(surrogate$learner$graph$ids(), c("imputesample", "imputeoor", "colapply", "regr.ranger"))
88-
expect_equal_sorted(surrogate$learner$param_set$values,
89-
list(imputesample.affect_columns = mlr3pipelines::selector_type("logical"),
90-
imputeoor.min = TRUE,
91-
imputeoor.offset = 1,
92-
imputeoor.multiplier = 3,
93-
imputeoor.affect_columns = mlr3pipelines::selector_type(c("integer", "numeric", "character", "factor", "ordered")),
94-
colapply.applicator = as.factor,
95-
colapply.affect_columns = mlr3pipelines::selector_type("character"),
96-
regr.ranger.num.threads = 1L,
97-
regr.ranger.num.trees = 100L,
98-
regr.ranger.keep.inbag = TRUE,
99-
regr.ranger.se.method = "jack"))
88+
list_expected = list(imputesample.affect_columns = mlr3pipelines::selector_type("logical"),
89+
imputeoor.min = TRUE,
90+
imputeoor.offset = 1,
91+
imputeoor.multiplier = 3,
92+
imputeoor.affect_columns = mlr3pipelines::selector_type(c("integer", "numeric", "character", "factor", "ordered")),
93+
colapply.applicator = as.factor,
94+
colapply.affect_columns = mlr3pipelines::selector_type("character"),
95+
regr.ranger.num.threads = 1L,
96+
regr.ranger.num.trees = 100L,
97+
regr.ranger.keep.inbag = TRUE,
98+
regr.ranger.se.method = "jack")
99+
expect_equal_sorted(surrogate$learner$param_set$values[names(list_expected)], list_expected)
100+
100101
expect_r6(surrogate$learner$fallback, "LearnerRegrFeatureless")
101102

102103
# specify own learner, specify n_objectives, twocrit all numeric, deterministic

0 commit comments

Comments
 (0)