some more fixes

Author: sebffischer

R/GraphLearner.R

@@ -246,7 +246,7 @@ GraphLearner = R6Class("GraphLearner", inherit = Learner,
     .extract_internal_valid_scores = function() {
       if (!private$.can_internal_tuning) return(NULL)
       ivs = unlist(map(pos_with_property(self$graph_model, "validation"), "internal_valid_scores"), recursive = FALSE)
-      if (is.null(ivs) || !length(ivs)) return(named_list())
+      if (!length(ivs)) return(named_list())
       ivs
     },
     deep_clone = function(name, value) {
@@ -349,21 +349,27 @@ GraphLearner = R6Class("GraphLearner", inherit = Learner,
 #' @export
 #' @examples
 #' library(mlr3)
-#' # simple
+#'
 #' glrn = as_learner(po("pca") %>>% lrn("classif.debug"))
 #' set_validate(glrn, 0.3)
 #' glrn$validate
 #' glrn$graph$pipeops$classif.debug$learner$validate
+#'
 #' set_validate(glrn, NULL)
 #' glrn$validate
 #' glrn$graph$pipeops$classif.debug$learner$validate
+#'
+#' set_validate(glrn, 0.2, ids = "classif.debug")
+#' glrn$validate
+#' glrn$graph$pipeops$classif.debug$learner$validate
 set_validate.GraphLearner = function(learner, validate, ids = NULL, args_all = list(), args = list(), ...) {
   prev_validate_pos = map(pos_with_property(learner$graph$pipeops, "validation"), "validate")
   prev_validate = learner$validate
   on.exit({
     iwalk(prev_validate_pos, function(prev_val, poid) {
       # Here we don't call into set_validate() as this also does not ensure that we are able to correctly
-      # reset the configuration to the previous state and is less transparent
+      # reset the configuration to the previous state, is less transparent and might fail again
+      # The error message informs the user about this though via the calling handlers below
       learner$graph$pipeops[[poid]]$validate = prev_val
     })
     learner$validate = prev_validate
@@ -379,7 +385,7 @@ set_validate.GraphLearner = function(learner, validate, ids = NULL, args_all = l
   }
 
   if (is.null(ids)) {
-    ids = learner$base_learner(recursive = 1, return_po = TRUE)$id
+    ids = learner$base_learner(return_po = TRUE)$id
   } else {
     assert_subset(ids, ids(pos_with_property(learner$graph$pipeops, "validation")))
   }

R/PipeOpLearner.R

@@ -70,9 +70,9 @@
 #'    For each `PipeOp` it is then only possible to either use it (`"predefined"`) or not use it (`NULL`).
 #'    Also see [`set_validate.GraphLearner`] for more information.
 #' * `internal_tuned_values` :: named `list()` or `NULL`\cr
-#'    The internally tuned values if the wrapped `Learner`s supports internal tuning, `NULL` otherwise.
+#'    The internally tuned values if the wrapped `Learner` supports internal tuning, `NULL` otherwise.
 #' * `internal_valid_scores` :: named `list()` or `NULL`\cr
-#'    The internal validation scores if the wrapped `Learner`s supports internal validation, `NULL` otherwise.
+#'    The internal validation scores if the wrapped `Learner` supports internal validation, `NULL` otherwise.
 #' @section Methods:
 #' Methods inherited from [`PipeOp`].
 #'
@@ -210,7 +210,7 @@ mlr_pipeops$add("learner", PipeOpLearner, list(R6Class("Learner", public = list(
 set_validate.PipeOpLearner = function(learner, validate, ...) {
   assert_po_validate(validate)
   on.exit({
-    # also does not work in general (e.g. for AutoTuner) and is even less transparent
+    # don't use set_validate(), as it also does not work in general and might fail again
     learner$validate = prev_validate
   })
   prev_validate = learner$validate

R/utils.R

@@ -135,18 +135,6 @@ dictionary_sugar_inc_mget = function(dict, .keys, ...) {
   objs
 }
 
-learner_wrapping_pipeops = function(x) {
-  if (inherits(x, "Graph")) {
-    x = x$pipeops
-  } else if (inherits(x, "GraphLearner")) {
-    x = x$graph$pipeops
-  } else {
-    assert_list(x, types = "PipeOp")
-  }
-
-  keep(x, function(po) inherits(po, "PipeOpLearner") || inherits(po, "PipeOpLearnerCV"))
-}
-
 pos_with_property = function(x, property) {
   x = if (test_class(x, "GraphLearner")) {
     x$graph$pipeops