fix: adamw

sebffischer · sebffischer · commit 84b5fcb83dc7 · 2025-09-18T09:11:38.000+02:00
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,9 @@
 # mlr3torch (development version)
 
+## Bug Fixes
+
+* `t_opt("adamw")` now actually uses AdamW and not Adam.
+
 # mlr3torch 0.3.1
 
 ## Bug Fixes
diff --git a/R/TorchOptimizer.R b/R/TorchOptimizer.R
@@ -258,9 +258,9 @@ mlr3torch_optimizers$add("adamw",
       amsgrad      = p_lgl(default = FALSE, tags = "train")
     )
     TorchOptimizer$new(
-      torch_optimizer = torch::optim_ignite_adam,
+      torch_optimizer = torch::optim_ignite_adamw,
       param_set = p,
-      id = "adam",
+      id = "adamw",
       label = "Decoupled Weight Decay Regularization",
       man = "torch::optim_ignite_adamw"
     )

Original file line number	Diff line number	Diff line change
`@@ -258,9 +258,9 @@ mlr3torch_optimizers$add("adamw",`
`258`	`258`	`amsgrad = p_lgl(default = FALSE, tags = "train")`
`259`	`259`	`)`
`260`	`260`	`TorchOptimizer$new(`
`261`		`- torch_optimizer = torch::optim_ignite_adam,`
	`261`	`+ torch_optimizer = torch::optim_ignite_adamw,`
`262`	`262`	`param_set = p,`
`263`		`- id = "adam",`
	`263`	`+ id = "adamw",`
`264`	`264`	`label = "Decoupled Weight Decay Regularization",`
`265`	`265`	`man = "torch::optim_ignite_adamw"`
`266`	`266`	`)`