fix setMBOControlTermination argument check (Fixes #245)

Author: jakob-r

R/setMBOControlTermination.R

@@ -61,7 +61,7 @@ setMBOControlTermination = function(control,
 
   stop.conds = more.stop.conds
 
-  if (is.null(iters) && is.null(time.budget) && is.null(exec.time.budget) && length(stop.conds) == 0L) {
+  if (is.null(iters) && is.null(time.budget) && is.null(exec.time.budget) && is.null(max.evals) && length(stop.conds) == 0L) {
     stopf("You need to specify a maximal number of iteration, a time budget or at least
       one custom stopping condition, but you provided neither.")
   }

tests/testthat/test_stopping_criteria.R

@@ -14,7 +14,7 @@ test_that("stopping criteria works", {
 
   # time budget
   ctrl = makeMBOControl()
-  ctrl = setMBOControlTermination(ctrl, iters = iters, time.budget = time.budget)
+  ctrl = setMBOControlTermination(ctrl, time.budget = time.budget)
   or = mbo(f, design = design, learner = learner, control = ctrl)
 
   expect_equal(or$final.state, "term.time")
@@ -25,11 +25,11 @@ test_that("stopping criteria works", {
   or = mbo(f, design = design, learner = learner, control = ctrl)
 
   expect_equal(or$final.state, "term.yval")
-  expect_less_than(or$y, target.fun.value)
+  expect_lt(or$y, target.fun.value)
 
   # maximal number of target function evaluations
   ctrl = makeMBOControl()
-  ctrl = setMBOControlTermination(ctrl, iters = iters, max.evals = max.evals)
+  ctrl = setMBOControlTermination(ctrl, max.evals = max.evals)
   or = mbo(f, design = design, learner = learner, control = ctrl)
 
   expect_equal(or$final.state, "term.feval")