Skip to content

Commit c3d6ffe

Browse files
committed
use getParamSet generic (should resolve to PH in to future)
1 parent 88729d8 commit c3d6ffe

File tree

5 files changed

+6
-5
lines changed

5 files changed

+6
-5
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ env:
1010
r_github_packages:
1111
- jakobbossek/smoof
1212
- mlr-org/mlr
13+
- berndbischl/ParamHelpers
1314

1415
notifications:
1516
email:

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ BugReports: https://github.com/berndbischl/mlrMBO/issues
1616
Depends:
1717
lhs,
1818
mlr (>= 2.7),
19-
ParamHelpers (>= 1.4),
19+
ParamHelpers (>= 1.8),
2020
smoof (>= 1.3)
2121
Imports:
2222
BBmisc (>= 1.7),

R/exampleRun.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ exampleRun = function(fun, design = NULL, learner = NULL, control,
3434
points.per.dim = 50, noisy.evals = 10, show.info = NULL) {
3535

3636
assertClass(fun, "smoof_single_objective_function")
37-
par.set = smoof::getParamSet(fun)
37+
par.set = getParamSet(fun)
3838
par.types = getParamTypes(par.set)
3939
n.params = sum(getParamLengths(par.set))
4040
noisy = isNoisy(fun)

R/exampleRunMultiCrit.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ exampleRunMultiCrit= function(fun, design = NULL, learner, control, points.per.d
2828
show.info = NULL, nsga2.args = list(), ...) {
2929

3030
assertClass(fun, "smoof_multi_objective_function")
31-
par.set = smoof::getParamSet(fun)
31+
par.set = getParamSet(fun)
3232
par.types = getParamTypes(par.set)
3333
n.params = sum(getParamLengths(par.set))
3434
if (is.null(design))

R/mbo.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
#' @return [\code{\link{MBOSingleObjResult}} | \code{\link{MBOMultiObjResult}}]
2929
#' @examples
3030
#' obj.fun = makeSingleObjectiveFunction(
31-
#' fn = function(x) x[1]^2 + sin(x[2]),
31+
#' fn = function(x) x[1]^2 + sin(x[2]),
3232
#' par.set = makeNumericParamSet(id = "x", lower = -1, upper = 1, len = 2))
3333
#' ctrl = makeMBOControl()
3434
#' ctrl = setMBOControlTermination(ctrl, iters = 3L)
@@ -41,7 +41,7 @@ mbo = function(fun, design = NULL, learner = NULL, control,
4141
show.info = getOption("mlrMBO.show.info", TRUE), more.args = list()) {
4242

4343
assertClass(fun, "smoof_function")
44-
par.set = smoof::getParamSet(fun)
44+
par.set = getParamSet(fun)
4545
n.params = sum(getParamLengths(par.set))
4646
control$noisy = isNoisy(fun)
4747
control$minimize = shouldBeMinimized(fun)

0 commit comments

Comments
 (0)