[S3] Automount s3 credential secret rather than inline keys (#262)

Author: liranbg

.github/workflows/ci.yaml

@@ -25,7 +25,7 @@ jobs:
           python-version: "3.x"
           check-latest: true
       - name: Set up chart-testing
-        uses: helm/chart-testing-action@e6669bcd63d7cb57cb4380c33043eebe5d111992 #v2.6.1
+        uses: helm/chart-testing-action@6ec842c01de15ebb84c8627d2744a0c2f2755c9f #v2.8.0
         with:
           version: v3.10.1
       - name: Run chart-testing (list-changed)

charts/mlrun-ce/Chart.yaml

@@ -1,6 +1,6 @@
 apiVersion: v1
 name: mlrun-ce
-version: 0.11.0-rc9
+version: 0.11.0-rc.10
 description: MLRun Open Source Stack
 home: https://iguazio.com
 icon: https://www.iguazio.com/wp-content/uploads/2019/10/Iguazio-Logo.png

charts/mlrun-ce/templates/_helpers.tpl

@@ -191,7 +191,7 @@ Uses SeaweedFS as the storage backend
   {{- if hasKey .Values.mlrun "storageAutoMountParams" -}}
     {{ .Values.mlrun.storageAutoMountParams }}
   {{- else if not .Values.global.infrastructure.aws.s3NonAnonymous -}}
-    "aws_access_key={{ include "mlrun-ce.s3.accessKey" . }},aws_secret_key={{ include "mlrun-ce.s3.secretKey" . }},endpoint_url={{ include "mlrun-ce.s3.service.url" . }}"
+    "secret_name=s3-credentials,endpoint_url={{ include "mlrun-ce.s3.service.url" . }}"
   {{- else -}}
     "non_anonymous=True"
   {{- end -}}

charts/mlrun-ce/templates/config/jupyter-env-configmap.yaml

@@ -6,7 +6,7 @@ metadata:
   name: jupyter-common-env
 data:
   # S3 credentials (AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_ENDPOINT_URL_S3)
-  # are now loaded from the 's3-credentials' Secret via envFrom secretRef
+  # are loaded from the 's3-credentials' Secret
   MLRUN_STORAGE__AUTO_MOUNT_TYPE: {{ default "" .Values.mlrun.storageAutoMountType }}
   S3_NON_ANONYMOUS: {{ .Values.global.infrastructure.aws.s3NonAnonymous  | toString | title | quote | default "\"True\"" }}
   MLRUN_CE__MODE: {{ .Values.jupyterNotebook.ce.mode | default "full" }}

charts/mlrun-ce/templates/config/mlrun-env-configmap.yaml

@@ -12,7 +12,7 @@ data:
   MLRUN_HTTPDB__PROJECTS__LEADER: mlrun
   MLRUN_HTTPDB__PROJECTS__FOLLOWERS: nuclio
   # S3 credentials (AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_ENDPOINT_URL_S3)
-  # are now loaded from the 's3-credentials' Secret via envFrom secretRef
+  # are loaded from the 's3-credentials' Secret
   MLRUN_FUNCTION__SPEC__SERVICE_ACCOUNT__DEFAULT: {{ .Values.mlrun.api.functionSpecServiceAccountDefault | default "" | quote }}
   MLRUN_HTTPDB__REAL_PATH: s3://
   MLRUN_ARTIFACT_PATH: s3://{{ $bucket_name }}/projects/{{ `{{run.project}}` }}/artifacts