Fix converting 10-bit full to limited range

Without Movit, 10-bit full range was not able to convert to limited
range. This regressed in 7752c68 in order to accomodate 10-bit pass-
through editing (no processing). Now, it returns by going through RGB to
do the conversion but only when the consumer does not request 10-bit.
However, that still leaves a gap: 10-bit full to 10-bit limited or visa
versa. In that case, you must either set the consumer color_range same
as source, or specify mlt_image_rgb(a).

With Movit, 10-bit range conversion works even when the consumer
requests 10-bit Y'CbCr.

Author: ddennedy

src/modules/avformat/common.c

@@ -1,6 +1,6 @@
 /*
  * common.h
- * Copyright (C) 2018-2024 Meltytech, LLC
+ * Copyright (C) 2018-2025 Meltytech, LLC
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ -253,14 +253,6 @@ int mlt_set_luma_transfer(struct SwsContext *context,
     int src_range = src_full_range ? 1 : 0;
     int dst_range = dst_full_range ? 1 : 0;
 
-    sws_getColorspaceDetails(context,
-                             (int **) &src_coefficients,
-                             &src_range,
-                             (int **) &dst_coefficients,
-                             &dst_range,
-                             &brightness,
-                             &contrast,
-                             &saturation);
     switch (src_colorspace) {
     case 170:
     case 470:

src/modules/avformat/producer_avformat.c

@@ -1937,12 +1937,14 @@ static int convert_image(producer_avformat self,
     mlt_log_timings_begin();
 
     mlt_log_debug(MLT_PRODUCER_SERVICE(self->parent),
-                  "%s @ %dx%d space %d->%d\n",
+                  "%s @ %dx%d colorspace %d->%d range %d->%d\n",
                   mlt_image_format_name(*format),
                   width,
                   height,
                   self->yuv_colorspace,
-                  profile->colorspace);
+                  profile->colorspace,
+                  self->full_range,
+                  dst_full_range);
 
     // extract alpha from planar formats - only supports 8-bit
     if ((pix_fmt == AV_PIX_FMT_YUVA420P || pix_fmt == AV_PIX_FMT_YUVA422P
@@ -2227,10 +2229,17 @@ static int producer_get_image(mlt_frame frame,
     const char *dst_color_range = mlt_properties_get(frame_properties, "consumer.color_range");
     int dst_full_range = mlt_image_full_range(dst_color_range);
 
-    // if depth > 8 libswscale only changes range when scaling, not simple pix_fmt conversion
+    // if 10-bit libswscale only changes range when scaling, not simple pix_fmt conversion
     const struct AVPixFmtDescriptor *pix_desc = av_pix_fmt_desc_get(self->video_codec->pix_fmt);
-    if (pix_desc && pix_desc->nb_components > 0 && pix_desc->comp[0].depth > 8)
-        dst_full_range = self->full_range;
+    if (dst_full_range != self->full_range && pix_desc && pix_desc->nb_components > 0
+        && pix_desc->comp[0].depth == 10) {
+        if (*format == mlt_image_yuv420p10 || *format == mlt_image_yuv444p10)
+            // When the consumer requests 10-bit do not convert
+            dst_full_range = self->full_range;
+        else
+            // Otherwise, convert via RGB
+            *format = mlt_image_rgb;
+    }
 
     mlt_service_lock(MLT_PRODUCER_SERVICE(producer));
     pthread_mutex_lock(&self->video_mutex);

src/modules/movit/filter_movit_convert.cpp

@@ -375,13 +375,17 @@ static void finalize_movit_chain(mlt_service leaf_service, mlt_frame frame, mlt_
 
         ImageFormat output_format;
         if (format == mlt_image_yuv444p10 || format == mlt_image_yuv420p10) {
+            auto properties = MLT_FRAME_PROPERTIES(frame);
             YCbCrFormat ycbcr_format = {};
-            get_format_from_properties(MLT_FRAME_PROPERTIES(frame), &output_format, &ycbcr_format);
-            output_format.gamma_curve = std::max(GAMMA_REC_709,
-                                                 getOutputGamma(MLT_FRAME_PROPERTIES(frame)));
+            get_format_from_properties(properties, &output_format, &ycbcr_format);
+            output_format.gamma_curve = std::max(GAMMA_REC_709, getOutputGamma(properties));
+            ycbcr_format.full_range = mlt_image_full_range(
+                mlt_properties_get(properties, "consumer.color_range"));
             mlt_log_debug(nullptr,
-                          "[filter movit.convert] output gamma %d\n",
-                          output_format.gamma_curve);
+                            "[filter movit.convert] output gamma %d full-range %d\n",
+                            output_format.gamma_curve,
+                            ycbcr_format.full_range);
+            mlt_properties_set_int(properties, "full_range", ycbcr_format.full_range);
             ycbcr_format.num_levels = 1024;
             ycbcr_format.chroma_subsampling_x = ycbcr_format.chroma_subsampling_y = 1;
             chain->effect_chain->add_ycbcr_output(output_format,
@@ -404,6 +408,13 @@ static void finalize_movit_chain(mlt_service leaf_service, mlt_frame frame, mlt_
     } else {
         // Delete all the created Effect instances to avoid memory leaks.
         dispose_movit_effects(leaf_service, frame);
+
+        auto properties = MLT_FRAME_PROPERTIES(frame);
+        getOutputGamma(properties);
+        mlt_properties_set_int(properties,
+                               "full_range",
+                               mlt_image_full_range(
+                                   mlt_properties_get(properties, "consumer.color_range")));
     }
 }