Enable and fix multiple modules with MSVC (#1194)

* Enable and fix avformat module with MSVC

* Enable and fix qt6 module with MSVC

* Enable and fix xml module with MSVC

* Enable and fix mlt plus module with MSVC

* Enable and fix kdenlive module with MSVC

* Enable and fix gdk module with MSVC

* Enable and fix normalize module with MSVC

* Enable and fix oldfilm module with MSVC

* Enable rubberband module with MSVC

* Enable and fix vorbis module with MSVC

Author: jlskuz

CMakePresets.json

@@ -10,33 +10,33 @@
             "cacheVariables": {
                 "BUILD_TESTING": "OFF",
                 "SWIG_PYTHON": "OFF",
-                "MOD_AVFORMAT": "OFF",
+                "MOD_AVFORMAT": "ON",
                 "MOD_DECKLINK": "OFF",
                 "MOD_FREI0R": "OFF",
-                "MOD_GDK": "OFF",
+                "MOD_GDK": "ON",
                 "MOD_JACKRACK": "OFF",
                 "USE_LV2": "OFF",
                 "USE_VST2": "OFF",
-                "MOD_KDENLIVE": "OFF",
+                "MOD_KDENLIVE": "ON",
                 "MOD_NDI": "OFF",
-                "MOD_NORMALIZE": "OFF",
-                "MOD_OLDFILM": "OFF",
+                "MOD_NORMALIZE": "ON",
+                "MOD_OLDFILM": "ON",
                 "MOD_OPENCV": "OFF",
                 "MOD_MOVIT": "OFF",
-                "MOD_PLUS": "OFF",
+                "MOD_PLUS": "ON",
                 "MOD_PLUSGPL": "OFF",
-                "MOD_QT6": "OFF",
+                "MOD_QT6": "ON",
                 "MOD_SOX": "OFF",
                 "MOD_GLAXNIMATE_QT6": "OFF",
                 "MOD_RESAMPLE": "OFF",
                 "MOD_RTAUDIO": "OFF",
-                "MOD_RUBBERBAND": "OFF",
+                "MOD_RUBBERBAND": "ON",
                 "MOD_SDL2": "ON",
                 "MOD_DOX": "OFF",
                 "MOD_VIDSTAB": "OFF",
-                "MOD_VORBIS": "OFF",
+                "MOD_VORBIS": "ON",
                 "MOD_XINE": "OFF",
-                "MOD_XML": "OFF"
+                "MOD_XML": "ON"
             }
         },
         {

src/modules/avformat/CMakeLists.txt

@@ -39,7 +39,7 @@ target_link_libraries(mltavformat PRIVATE
 )
 
 if(MSVC)
-  target_link_libraries(mltavformat PRIVATE PThreads4W::PThreads4W)
+  target_link_libraries(mltavformat PRIVATE PThreads4W::PThreads4W msvccompat)
 else()
    target_link_libraries(mltavformat PRIVATE m)
 endif()

src/modules/avformat/consumer_avformat.c

@@ -31,9 +31,14 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-#include <sys/time.h>
 #include <time.h>
+
+#ifdef _MSC_VER
+#include <gettimeofday.h>
+#else
+#include <sys/time.h>
 #include <unistd.h>
+#endif
 
 // avformat header files
 #include <libavcodec/avcodec.h>

src/modules/gdk/CMakeLists.txt

@@ -16,7 +16,9 @@ target_compile_options(mltgdk PRIVATE ${MLT_COMPILE_OPTIONS})
 target_include_directories(mltgdk PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
 
 target_link_libraries(mltgdk PRIVATE mlt Threads::Threads PkgConfig::GdkPixbuf)
-if(NOT MSVC)
+if(MSVC)
+  target_link_libraries(mltgdk PRIVATE PThreads4W::PThreads4W)
+else()
   target_link_libraries(mltgdk PRIVATE m)
 endif()
 

src/modules/gdk/producer_pixbuf.c

@@ -37,7 +37,19 @@
 #include <string.h>
 #include <sys/stat.h>
 #include <sys/types.h>
+
+#ifndef _MSC_VER
 #include <unistd.h>
+#endif
+
+#ifndef ssize_t
+#ifdef _WIN32
+#include <BaseTsd.h>
+#define ssize_t SSIZE_T
+#else
+#define ssize_t ptrdiff_t
+#endif
+#endif
 
 // this protects concurrent access to gdk_pixbuf
 static pthread_mutex_t g_mutex = PTHREAD_MUTEX_INITIALIZER;

src/modules/kdenlive/CMakeLists.txt

@@ -15,7 +15,9 @@ generate_export_header(mltkdenlive)
 target_compile_options(mltkdenlive PRIVATE ${MLT_COMPILE_OPTIONS})
 target_include_directories(mltkdenlive PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
 target_link_libraries(mltkdenlive PRIVATE mlt)
-if(NOT MSVC)
+if(MSVC)
+  target_link_libraries(mltkdenlive PRIVATE PThreads4W::PThreads4W)
+else()
   target_link_libraries(mltkdenlive PRIVATE m)
 endif()
 

src/modules/kdenlive/producer_framebuffer.c

@@ -26,7 +26,10 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+
+#ifndef _MSC_VER
 #include <sys/time.h>
+#endif
 
 // Forward references.
 static int producer_get_frame(mlt_producer producer, mlt_frame_ptr frame, int index);

src/modules/normalize/CMakeLists.txt

@@ -13,7 +13,9 @@ generate_export_header(mltnormalize)
 target_compile_options(mltnormalize PRIVATE ${MLT_COMPILE_OPTIONS})
 target_include_directories(mltnormalize PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
 target_link_libraries(mltnormalize PRIVATE mlt)
-if(NOT MSVC)
+if(MSVC)
+  target_link_libraries(mltnormalize PRIVATE PThreads4W::PThreads4W)
+else()
   target_link_libraries(mltnormalize PRIVATE m)
 endif()
 

src/modules/oldfilm/CMakeLists.txt

@@ -18,7 +18,9 @@ generate_export_header(mltoldfilm)
 target_compile_options(mltoldfilm PRIVATE ${MLT_COMPILE_OPTIONS})
 target_include_directories(mltoldfilm PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
 target_link_libraries(mltoldfilm PRIVATE mlt)
-if(NOT MSVC)
+if(MSVC)
+  target_link_libraries(mltoldfilm PRIVATE PThreads4W::PThreads4W)
+else()
   target_link_libraries(mltoldfilm PRIVATE m)
 endif()
 

src/modules/plus/CMakeLists.txt

@@ -44,7 +44,7 @@ target_compile_options(mltplus PRIVATE ${MLT_COMPILE_OPTIONS})
 target_include_directories(mltplus PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
 target_link_libraries(mltplus PRIVATE mlt Threads::Threads)
 if(MSVC)
-  target_link_libraries(mltplus PRIVATE msvccompat)
+  target_link_libraries(mltplus PRIVATE PThreads4W::PThreads4W msvccompat)
 else()
   target_link_libraries(mltplus PRIVATE m)
 endif()