Enable leak detector & fix few memleaks

Author: khvzak

.github/workflows/main.yml

@@ -13,7 +13,7 @@ jobs:
       - uses: dtolnay/rust-toolchain@nightly
       - name: Run tests
         run: |
-          RUSTFLAGS="-D warnings -Z sanitizer=address" ASAN_OPTIONS=detect_leaks=0 cargo test
+          RUSTFLAGS="-D warnings -Z sanitizer=address" ASAN_OPTIONS=detect_leaks=1 cargo test
 
   rustfmt:
     name: Rustfmt

src/lapi.rs

@@ -67,8 +67,9 @@ pub unsafe fn lua_istable(L: *mut lua_State, n: c_int) -> bool {
 }
 
 pub unsafe fn lua_pushliteral(L: *mut lua_State, s: &str) {
-    let cstr = CString::new(s).unwrap().into_raw();
-    lua_pushstring(L, cstr);
+    // TODO: Redesign
+    let s = CString::new(s).expect("valid literal");
+    lua_pushstring(L, s.as_ptr());
 }
 
 pub const fn lua_upvalueindex(i: c_int) -> c_int {

src/lib.rs

@@ -10,7 +10,7 @@
 pub(crate) mod macros;
 
 #[macro_use]
-pub(crate) mod lstate;
+pub mod lstate; // TODO: update visibility
 #[macro_use]
 pub(crate) mod lobject;
 #[macro_use]

src/lmathlib.rs

@@ -50,12 +50,11 @@ unsafe extern "C" fn lua_numbertointeger(n: lua_Number, p: *mut lua_Integer) ->
     return false;
 }
 
-// FIXME static
 #[no_mangle]
 unsafe extern "C" fn pushnumint(L: *mut lua_State, d: lua_Number) {
-    let n: *mut lua_Integer = Box::into_raw(Box::new(0));
-    if lua_numbertointeger(d, n) {
-        lua_pushinteger(L, *n);
+    let mut n: lua_Integer = 0;
+    if lua_numbertointeger(d, &mut n) {
+        lua_pushinteger(L, n);
     } else {
         lua_pushnumber(L, d);
     };

tests/tests.rs

@@ -4,6 +4,7 @@ use std::ptr;
 use rustmoon::cstr;
 use rustmoon::lapi::lua_call;
 use rustmoon::lauxlib::{luaL_loadfilex, luaL_loadstring, luaL_newstate};
+use rustmoon::lstate::lua_close;
 use rustmoon::lualib::luaL_openlibs;
 use rustmoon::types::LUA_OK;
 
@@ -27,6 +28,8 @@ fn test_all() {
                 panic!("Failed to load `all.lua`");
             }
             lua_call(state, 0, 0);
+
+            lua_close(state);
         })
         .unwrap()
         .join()