Skip to content

Commit 7127714

Browse files
authored
Fix body height and .wrapper box shadow. (#14)
Close #13
1 parent b148bc4 commit 7127714

File tree

9 files changed

+37
-28
lines changed

9 files changed

+37
-28
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
1515
- Permalink structure of `/docs` demo site.
1616

1717
### Fixed
18+
- `body` height and `.wrapper` box shadow. [#13](https://github.com/mmistakes/jekyll-theme-basically-basic/issues/13)
1819
- Unclickable main content links in Internet Explorer 10. [#9](https://github.com/mmistakes/jekyll-theme-basically-basic/issues/9)
1920

2021
## [1.0.1] - 2017-03-23

_includes/skip-links.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
<section>
1+
<nav class="skip-links">
22
<h2 class="screen-reader-text">{{ site.data.theme.t.skip_links | default: 'Skip links' }}</h2>
3-
<ul class="skip-links">
3+
<ul>
44
<li><a href="#primary-nav" class="screen-reader-shortcut">{{ site.data.theme.t.skip_primary_nav | default: 'Skip to primary navigation' }}</a></li>
55
<li><a href="#main" class="screen-reader-shortcut">{{ site.data.theme.t.skip_content | default: 'Skip to content' }}</a></li>
66
<li><a href="#footer" class="screen-reader-shortcut">{{ site.data.theme.t.skip_footer | default: 'Skip to footer' }}</a></li>
77
</ul>
8-
</section>
8+
</nav>

_sass/basically-basic/_base.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ html {
77
}
88

99
body {
10+
display: -ms-flexbox;
11+
display: flex;
1012
background: $background-color;
1113
color: $text-color;
1214
}

_sass/basically-basic/_navigation.scss

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,19 @@
1111
}
1212
}
1313

14+
/*
15+
Skip links
16+
========================================================================== */
17+
18+
.skip-links {
19+
position: absolute;
20+
width: 100%;
21+
22+
ul {
23+
@include list-unstyled;
24+
}
25+
}
26+
1427
/*
1528
Paginator
1629
========================================================================== */

_sass/basically-basic/utilities/_accessibility.scss

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,6 @@
22
Accessibility Modules
33
========================================================================== */
44

5-
/* Skip links */
6-
.skip-links {
7-
margin: 0;
8-
9-
li {
10-
width: 0;
11-
height: 0;
12-
list-style: none;
13-
}
14-
}
15-
165
/* Text meant only for screen readers */
176
.screen-reader-text,
187
.screen-reader-text span,

docs/_includes/skip-links.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
<section>
1+
<nav class="skip-links">
22
<h2 class="screen-reader-text">{{ site.data.theme.t.skip_links | default: 'Skip links' }}</h2>
3-
<ul class="skip-links">
3+
<ul>
44
<li><a href="#primary-nav" class="screen-reader-shortcut">{{ site.data.theme.t.skip_primary_nav | default: 'Skip to primary navigation' }}</a></li>
55
<li><a href="#main" class="screen-reader-shortcut">{{ site.data.theme.t.skip_content | default: 'Skip to content' }}</a></li>
66
<li><a href="#footer" class="screen-reader-shortcut">{{ site.data.theme.t.skip_footer | default: 'Skip to footer' }}</a></li>
77
</ul>
8-
</section>
8+
</nav>

docs/_sass/basically-basic/_base.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ html {
77
}
88

99
body {
10+
display: -ms-flexbox;
11+
display: flex;
1012
background: $background-color;
1113
color: $text-color;
1214
}

docs/_sass/basically-basic/_navigation.scss

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,19 @@
1111
}
1212
}
1313

14+
/*
15+
Skip links
16+
========================================================================== */
17+
18+
.skip-links {
19+
position: absolute;
20+
width: 100%;
21+
22+
ul {
23+
@include list-unstyled;
24+
}
25+
}
26+
1427
/*
1528
Paginator
1629
========================================================================== */

docs/_sass/basically-basic/utilities/_accessibility.scss

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,6 @@
22
Accessibility Modules
33
========================================================================== */
44

5-
/* Skip links */
6-
.skip-links {
7-
margin: 0;
8-
9-
li {
10-
width: 0;
11-
height: 0;
12-
list-style: none;
13-
}
14-
}
15-
165
/* Text meant only for screen readers */
176
.screen-reader-text,
187
.screen-reader-text span,

0 commit comments

Comments
 (0)