Skip to content

Commit 8b9af8e

Browse files
committed
Fix theme text strings for search_placeholder_text and results_found
Close #104
1 parent ce6162f commit 8b9af8e

File tree

5 files changed

+8
-3
lines changed

5 files changed

+8
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
1515
- Update GitHub issue templates.
1616

1717
### Fixed
18+
- Fix theme text strings for `search_placeholder_text` and `results_found`. [#104](https://github.com/mmistakes/jekyll-theme-basically-basic/issues/104)
1819
- Remove stray `console.log` from lunr-search-scripts [#105](https://github.com/mmistakes/jekyll-theme-basically-basic/pull/105)
1920
- Add missing `/` in icon-gitlab.html. [#80](https://github.com/mmistakes/jekyll-theme-basically-basic/pull/80)
2021

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,10 @@ t:
351351
skip_content: "Skip to content"
352352
skip_footer: "Skip to footer"
353353
menu: "Menu"
354+
search: "Search"
355+
site_search: "Site Search"
356+
results_found: "Result(s) found"
357+
search_placeholder_text: "Enter your search term..."
354358
home: "Home"
355359
newer: "Newer"
356360
older: "Older"

_includes/search-form.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
{%- case search_provider -%}
55
{%- when "lunr" -%}
66
<label class="visually-hidden" for="search">{{ site.data.theme.t.site_search | default: 'Site Search' }}</label>
7-
<input type="text" id="search" class="search-input" aria-describedby="results-count" tabindex="-1" placeholder="{{ site.data.theme.t.menu.search_placeholder_text | default: 'Enter your search term...' }}" />
7+
<input type="text" id="search" class="search-input" aria-describedby="results-count" tabindex="-1" placeholder="{{ site.data.theme.t.search_placeholder_text | default: 'Enter your search term...' }}" />
88
<div id="results" class="results"></div>
99
{%- when "algolia" -%}
1010
<div tabindex="-1" class="search-searchbar"></div>

_includes/search/algolia-search-scripts.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ <h3 class="entry-title"><a href="{{ site.baseurl }}${url}">${title}</a></h3>
3535
instantsearch.widgets.searchBox({
3636
container: '.search-searchbar',
3737
{% unless site.algolia.powered_by == false %}poweredBy: true,{% endunless %}
38-
placeholder: '{{ site.data.theme.t.menu.search_placeholder_text | default: "Enter your search term..." }}'
38+
placeholder: '{{ site.data.theme.t.search_placeholder_text | default: "Enter your search term..." }}'
3939
})
4040
);
4141
search.addWidget(

_includes/search/lunr-search-scripts.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@
8686
})
8787
});
8888
resultdiv.empty();
89-
resultdiv.prepend('<p id="results-count" class="results-found">' + result.length + ' {{ site.data.theme.t.menu.results_found | default: "Result(s) found" }}</p>');
89+
resultdiv.prepend('<p id="results-count" class="results-found">' + result.length + ' {{ site.data.theme.t.results_found | default: "Result(s) found" }}</p>');
9090
for (var item in result) {
9191
var ref = result[item].ref;
9292
var searchitem =

0 commit comments

Comments
 (0)