Skip to content

Commit c8bfe48

Browse files
committed
Fixed sidebar visibility bug
Add `visibility: hidden` to `.sidebar` and toggle it to `visible` when sidebar is in view. Keeps it from showing up when scrolling past the browser's viewport in Safari as well. Fixes #31
1 parent 48d316a commit c8bfe48

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
88
## [1.1.2] - 2017-09-14
99

1010
### Fixed
11-
- `/_sass/_print.scss` to reduce blank pages when printing in Chrome. [#29](https://github.com/mmistakes/jekyll-theme-basically-basic/issues/29)
11+
- Adjusted `/_sass/_print.scss` to reduce blank pages when printing in Chrome. [#29](https://github.com/mmistakes/jekyll-theme-basically-basic/issues/29)
12+
- Fixed sidebar visibility bug in Firefox and Safari by adding toggling `visibility: hidden`. [#31](https://github.com/mmistakes/jekyll-theme-basically-basic/issues/31)
1213

1314
## [1.1.1] - 2017-09-06
1415
### Changed

_sass/basically-basic/_sidebar.scss

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,20 @@
1010
max-width: $sidebar-width;
1111
height: 100%;
1212
z-index: 50;
13+
visibility: hidden;
14+
-webkit-transition: visibility 0s 0.3s;
15+
transition: visibility 0s 0.3s;
1316

1417
@include breakpoint($large) {
1518
max-width: (1.5 * $sidebar-width);
1619
}
1720

21+
&.is--visible {
22+
visibility: visible;
23+
-webkit-transition: visibility 0s 0s;
24+
transition: visibility 0s 0s;
25+
}
26+
1827
li {
1928
transform: translateX(-1rem);
2029
transition: all 0.5s;

0 commit comments

Comments
 (0)