Skip to content

Commit 52b4946

Browse files
authored
Pin mdbook/mdbook-admonish version (#1416)
`mdbook 0.5` had some breaking changes and `mdbook-admonish` hasn't been updated to work with `mdbook 0.5` (tommilligan/mdbook-admonish#233). At this point, pin the version for `mdbook` and `mdbook-admonish`.
1 parent e25ad8b commit 52b4946

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

.github/scripts/ci-doc.sh

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,11 @@ cargo build --manifest-path $dummyvm_toml
2727

2828
# Install mdbook using the stable toolchain and the default target
2929
unset CARGO_BUILD_TARGET
30-
cargo +stable install mdbook mdbook-admonish mdbook-hide
31-
mdbook build $project_root/docs/userguide
30+
31+
# mdbook-admonish does not support mdbook 0.5. So we pin the version to 0.4 for mdbook.
32+
# When the issue (https://github.com/tommilligan/mdbook-admonish/issues/233) is resolved, we can upgrade mdbook to 0.5.
33+
cargo +stable install mdbook --version "^0.4"
34+
cargo +stable install mdbook-admonish --version "=1.20.0"
35+
# It seems we don't need a specific version for mdbook-hide atm.
36+
cargo +stable install mdbook-hide
37+
rustup run stable mdbook build $project_root/docs/userguide

0 commit comments

Comments
 (0)