Skip to content

Commit 017cfa8

Browse files
authored
Only skip problematic tests for max moving build (#263)
1 parent 9a25c65 commit 017cfa8

File tree

2 files changed

+25
-5
lines changed

2 files changed

+25
-5
lines changed

.github/scripts/ci-test-other.sh

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ REGEX_PATTERN='.*const TESTNAMES = \[([^\[]*)^\].*'
1717
is_moving=$2
1818
moving_feature=${is_moving,,}
1919

20-
declare -a tests_to_skip=(
20+
declare -a max_moving_tests_to_skip=(
2121
# see https://github.com/mmtk/mmtk-julia/issues/259
2222
"abstractarray"
2323
"cmdlineargs"
@@ -50,9 +50,11 @@ if [[ $CHOOSE_TESTS_JL_CONTENT =~ $REGEX_PATTERN ]]; then
5050
continue
5151
fi
5252

53-
if [[ "${tests_to_skip[@]}" =~ "$test" ]]; then
54-
echo "-> Skip"
55-
continue
53+
if [[ "${max_moving_tests_to_skip[@]}" =~ "$test" ]]; then
54+
if [ "$moving_feature" == "max_moving" ]; then
55+
echo "-> Skip"
56+
continue
57+
fi
5658
fi
5759

5860
if [[ $test =~ "compiler_extras" ]]; then

.github/scripts/ci-test-stdlib.sh

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,21 @@ declare -a tests_to_skip=(
3434
# see https://github.com/mmtk/mmtk-julia/issues/259
3535
"Downloads"
3636
"REPL"
37-
"TOML"
3837
"Random"
3938
"LibCURL"
4039
"LazyArtifacts"
4140
)
41+
42+
declare -a max_moving_tests_to_skip=(
43+
# Skipping tests that fail for max moving Immix
44+
# see https://github.com/mmtk/mmtk-julia/issues/259
45+
"Downloads"
46+
"REPL"
47+
"Random"
48+
"LibCURL"
49+
"LazyArtifacts"
50+
)
51+
4252
# These tests need multiple workers.
4353
declare -a tests_with_multi_workers=(
4454
"Pkg"
@@ -78,6 +88,14 @@ do
7888
continue
7989
fi
8090

91+
# Skip tests with max moving build
92+
if [[ "${max_moving_tests_to_skip[@]}" =~ "$test" ]]; then
93+
if [ "$moving_feature" == "max_moving" ]; then
94+
echo "-> Skip"
95+
continue
96+
fi
97+
fi
98+
8199
if [[ "${tests_with_multi_workers[@]}" =~ "$test" ]]; then
82100
echo "-> Run multi threaded"
83101
ci_run_jl_test $test 2 $moving_feature

0 commit comments

Comments
 (0)