[fix] Add logging and regression tests for update_config self-detection

Added logger.info when update_config is skipped due to another active
task, improving traceability. Added regression tests to verify that
_is_update_in_progress correctly excludes the calling task's own ID
while still detecting other active tasks. Fixed Black formatting.

Author: mn-ram

openwisp_controller/connection/tasks.py

@@ -53,6 +53,9 @@ def update_config(self, device_id):
         logger.warning(f'update_config("{device_id}") failed: {e}')
         return
     if _is_update_in_progress(device_id, current_task_id=self.request.id):
+        logger.info(
+            f"update_config for device {device_id} is already in progress, skipping"
+        )
         return
     try:
         device_conn = DeviceConnection.get_working_connection(device)

openwisp_controller/connection/tests/test_models.py

@@ -21,7 +21,7 @@
 )
 from ..exceptions import NoWorkingDeviceConnectionError
 from ..signals import is_working_changed
-from ..tasks import _TASK_NAME, update_config
+from ..tasks import _TASK_NAME, _is_update_in_progress, update_config
 from .utils import CreateConnectionsMixin
 
 Config = load_model("config", "Config")
@@ -1060,9 +1060,7 @@ def test_device_update_config_not_in_progress(
 
         with mock.patch("celery.app.control.Inspect.active") as mocked_active:
             mocked_active.return_value = {
-                "task": [
-                    {"name": _TASK_NAME, "args": ["..."], "id": "other-task-id"}
-                ]
+                "task": [{"name": _TASK_NAME, "args": ["..."], "id": "other-task-id"}]
             }
             conf.config = {"general": {"timezone": "UTC"}}
             conf.full_clean()
@@ -1071,6 +1069,43 @@ def test_device_update_config_not_in_progress(
             mocked_get_working_connection.assert_called_once()
             mocked_update_config.assert_called_once()
 
+    def test_is_update_in_progress_ignores_current_task(self):
+        """Regression test: _is_update_in_progress must not count
+        the calling task itself as a duplicate."""
+        device_id = "test-device-id"
+        current_task_id = "current-task-id"
+        with mock.patch("celery.app.control.Inspect.active") as mocked_active:
+            mocked_active.return_value = {
+                "worker": [
+                    {
+                        "name": _TASK_NAME,
+                        "args": [device_id],
+                        "id": current_task_id,
+                    }
+                ]
+            }
+            result = _is_update_in_progress(device_id, current_task_id=current_task_id)
+            self.assertFalse(result)
+
+    def test_is_update_in_progress_detects_other_task(self):
+        """_is_update_in_progress returns True when another task
+        for the same device is active."""
+        device_id = "test-device-id"
+        with mock.patch("celery.app.control.Inspect.active") as mocked_active:
+            mocked_active.return_value = {
+                "worker": [
+                    {
+                        "name": _TASK_NAME,
+                        "args": [device_id],
+                        "id": "other-task-id",
+                    }
+                ]
+            }
+            result = _is_update_in_progress(
+                device_id, current_task_id="current-task-id"
+            )
+            self.assertTrue(result)
+
     @mock.patch(_connect_path)
     def test_schedule_command_called(self, connect_mocked):
         dc = self._create_device_connection()