fix: configurable max size

Author: mnahkies

e2e/openapi.yaml

@@ -333,6 +333,7 @@ paths:
             schema:
               type: string
               format: binary
+              maxLength: 20971520
       responses:
         200:
           description: ok

e2e/src/generated/server/express/routes/media-types.ts

@@ -80,7 +80,28 @@ by the server templates. Full support is expected to land soon.
 
 ## `application/octet-stream`
 
-🚫 Not yet supported. Coming soon.
+| Template           | Supported |                                                                           Notes |
+|:-------------------|:---------:|--------------------------------------------------------------------------------:|
+| typescript-angular |    🚫     |                                                                                 |
+| typescript-axios   |     ✅     |                         Uses `Blob` for request bodies, and response `res.data` |
+| typescript-express |     ✅     |                              Parses request bodies to `Blob`, serializes `Blob` |
+| typescript-fetch   |     ✅     | Pass a `Blob` for request bodies, access using `res.blob()` for response bodies |
+| typescript-koa     |     ✅     |                              Parses request bodies to `Blob`, serializes `Blob` |
+
+### Controlling Maximum Request Body size
+By default, a maximum of `10mb` is used as the maximum requset body size for binary data. You can override this for
+an individual schema by using the `maxLength` field, which will be interpreted as `bytes`, eg:
+
+```yaml
+post:
+  requestBody:
+    content:
+      application/octet-stream:
+        schema:
+          type: string
+          format: binary
+          maxLength: 20971520 # 20mb in bytes
+```
 
 ## Selecting between multiple possible `Content-Type`
 

e2e/src/generated/server/koa/routes/media-types.ts

@@ -2,6 +2,7 @@ import {describe, expect, it} from "@jest/globals"
 import {
   camelCase,
   coalesce,
+  convertBytesToHuman,
   deepEqual,
   hasSingleElement,
   isDefined,
@@ -358,4 +359,16 @@ describe("core/utils", () => {
       expect(mediaTypeToIdentifier(contentType)).toBe(expected)
     })
   })
+
+  describe("#convertBytesToHuman", () => {
+    it("converts to mb", () => {
+      expect(convertBytesToHuman(5 * 1024 * 1024)).toBe("5mb")
+    })
+    it("converts to kb", () => {
+      expect(convertBytesToHuman(128 * 1024)).toBe("128kb")
+    })
+    it("leaves as b", () => {
+      expect(convertBytesToHuman(768)).toBe("768b")
+    })
+  })
 })

integration-tests/typescript-express/src/generated/api.github.com.yaml/generated.ts

@@ -207,3 +207,23 @@ export function mediaTypeToIdentifier(mediaType: string): string {
 
   return titleCase([type, subType].filter(isDefined).join(" "))
 }
+
+export function convertBytesToHuman(
+  bytes: number,
+): number | `${number}${"mb" | "kb" | "b"}` {
+  const units = ["mb" as const, "kb" as const, "b" as const]
+
+  let adjusted = bytes
+  while (units.length > 1 && adjusted % 1024 === 0) {
+    adjusted /= 1024
+    units.pop()
+  }
+
+  const unit = units.pop()
+
+  if (!unit) {
+    return bytes
+  }
+
+  return `${adjusted}${unit}` as const
+}

integration-tests/typescript-koa/src/generated/api.github.com.yaml/generated.ts

@@ -180,6 +180,7 @@ export class TypeBuilder implements ICompilable {
             }
           } else if (
             schemaObject.format === "binary" ||
+            // todo: is byte the same as binary
             schemaObject.format === "byte"
           ) {
             result.push("Blob")

packages/documentation/src/app/guides/concepts/content-type/page.mdx

@@ -47,6 +47,7 @@ export abstract class AbstractRouterBuilder implements ICompilable {
       {
         requestBody: {
           supportedMediaTypes: this.capabilities.requestBody.mediaTypes,
+          defaultMaxSize: "10mb",
         },
       },
     )