Improved array typing

Thanks to @szepeviktor

Author: szepeviktor

src/Encoding/Json.php

@@ -30,6 +30,8 @@ public function __construct(Reader $reader)
     }
 
     /**
+     * @return array<mixed, mixed>
+     *
      * @throws JsonException
      * @throws ReaderError
      */

src/Encoding/JsonDecoder.php

@@ -19,6 +19,8 @@ interface JsonDecoder
     /**
      * Decodes a json string into an associative array.
      *
+     * @return array<mixed, mixed>
+     *
      * @throws JsonException when parsing fails
      */
     public function decode(): array;

src/Headers.php

@@ -14,10 +14,15 @@
  */
 class Headers
 {
+    /**
+     * @var array<string, string>
+     */
     private array $headers;
 
     /**
      * @internal You should not use this api
+     *
+     * @param list<string> $lines
      */
     public static function fromLines(array &$lines): Headers
     {
@@ -35,6 +40,9 @@ public static function fromLines(array &$lines): Headers
         return $headers;
     }
 
+    /**
+     * @param array<string, string> $headers
+     */
     public static function fromMap(array $headers): Headers
     {
         $self = new self();
@@ -83,6 +91,9 @@ public function has(string $name): bool
         return array_key_exists($name, $this->headers);
     }
 
+    /**
+     * @return list<string>
+     */
     public function map(callable $callable): array
     {
         $arr = [];
@@ -93,6 +104,9 @@ public function map(callable $callable): array
         return $arr;
     }
 
+    /**
+     * @return array<string, string>
+     */
     public function filter(callable $callable): array
     {
         $arr = [];
@@ -105,11 +119,17 @@ public function filter(callable $callable): array
         return $arr;
     }
 
+    /**
+     * @return list<string>
+     */
     public function toArray(): array
     {
         return $this->map(fn (string $value, string $name) => $name.': '.$value);
     }
 
+    /**
+     * @return array<string, string>
+     */
     public function toMap(): array
     {
         return $this->headers;

src/HttpPartialResponse.php

@@ -21,12 +21,14 @@ final class HttpPartialResponse implements PartialResponse
     private Headers $headers;
 
     /**
-     * @return HttpPartialResponse[]
+     * @param list<string> $lines
+     *
+     * @return list<HttpPartialResponse>
      */
     public static function parseLines(array $lines): array
     {
         $partials = [];
-        while (count($lines) > 0) {
+        while ($lines !== []) {
             $line = array_shift($lines);
             if (strpos($line, 'HTTP') === 0) {
                 $status = Status::fromStatusLine($line);

src/Redirected.php

@@ -19,7 +19,7 @@ interface Redirected
      *
      * The body of those responses is not available.
      *
-     * @return PartialResponse[]
+     * @return list<PartialResponse>
      */
     public function previousResponses(): array;
 }

src/RedirectedHttpResponse.php

@@ -18,7 +18,7 @@ final class RedirectedHttpResponse implements Response, Redirected
 {
     private Response $response;
     /**
-     * @var PartialResponse[]
+     * @var list<PartialResponse>
      */
     private array $previous;