Merge branch 'main' into website-timestamp-24h

Author: cbrnr

doc/_templates/sidebar-quicklinks.html

@@ -4,7 +4,7 @@ <h5 class="card-header font-weight-bold">Version {{ release }}</h5>
         <ul class="list-group list-group-flush list-unstyled quicklinks">
             <li><a href="{{ pathto('auto_tutorials/index.html', 1) }}"><i class="fas fa-book fa-fw"></i> Tutorials</a></li>
             <li><a href="{{ pathto('development/whats_new.html', 1) }}"><i class="fas fa-newspaper fa-fw"></i> Changelog</a></li>
-            <li><a href="{{ pathto('help/index.html', 1) }}"><i class="fas fa-circle-question fa-fw"></i> Get help</a></li>
+            <li><a href="{{ pathto('help/index.html', 1) }}"><i class="fas fa-circle-question fa-fw"></i> Get Help</a></li>
             <li><a href="{{ pathto('documentation/cite.html', 1) }}"><i class="fas fa-quote-left fa-fw"></i> Cite</a></li>
             <li><a href="{{ pathto('development/contributing.html', 1) }}"><i class="fas fa-code-branch fa-fw"></i> Contribute</a></li>
             <li><a href="{{ pathto('credit.html', 1) }}"><i class="fas fa-hands-clapping fa-fw"></i> Contributors</a></li>

doc/changes/devel/13341.bugfix.rst

@@ -0,0 +1 @@
+Fix bug with :func:`mne.open_report` not working with old saved files, by `Eric Larson`_.

doc/conf.py

@@ -787,7 +787,7 @@ def fix_sklearn_inherited_docstrings(app, what, name, obj, options, lines):
 # Theme options are theme-specific and customize the look and feel of a theme
 # further.  For a list of options available for each theme, see the
 # documentation.
-switcher_version_match = "dev" if ".dev" in version else version
+switcher_version_match = "dev" if ".dev" in release else version
 html_theme_options = {
     "icon_links": [
         dict(

mne/report/report.py

@@ -714,12 +714,11 @@ def open_report(fname, **params):
         # Check **params with the loaded report
         read_hdf5, _ = _import_h5io_funcs()
         state = read_hdf5(fname, title="mnepython")
+        for param, default in _backward_compat_map.items():
+            state.setdefault(param, default)
         for param in params:
             if param not in state:
-                if param in _backward_compat_map:
-                    state[param] = _backward_compat_map[param]
-                else:
-                    raise ValueError(f"The loaded report has no attribute {param}")
+                raise ValueError(f"The loaded report has no attribute {param}")
             if params[param] != state[param]:
                 raise ValueError(
                     f"Attribute '{param}' of loaded report ({params[param]}) does not "

mne/report/tests/test_report.py

@@ -1172,6 +1172,21 @@ def test_report_tweaks(tmp_path, monkeypatch):
     assert img.shape == (2000, 2000, 3)  # figure.figsize * figure.dpi
 
 
+def test_report_backward_compat(tmp_path):
+    """Ensure our options are still backward compatible."""
+    h5io = pytest.importorskip("h5io")
+    fname = tmp_path / "report.h5"
+    r = Report()
+    r.img_max_width = 600
+    r.save(fname)
+    h = h5io.read_hdf5(fname, title="mnepython")
+    assert h["img_max_width"] == 600
+    del h["img_max_width"]
+    h5io.write_hdf5(fname, h, title="mnepython", overwrite=True)
+    with open_report(fname) as r2:
+        assert r2.img_max_width == 850
+
+
 @pytest.mark.slowtest  # 30 s on Azure
 @testing.requires_testing_data
 def test_manual_report_3d(tmp_path, renderer):

tools/install_pre_requirements.sh

@@ -31,9 +31,8 @@ python -m pip install $STD_ARGS --only-binary ":all:" --default-timeout=60 \
 	"dipy>=1.10.0.dev0" \
 	"pyarrow>=20.0.0.dev0" \
 	"tables>=3.10.3.dev0" \
+	"statsmodels>=0.15.0.dev697" \
 	"h5py>=3.13.0"
-# TODO: should have above: "statsmodels>=0.15.0.dev0"
-# https://github.com/statsmodels/statsmodels/issues/9572
 echo "::endgroup::"
 
 # No Numba because it forces an old NumPy version