Skip to content

Commit 34e2743

Browse files
[pre-commit.ci] pre-commit autoupdate (#13431)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eric Larson <[email protected]>
1 parent 51b6a5c commit 34e2743

File tree

11 files changed

+33
-18
lines changed

11 files changed

+33
-18
lines changed

.github/workflows/tests.yml

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ jobs:
5050
pytest:
5151
name: '${{ matrix.os }} / ${{ matrix.kind }} / ${{ matrix.python }}'
5252
needs: style
53-
timeout-minutes: 90
53+
timeout-minutes: 120
5454
runs-on: ${{ matrix.os }}
5555
defaults:
5656
run:
@@ -78,7 +78,7 @@ jobs:
7878
- os: macos-latest # arm64 (Apple Silicon): Sequoia
7979
python: '3.13'
8080
kind: mamba
81-
- os: macos-14 # arm64 (Apple Silicon): Sonoma
81+
- os: macos-15-intel # intel: Sequoia
8282
python: '3.13'
8383
kind: mamba
8484
- os: windows-latest
@@ -128,12 +128,18 @@ jobs:
128128
# For some reason on Linux we get crashes
129129
if [[ "$RUNNER_OS" == "Linux" ]]; then
130130
sed -i "/numba/d" environment.yml
131+
fi
131132
# And on Windows and macOS PySide6.9.0 segfaults
132-
elif [[ "$RUNNER_OS" == "macOS" ]]; then
133-
sed -i "" "s/ - PySide6 .*/ - PySide6 =6.7.3/g" environment.yml
134-
sed -i "" "s/ - vtk .*/ - vtk =9.3.1/g" environment.yml
135-
elif [[ "$RUNNER_OS" == "Windows" ]]; then
136-
sed -i "s/ - PySide6 .*/ - PySide6 <6.8/g" environment.yml
133+
if [[ "$RUNNER_OS" == "macOS" ]]; then
134+
sed -i "" "s/ - PySide6 .*/ - PySide6 =6.9.2/g" environment.yml
135+
sed -i "" "s/ - vtk .*/ - vtk =9.5.1/g" environment.yml
136+
137+
else
138+
sed -i "s/ - PySide6 .*/ - PySide6 =6.9.2/g" environment.yml
139+
sed -i "s/ - vtk .*/ - vtk =9.5.1/g" environment.yml
140+
if [[ "$RUNNER_OS" == "Windows" ]]; then
141+
echo "MNE_IS_OSMESA=true" | tee -a $GITHUB_ENV
142+
fi
137143
fi
138144
if: matrix.kind == 'conda' || matrix.kind == 'mamba'
139145
- uses: mamba-org/setup-micromamba@v2

.pre-commit-config.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
repos:
22
# Ruff mne
33
- repo: https://github.com/astral-sh/ruff-pre-commit
4-
rev: v0.13.1
4+
rev: v0.13.2
55
hooks:
66
- id: ruff-check
77
name: ruff lint mne
@@ -82,7 +82,7 @@ repos:
8282

8383
# zizmor
8484
- repo: https://github.com/woodruffw/zizmor-pre-commit
85-
rev: v1.13.0
85+
rev: v1.14.2
8686
hooks:
8787
- id: zizmor
8888

doc/sphinxext/related_software.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
"meggie",
3434
"niseq",
3535
"sesameeg",
36-
"invertmeeg",
3736
}
3837

3938
# If it's not available on PyPI, add it to this dict:

environment.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,3 +62,5 @@ dependencies:
6262
- trame-vuetify
6363
- vtk >=9.2
6464
- xlrd
65+
- pip:
66+
- pyobjc-framework-Cocoa >=5.2.0;platform_system=='Darwin'

mne/conftest.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,11 @@ def pytest_configure(config: pytest.Config):
199199
ignore:.*The `disp` and `iprint` options of the L-BFGS-B solver.*:DeprecationWarning
200200
# matplotlib<->nilearn
201201
ignore:[\S\s]*You are using the 'agg' matplotlib backend[\S\s]*:UserWarning
202+
# matplotlib<->pyparsing
203+
ignore:^'.*' argument is deprecated, use '.*'$:DeprecationWarning
204+
ignore:^'.*' deprecated - use '.*'$:DeprecationWarning
205+
# dipy
206+
ignore:'where' used without 'out', expect .*:UserWarning
202207
""" # noqa: E501
203208
for warning_line in warning_lines.split("\n"):
204209
warning_line = warning_line.strip()

mne/decoding/tests/test_receptive_field.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,9 +238,9 @@ def test_receptive_field_basic(n_jobs):
238238
rf.fit(X[:, [0]], y)
239239
str(rf) # repr with one feature
240240
# Should only accept estimators or floats
241-
with pytest.raises(ValueError, match="`estimator` must be a float or"):
241+
with pytest.raises((ValueError, AttributeError)):
242242
ReceptiveField(tmin, tmax, 1, estimator="foo").fit(X, y)
243-
with pytest.raises(ValueError, match="`estimator` must be a float or"):
243+
with pytest.raises((ValueError, AttributeError)):
244244
ReceptiveField(tmin, tmax, 1, estimator=np.array([1, 2, 3])).fit(X, y)
245245
with pytest.raises(ValueError, match="tmin .* must be at most tmax"):
246246
ReceptiveField(5, 4, 1).fit(X, y)

mne/viz/backends/_pyvista.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
# License: BSD-3-Clause
99
# Copyright the MNE-Python contributors.
1010

11+
import os
1112
import platform
1213
import re
1314
import warnings
@@ -1331,6 +1332,8 @@ def _is_osmesa(plotter):
13311332
# and a working Nouveau is: "Mesa 24.2.3-1ubuntu1 via NVE6"
13321333
if platform.system() == "Darwin": # segfaults on macOS sometimes
13331334
return False
1335+
if os.getenv("MNE_IS_OSMESA", "").lower() == "true":
1336+
return True
13341337
gpu_info_full = plotter.ren_win.ReportCapabilities()
13351338
gpu_info = re.findall(
13361339
"OpenGL (?:version|renderer) string:(.+)\n",

mne/viz/backends/tests/test_renderer.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,7 @@ def test_3d_warning(renderer_pyvistaqt, monkeypatch):
226226
bad = f"{pre}OpenGL 3.3 (Core Profile) Mesa 18.3.4 via llvmpipe (LLVM 7.0, 256 bits)\n" # noqa
227227
monkeypatch.setattr(platform, "system", lambda: "Linux") # avoid short-circuit
228228
monkeypatch.setattr(plotter.ren_win, "ReportCapabilities", lambda: good)
229+
monkeypatch.setenv("MNE_IS_OSMESA", "false")
229230
assert _is_osmesa(plotter)
230231
monkeypatch.setattr(plotter.ren_win, "ReportCapabilities", lambda: bad)
231232
with pytest.warns(RuntimeWarning, match=r"18\.3\.4 is too old"):

tools/circleci_dependencies.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ python -m pip install --upgrade --progress-bar off \
1414
mne-icalabel mne-lsl mne-microstates mne-nirs mne-rsa \
1515
neurodsp neurokit2 niseq nitime pactools mnelab \
1616
plotly pycrostates pyprep pyriemann python-picard sesameeg \
17-
sleepecg tensorpac yasa meegkit eeg_positions wfdb invertmeeg \
17+
sleepecg tensorpac yasa meegkit eeg_positions wfdb \
1818
curryreader
1919
python -m pip install --upgrade --progress-bar off --no-deps cross-domain-saliency-maps

tools/github_actions_dependencies.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ if [ ! -z "$CONDA_ENV" ]; then
1717
if [[ "${RUNNER_OS}" != "Windows" ]] && [[ "${CONDA_ENV}" != "environment_"* ]]; then
1818
INSTALL_ARGS=""
1919
fi
20+
# TODO: Until a PyVista release supports VTK 9.5+
21+
STD_ARGS="$STD_ARGS https://github.com/pyvista/pyvista/archive/refs/heads/main.zip"
2022
# If on minimal or old, just install testing deps
2123
if [[ "${CONDA_ENV}" == "environment_"* ]]; then
2224
INSTALL_KIND="test"

0 commit comments

Comments
 (0)