work on unit tests some more

Author: wmvanvliet

mne/gui/tests/test_xfit.py

@@ -2,7 +2,7 @@
 # License: BSD-3-Clause
 # Copyright the MNE-Python contributors.
 
-
+import matplotlib.pyplot as plt
 import numpy as np
 import pytest
 from numpy.testing import assert_allclose, assert_equal
@@ -17,15 +17,16 @@
 subjects_dir = data_path / "subjects"
 fname_dip = data_path / "MEG" / "sample" / "sample_audvis_trunc_set1.dip"
 fname_evokeds = data_path / "MEG" / "sample" / "sample_audvis_trunc-ave.fif"
+fname_trans = data_path / "MEG" / "sample" / "sample_audvis_trunc-trans.fif"
 
 
 def _gui_with_two_dipoles():
     """Create a dipolefit GUI and add two dipoles to it."""
     from mne.gui import dipolefit
 
     g = dipolefit(fname_evokeds)
-    dip = mne.read_dipole(fname_dip)[[0, 1]]
-    g.add_dipole(dip, name=["rh1", "rh2"])
+    dip = mne.read_dipole(fname_dip)[[12, 15]]  # 80ms and 90ms
+    g.add_dipole(dip, name=["rh", "lh"])
     return g
 
 
@@ -37,8 +38,9 @@ def test_dipolefit_gui_basic(renderer_interactive_pyvistaqt):
 
     # Test basic interface elements.
     g = dipolefit(fname_evokeds)
-    assert g._evoked.comment == "Left Auditory"  # MNE-Sample data should be loaded
-    assert g._current_time == g._evoked.times[84]  # time of max GFP
+    evoked = g._evoked
+    assert evoked.comment == "Left Auditory"  # MNE-Sample data should be loaded
+    assert g._current_time == evoked.times[84]  # time of max GFP
 
     # Test fitting a single dipole.
     assert len(g._dipoles) == len(g.dipoles) == 0
@@ -48,28 +50,38 @@ def test_dipolefit_gui_basic(renderer_interactive_pyvistaqt):
     assert dip.name == "Left Auditory"
     assert len(dip.times) == 1
     assert_equal(dip.times, g._current_time)
-    assert_allclose(dip.amplitude, 6.152221e-08, rtol=1e-4)
-    assert_allclose(dip.pos, [[0.04568744, 0.00753845, 0.06737837]], atol=1e-5)
-    assert_allclose(dip.ori, [[0.45720003, -0.72124413, -0.52036049]], atol=1e-5)
     old_dip1_timecourse = g._dipoles[0]["timecourse"]
 
+    # Check the position of the fitted dipole against the pre-computed dipole in the
+    # testing dataset. The pre-computed dipole only needs to give us the general area
+    # in which we expect the fitted dipole and does not have to be a perfect match.
+    ref_dip = mne.read_dipole(fname_dip)
+    ref_dip_t = ref_dip[[np.argmin(np.abs(ref_dip.times - g._current_time))]]
+    assert_allclose(dip.pos, ref_dip_t.pos, atol=0.012)  # somewhat near the reference
+
     # Test fitting a second dipole with a subset of channels at a different time.
     g._on_sensor_data()  # open sensor selection window
-    picks = read_vectorview_selection("Left", info=g._evoked.info)
+    picks = read_vectorview_selection("Left", info=evoked.info)
     ui_events.publish(g._fig_sensors, ui_events.ChannelsSelect(picks))
     assert sorted(g._fig_sensors.lasso.selection) == sorted(picks)
-    ui_events.publish(g._fig, ui_events.TimeChange(0.1))  # change time
-    assert g._current_time == 0.1
+    ui_events.publish(g._fig, ui_events.TimeChange(0.09))  # change time
+    assert g._current_time == 0.09
     g._on_fit_dipole()
     assert len(g._dipoles) == len(g.dipoles) == 2
     dip2 = g.dipoles[1]
-    assert_equal(dip2.times, g._evoked.times[np.searchsorted(g._evoked.times, 0.1) - 1])
-    assert_allclose(dip2.amplitude, 4.422736e-08, rtol=1e-4)
-    assert_allclose(dip2.pos, [[-0.05893074, -0.00202937, 0.05113064]], atol=1e-5)
-    assert_allclose(dip2.ori, [[0.3017588, -0.88550684, -0.35329769]], atol=1e-5)
+
+    # The selected time of 0.09 is not actually in evoked.times, find the closest value
+    # that is (0.08990784...). That should be the time recorded in the dipole object.
+    closest_time = evoked.times[np.argmin(np.abs(evoked.times - g._current_time))]
+    assert dip2.times[0] == closest_time
+
+    # Check that the general area of the second dipole is now in the left hemisphere.
+    ref_dip_t = ref_dip[[np.argmin(np.abs(ref_dip.times - g._current_time))]]
+    assert_allclose(dip2.pos, ref_dip_t.pos, atol=0.012)  # somewhat near the reference
+
     # Adding the second dipole should have affected the timecourse of the first.
     new_dip1_timecourse = g._dipoles[0]["timecourse"]
-    assert not np.allclose(old_dip1_timecourse, new_dip1_timecourse)
+    assert not np.allclose(old_dip1_timecourse, new_dip1_timecourse, atol=1e-10)
 
     # Test differences between the two dipoles
     assert list(g._dipoles.keys()) == [0, 1]
@@ -78,12 +90,6 @@ def test_dipolefit_gui_basic(renderer_interactive_pyvistaqt):
     assert dip2_dict["dip"] is dip2
     assert dip1_dict["num"] == 0
     assert dip2_dict["num"] == 1
-    assert_allclose(
-        dip1_dict["helmet_pos"], [0.10320071, 0.00946581, 0.07516293], atol=1e-5
-    )
-    assert_allclose(
-        dip2_dict["helmet_pos"], [-0.11462019, -0.00727073, 0.04561434], atol=1e-5
-    )
     assert dip1_dict["color"] == _get_color_list()[0]
     assert dip2_dict["color"] == _get_color_list()[1]
 
@@ -92,7 +98,9 @@ def test_dipolefit_gui_basic(renderer_interactive_pyvistaqt):
     old_timecourses = np.vstack((dip1_dict["timecourse"], dip2_dict["timecourse"]))
     g._on_select_method("Single dipole")
     new_timecourses = np.vstack((dip1_dict["timecourse"], dip2_dict["timecourse"]))
-    assert not np.allclose(old_timecourses, new_timecourses)
+    assert not np.allclose(old_timecourses, new_timecourses, atol=1e-10)
+
+    plt.close(g._fig_sensors)
     g._fig._renderer.close()
 
 
@@ -176,7 +184,7 @@ def test_dipolefit_gui_save_load(tmpdir, renderer_interactive_pyvistaqt):
     g.add_dipole(dip_from_file)
     g.add_dipole(mne.read_dipole(tmpdir / "test.bdip"))
     assert len(g.dipoles) == 6
-    assert [d.name for d in g.dipoles] == ["rh1", "rh2", "rh1", "rh2", "dip4", "dip5"]
+    assert [d.name for d in g.dipoles] == ["rh", "lh", "rh", "lh", "dip4", "dip5"]
     assert_allclose(
         np.vstack([d.pos for d in g.dipoles[:2]]), dip_from_file.pos, atol=0
     )