Added better url parsing logic for remote image extension extraction. Also added BMP support since react native <Image> supports BMP.

Author: billmalarky

lib/FileSystem.js

@@ -11,6 +11,7 @@ import { Platform } from 'react-native';
 import pathLib from 'path';
 import RNFetchBlob from 'react-native-fetch-blob';
 import sha1 from 'crypto-js/sha1';
+import URL from 'url-parse';
 
 export class FileSystem {
 
@@ -138,7 +139,8 @@ export class FileSystem {
    */
   getFileNameFromUrl(url) {
 
-    let urlExt = url.split('.').pop();
+    const urlParts = new URL(url);
+    const urlExt = urlParts.pathname.split('.').pop();
 
     let extension = null;
     switch(urlExt) {
@@ -156,6 +158,10 @@ export class FileSystem {
       case 'JPEG':
         extension = 'jpg';
         break;
+      case 'BMP':
+      case 'bmp':
+        extension = 'bmp';
+        break;
       default:
         throw new Error('url has invalid file extension.');
     }

package.json

@@ -59,6 +59,7 @@
     "react-native-fetch-blob": "0.10.8",
     "react-native-uuid": "^1.4.9",
     "traverse": "^0.6.6",
+    "url-parse": "^1.2.0",
     "validator": "^9.0.0"
   }
 }

yarn.lock

@@ -3696,6 +3696,10 @@ qs@~6.5.1:
   version "6.5.1"
   resolved "https://registry.yarnpkg.com/qs/-/qs-6.5.1.tgz#349cdf6eef89ec45c12d7d5eb3fc0c870343a6d8"
 
+querystringify@~1.0.0:
+  version "1.0.0"
+  resolved "https://registry.yarnpkg.com/querystringify/-/querystringify-1.0.0.tgz#6286242112c5b712fa654e526652bf6a13ff05cb"
+
 random-bytes@~1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/random-bytes/-/random-bytes-1.0.0.tgz#4f68a1dc0ae58bd3fb95848c30324db75d64360b"
@@ -4039,6 +4043,10 @@ require-uncached@^1.0.3:
     caller-path "^0.1.0"
     resolve-from "^1.0.0"
 
+requires-port@~1.0.0:
+  version "1.0.0"
+  resolved "https://registry.yarnpkg.com/requires-port/-/requires-port-1.0.0.tgz#925d2601d39ac485e091cf0da5c6e694dc3dcaff"
+
 resolve-from@^1.0.0:
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/resolve-from/-/resolve-from-1.0.1.tgz#26cbfe935d1aeeeabb29bc3fe5aeb01e93d44226"
@@ -4675,6 +4683,13 @@ [email protected], unpipe@~1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/unpipe/-/unpipe-1.0.0.tgz#b2bf4ee8514aae6165b4817829d21b2ef49904ec"
 
+url-parse@^1.2.0:
+  version "1.2.0"
+  resolved "https://registry.yarnpkg.com/url-parse/-/url-parse-1.2.0.tgz#3a19e8aaa6d023ddd27dcc44cb4fc8f7fec23986"
+  dependencies:
+    querystringify "~1.0.0"
+    requires-port "~1.0.0"
+
 [email protected], util-deprecate@~1.0.1:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/util-deprecate/-/util-deprecate-1.0.2.tgz#450d4dc9fa70de732762fbd2d4a28981419a0ccf"