Patched edge case bug for concurrent CacheableImage components mounting with same source url prop and updated tests appropriately.

Author: billmalarky

lib/FileSystem.js

@@ -194,7 +194,7 @@ export class FileSystem {
 
     } else {
 
-      let result = await this.fetchFile(url, permanent);
+      let result = await this.fetchFile(url, permanent, null, true); // Clobber must be true to allow concurrent CacheableImage components with same source url (ie: bullet point images).
       filePath = result.path;
 
     }

lib/imageCacheHoc.js

@@ -73,7 +73,7 @@ export default function imageCacheHoc(Image, options = {}) {
         !traverse(this.props).get(['source', 'uri'])
         || !validator.isURL(traverse(this.props).get(['source', 'uri']), validatorUrlOptions)
       ) {
-        throw new Error('Invalid source prop. <CacheableImage> props.source.uri should be a web accessible url.');
+        throw new Error('Invalid source prop. <CacheableImage> props.source.uri should be a web accessible url with a valid protocol and host. NOTE: Default valid protocol is https, default valid hosts are *.');
       } else {
         return true;
       }

tests/CacheableImage.test.js

@@ -64,7 +64,7 @@ describe('CacheableImage', function() {
 
       throw new Error('Invalid source uri prop was accepted.');
     } catch (error) {
-      error.should.deepEqual(new Error('Invalid source prop. <CacheableImage> props.source.uri should be a web accessible url.'));
+      error.should.deepEqual(new Error('Invalid source prop. <CacheableImage> props.source.uri should be a web accessible url with a valid protocol and host. NOTE: Default valid protocol is https, default valid hosts are *.'));
     }
 
     // Verify source uri prop only accepts web accessible urls from whitelist if whitelist set.
@@ -83,7 +83,7 @@ describe('CacheableImage', function() {
 
       throw new Error('Invalid source uri prop was accepted.');
     } catch (error) {
-      error.should.deepEqual(new Error('Invalid source prop. <CacheableImage> props.source.uri should be a web accessible url.'));
+      error.should.deepEqual(new Error('Invalid source prop. <CacheableImage> props.source.uri should be a web accessible url with a valid protocol and host. NOTE: Default valid protocol is https, default valid hosts are *.'));
     }
 
     // Verify source uri prop only accepts web accessible urls from correct protocols if protocol list set.
@@ -102,7 +102,7 @@ describe('CacheableImage', function() {
 
       throw new Error('Invalid source uri prop was accepted.');
     } catch (error) {
-      error.should.deepEqual(new Error('Invalid source prop. <CacheableImage> props.source.uri should be a web accessible url.'));
+      error.should.deepEqual(new Error('Invalid source prop. <CacheableImage> props.source.uri should be a web accessible url with a valid protocol and host. NOTE: Default valid protocol is https, default valid hosts are *.'));
     }
 
   });