fix gosimple

Author: wafuwafu13

.golangci.yml

@@ -3,7 +3,6 @@ linters:
   # TODO remove this rule.
   disable:
     - errcheck
-    - gosimple
     - ineffassign
     - staticcheck
 linters-settings:

check-masterha/lib/check_masterha_status.go

@@ -29,7 +29,7 @@ func (c statusChecker) MakeCommandArgs() []string {
 
 func (c statusChecker) Parse(out string) (checkers.Status, string) {
 	lines := strings.Split(out, "\n")
-	errors := make([]string, 0, 0)
+	errors := make([]string, 0)
 
 	for _, line := range lines {
 		if line != "" && !strings.Contains(line, "running(0:PING_OK)") {

check-ssh/lib/check-ssh.go

@@ -136,7 +136,7 @@ func (opts *sshOpts) run() *checkers.Checker {
 	if err != nil {
 		if addrerr, ok := err.(*net.AddrError); ok {
 			if addrerr.Timeout() {
-				elapsed := time.Now().Sub(start)
+				elapsed := time.Since(start)
 				return opts.checkTimeoutError(elapsed, err)
 			} else if addrerr.Temporary() {
 				return checkers.Warning(err.Error())
@@ -152,7 +152,7 @@ func (opts *sshOpts) run() *checkers.Checker {
 	if err != nil {
 		return checkers.Unknown(err.Error())
 	}
-	elapsed := time.Now().Sub(start)
+	elapsed := time.Since(start)
 	return opts.checkTimeout(elapsed)
 }
 

check-ssl-cert/lib/check-ssl-cert.go

@@ -47,7 +47,7 @@ func Run(args []string) *checkers.Checker {
 		return checkers.Critical(err.Error())
 	}
 	expiry := cert.NotAfter
-	dur := expiry.Sub(time.Now())
+	dur := time.Until(expiry)
 
 	chkSt := checkers.OK
 	days := int(dur.Hours() / 24)

check-tcp/lib/check-tcp.go

@@ -223,7 +223,7 @@ func (opts *tcpOpts) run() *checkers.Checker {
 			return checkers.Critical(err.Error())
 		}
 	}
-	elapsedSeconds := float64(time.Now().Sub(start)) / float64(time.Second)
+	elapsedSeconds := float64(time.Since(start)) / float64(time.Second)
 
 	chkSt := checkers.OK
 	if opts.Warning > 0 && elapsedSeconds > opts.Warning {